From mboxrd@z Thu Jan  1 00:00:00 1970
From: Shreyansh Jain <shreyansh.jain@nxp.com>
Subject: Re: [PATCH v4 05/41] bus/dpaa: introducing FMan
	configurations
Date: Tue, 19 Sep 2017 19:13:47 +0530
Message-ID: <9d9ad4be-5112-7e79-b022-b972c9291c03@nxp.com>
References: <20170823141213.25476-1-shreyansh.jain@nxp.com>
 <20170909112132.13936-1-shreyansh.jain@nxp.com>
 <20170909112132.13936-6-shreyansh.jain@nxp.com>
 <40676af3-d4a6-f32b-0367-49421883deb2@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>,
 <hemant.agrawal@nxp.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM03-BY2-obe.outbound.protection.outlook.com
 (mail-by2nam03on0060.outbound.protection.outlook.com [104.47.42.60])
 by dpdk.org (Postfix) with ESMTP id 92CF41B161
 for <dev@dpdk.org>; Tue, 19 Sep 2017 15:32:55 +0200 (CEST)
In-Reply-To: <40676af3-d4a6-f32b-0367-49421883deb2@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Monday 18 September 2017 08:20 PM, Ferruh Yigit wrote:
> On 9/9/2017 12:20 PM, Shreyansh Jain wrote:
>> FMan or Frame Manager, inspects traffic, splits it into queueson ingress.
>> It is also responsible for directing traffic on queues on egress.
>>
>> This patch introduces FMan configurational interfaces. This layer is
>> used by Bus driver for configuring the hardware block.
>>
>> Signed-off-by: Geoff Thorpe <geoff.thorpe@nxp.com>
>> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
>> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
> 

[...]

> <...>
> 
>> +		if (!char_prop) {
>> +			printf("memac: unknown MII type assuming 1G\n");
> 
> Please prefer logging macros against direct printf.

I will change this and another similar occurrence.

> 
> <...>
>