From: "Zhang, Jerry(Junwei)" <Jerry.Zhang-5C7GfCeVMHo@public.gmane.org>
To: Alex Deucher
<alexdeucher-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Cc: Alex Deucher <alexander.deucher-5C7GfCeVMHo@public.gmane.org>
Subject: Re: [PATCH 2/2] drm/amdgpu/sdma4: use page queue 1 for buffer funcs
Date: Thu, 8 Nov 2018 10:11:31 +0800 [thread overview]
Message-ID: <9da6b213-e2d2-c0eb-6f6d-8ce39bcc2152@amd.com> (raw)
In-Reply-To: <20181107172949.27158-2-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
On 11/8/18 1:29 AM, Alex Deucher wrote:
> Use page queue 0 rather than 1 to avoid contention with GPUVM
> updates using page queue 0.
>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
A little confuse, I thought we were going to use page queue(in any
instance) for PT update,
gfx ring for general sdma jobs.
Any missing?
Regards,
Jerry
> ---
> drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c
> index 4b5b47dd2f4c..44c16a5c5428 100644
> --- a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c
> @@ -2062,7 +2062,8 @@ static void sdma_v4_0_set_buffer_funcs(struct amdgpu_device *adev)
> {
> adev->mman.buffer_funcs = &sdma_v4_0_buffer_funcs;
> if (adev->sdma.has_page_queue)
> - adev->mman.buffer_funcs_ring = &adev->sdma.instance[0].page;
> + /* use page queue 1 since page queue 0 will be used for VM updates */
> + adev->mman.buffer_funcs_ring = &adev->sdma.instance[1].page;
> else
> adev->mman.buffer_funcs_ring = &adev->sdma.instance[0].ring;
> }
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2018-11-08 2:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-07 17:29 [PATCH 1/2] drm/amdgpu/sdma4: use paging queue for buffer funcs Alex Deucher
[not found] ` <20181107172949.27158-1-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
2018-11-07 17:29 ` [PATCH 2/2] drm/amdgpu/sdma4: use page queue 1 " Alex Deucher
[not found] ` <20181107172949.27158-2-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
2018-11-08 2:11 ` Zhang, Jerry(Junwei) [this message]
[not found] ` <9da6b213-e2d2-c0eb-6f6d-8ce39bcc2152-5C7GfCeVMHo@public.gmane.org>
2018-11-08 2:58 ` Alex Deucher
2018-11-08 8:00 ` Christian König
2018-11-08 2:05 ` [PATCH 1/2] drm/amdgpu/sdma4: use paging queue " Zhang, Jerry(Junwei)
[not found] ` <19502b5a-8508-3b59-b50e-44de4ade535b-5C7GfCeVMHo@public.gmane.org>
2018-11-08 2:59 ` Alex Deucher
2018-11-08 7:44 ` Zhang, Jerry(Junwei)
[not found] ` <d7df731c-ce0f-1cad-0cf9-15b06fc738db-5C7GfCeVMHo@public.gmane.org>
2018-11-08 8:14 ` Gong, Curry
[not found] ` <BN6PR12MB1586D7AC56967190DFD835B59DC50-/b2+HYfkarTyoQOqIZFxpgdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2018-11-08 8:15 ` Gong, Curry
2018-11-08 8:01 ` Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9da6b213-e2d2-c0eb-6f6d-8ce39bcc2152@amd.com \
--to=jerry.zhang-5c7gfcevmho@public.gmane.org \
--cc=alexander.deucher-5C7GfCeVMHo@public.gmane.org \
--cc=alexdeucher-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.