From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84A95C433ED for ; Tue, 11 May 2021 07:34:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4580F61360 for ; Tue, 11 May 2021 07:34:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229924AbhEKHfv (ORCPT ); Tue, 11 May 2021 03:35:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39494 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229637AbhEKHfu (ORCPT ); Tue, 11 May 2021 03:35:50 -0400 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7366AC061574 for ; Tue, 11 May 2021 00:34:43 -0700 (PDT) Received: by mail-wr1-x42c.google.com with SMTP id s8so19060406wrw.10 for ; Tue, 11 May 2021 00:34:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=HKWKDg24ecRxcfkgLzlLS7GSbPuoRjHk4Z2wwF/ghFg=; b=HAepbMzyt0A2yPpMcwxOL3wBkYyFv6DgsLmta6/Kzy5aBAbUK1jYQs4aVoAD0m4sZ7 1pnzcajHS6YMJomP7/VWsyN5srDPSZZMzzUGLegOrUcsbDWbvCezPgNVbpwW6V59+udT UVGz4K+Mi+GTT+axMXuQF+gXSoyc5UiCTAnmEf6CEyPN9rqDzQ30rGrZiz02P43wkKVD ARwPgBQSLlENe+BfeVgx4WJIb6JduAiZ5smHCHSO5cGDIwXYz861LLmTunaNSRQf689N SKX6CXQlEsqF8AeGabuEl4AmT8rUBSGe8fO6onnJVUsBSeoajuhp8C0tbHdaip6Dn9pB MjeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=HKWKDg24ecRxcfkgLzlLS7GSbPuoRjHk4Z2wwF/ghFg=; b=KxAuuKT8yyIpfpoNSnnJsUWlIYF7/c6jLnsv4m+aevARPfzfYSGfzU4S2+Z6bLYFu6 jia7eFn6AIllPMYf+YnXPcgzMhn/mp+en2lCWO4q/yz0zdpzWeSJdfyzYU/UUM+huXJF 8pm1XyJPD6gdIvVxUvlBxWFi1uerqlJidIxNahPV7S9xFqfDw3HA1C3KfdjzefbQTyo/ kKytQOXCLHJXITxpYOpfDdLtg1WoA5bG+TgIhLxTVnGMoeFOJV8OhmtkMkjkkz57+5K8 56Oj5XbuzheE11qUX6qrQqhEk7kn3bpg+vVqp/YwAaE7W5amC4DiHA7l99WxZXB40dca DuNg== X-Gm-Message-State: AOAM532lFIAIgvbGiY1YUmc9YfNSP4HPOB/NZIiihK7asI+aqz9/h9S/ 8gRONd6ZkUrLrYqaFq/CkDIlh9Gn9QU= X-Google-Smtp-Source: ABdhPJxMEyzGOuYuAwXxnCdTwTkq7h3QK5WAbj3/AQffR1RSIsWnItkIEWCGLV5PtNYMcoTPMAYAvg== X-Received: by 2002:adf:f60d:: with SMTP id t13mr36871024wrp.189.1620718482309; Tue, 11 May 2021 00:34:42 -0700 (PDT) Received: from [10.8.0.106] ([195.53.121.100]) by smtp.gmail.com with ESMTPSA id b6sm2583870wmj.2.2021.05.11.00.34.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 May 2021 00:34:42 -0700 (PDT) Subject: Re: [PATCH] basename.3: SYNOPSIS: Add missing 'const' To: "Michael Kerrisk (man-pages)" Cc: linux-man@vger.kernel.org References: <20210509213930.94120-1-alx.manpages@gmail.com> <20210509213930.94120-4-alx.manpages@gmail.com> <797047d7-00a6-5633-43c7-35d7fd709cb9@gmail.com> From: "Alejandro Colomar (man-pages)" Message-ID: <9daadf21-54f2-4f2b-20cd-4ee7ad1c2590@gmail.com> Date: Tue, 11 May 2021 09:34:40 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <797047d7-00a6-5633-43c7-35d7fd709cb9@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-man@vger.kernel.org Hi Michael, On 5/10/21 1:59 AM, Michael Kerrisk (man-pages) wrote: > Hi Alex, > > On 5/10/21 9:38 AM, Alejandro Colomar wrote: >> Glibc uses 'const' for the basename() parameter. >> Fix the prototype. > > Yes, but see basename(3p): > > SYNOPSIS > #include > > char *basename(char *path); > > ... > > The basename() function may modify the string pointed to by path, > and may return a pointer to internal storage. The returned pointer > might be invalidated or the storage might be overwritten by a sub‐ > sequent call to basename(). The returned pointer might also be > invalidated if the calling thread is terminated. > > I'll skip this patch. It's POSIX that states that, so yes, I'll drop it. Cheers, Alex -- Alejandro Colomar Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/ http://www.alejandro-colomar.es/