From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 292E6C19F28 for ; Wed, 3 Aug 2022 11:39:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237580AbiHCLjT (ORCPT ); Wed, 3 Aug 2022 07:39:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58158 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236055AbiHCLjS (ORCPT ); Wed, 3 Aug 2022 07:39:18 -0400 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5CE4E1054C for ; Wed, 3 Aug 2022 04:39:17 -0700 (PDT) Received: by mail-lf1-x12f.google.com with SMTP id m22so14181041lfl.9 for ; Wed, 03 Aug 2022 04:39:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=8MZZ0oEY6nNZhBhfKV+zcplONcJQxnevzhBhdZaccrc=; b=lc7tQTTr/ygXNfabycR/8BIAJl35h/h1QxP3VWgaT51MYPgilLT5fdDSxNr7wp77jz FxnkYfIvIV4kDEYhNTDSw2GZtv5gB0bjEvxm2vZayy7Kwa4baFHsLGXt1KH/U/j44HJG 7/G38RGqfxAYObs2clampTmtesdEtJYcsKQitlvAX+0rN5aZZoKbDN7gPG1N8/kcbOPZ cs988ckLNZqu7Wd0XNP0/ZznhThxEYBSWuyboR6LdgwZxC4x7YBew1drJ0TsxWU5DM2z TGplrcTqBoebVgVxVYj+vqTFsDpZt2f+PfqQ1Rllo45FG75Kp2/fqfBx5C1TNUxXkIZz ccZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=8MZZ0oEY6nNZhBhfKV+zcplONcJQxnevzhBhdZaccrc=; b=bbIMhegjllFZ0npdD9avCh4J5fKThz2G259rXWrEgwMng6UUn+hS2TmWCaReHeGuxF 2yrB0INDL+ZlDKrUJVam+T/kkw4AnGVyVT6vOctdygqRo1nHHVnTrbjndkJ4b+HEanLP is81tGYrkabctmNAqjRKnwWcctY+3+8YFk35HnVmMfDBWTaTMQCwE3uXUmZKbsFAn7kZ VkDZT67vICaxBM4GDeL8bIczdUTUyc3+0BrUn9Y+9tv6KFWqGf01qk3VDPv9TSFw8JqY 4KxSSie3e7+6Ne21Nk4jFSB/93N1TIdV8av2NzilWBQYEwIox+/qKEu7fSdsdGviVUe3 R2nQ== X-Gm-Message-State: ACgBeo3XCTo2asyK8e18qjly+7i8zaO1yoMqk+GSh1Wp51hE3dhtk7iF p0NGfPPKDQUhPQ9WD6SwYI+5zA== X-Google-Smtp-Source: AA6agR77sn308/0hr2la0OlOPTBlCJeQ5gjLPt6ejGMTr23q/Jcaj3ga/UVaZwxx4c12GNQ+4uLWpw== X-Received: by 2002:a05:6512:239e:b0:48b:287d:cbd3 with SMTP id c30-20020a056512239e00b0048b287dcbd3mr218702lfv.409.1659526754252; Wed, 03 Aug 2022 04:39:14 -0700 (PDT) Received: from [192.168.1.6] ([77.222.167.48]) by smtp.gmail.com with ESMTPSA id e12-20020a05651c038c00b0025e436214c8sm1605311ljp.78.2022.08.03.04.39.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Aug 2022 04:39:13 -0700 (PDT) Message-ID: <9db34922-f3e1-1536-59ce-c95d364ffe2c@linaro.org> Date: Wed, 3 Aug 2022 13:39:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v2 02/20] dt-bindings: power: Add power-domain header for RV1126 Content-Language: en-US To: Jagan Teki Cc: Heiko Stuebner , Rob Herring , Krzysztof Kozlowski , Kever Yang , linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, Elaine Zhang References: <20220731174726.72631-1-jagan@edgeble.ai> <20220731174726.72631-3-jagan@edgeble.ai> <4f8b8b98-c0ef-4924-6ff1-ccfeae77fc21@linaro.org> <288b4d6e-68f9-26ef-c80d-cbcdaf9d2eed@linaro.org> <88a18350-33fb-81e9-7984-7490da83a4a3@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 03/08/2022 13:30, Jagan Teki wrote: > On Wed, 3 Aug 2022 at 16:57, Krzysztof Kozlowski > wrote: >> >> On 03/08/2022 12:46, Jagan Teki wrote: >>> On Wed, 3 Aug 2022 at 16:13, Krzysztof Kozlowski >>> wrote: >>>> >>>> On 03/08/2022 12:24, Jagan Teki wrote: >>>>>> Vendor in filename is needed. >>>>> >>>>> Yes this follows how similar rockchip vendor notation >>>>> >>>>> $ ls include/dt-bindings/power/rk3* -l >>>>> include/dt-bindings/power/rk3036-power.h >>>>> include/dt-bindings/power/rk3066-power.h >>>>> include/dt-bindings/power/rk3128-power.h >>>>> include/dt-bindings/power/rk3188-power.h >>>>> include/dt-bindings/power/rk3228-power.h >>>>> include/dt-bindings/power/rk3288-power.h >>>>> include/dt-bindings/power/rk3328-power.h >>>>> include/dt-bindings/power/rk3366-power.h >>>>> include/dt-bindings/power/rk3368-power.h >>>>> include/dt-bindings/power/rk3399-power.h >>>>> include/dt-bindings/power/rk3568-power.h >>>> >>>> >>>> So when are we going to switch to vendor,device pattern if you keep >>>> adding files with wrong naming? >>> >>> Do you mean the above files are following the wrong naming pattern? >> >> Yes, or at least discouraged naming. The recommended naming which I hope >> all new files will follow are vendor,device.h. > > rockchip-rv1126-power.h > > Will this be Okay? After vendor prefix goes coma, so rockchip,rv1126-power.h Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 24903C19F28 for ; Wed, 3 Aug 2022 11:39:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4HS/oCRhkWEACpiHA8CCqZ+KuWJGAmH5Cz6iChAb2gE=; b=aZYgElE6L6cQhP VG4X3h9KNyF0m8q0QqMHuVnSqza5bpaTvsOFdeCY7RjkCq9pJyKu90BFi184zcm6DC4lWmnUXAqHX UkT3KwCdPtaOixRSKJycSN8nO9DNOMWcms/mDvU6TdM365nbIb+yqGQQPQMNyC1xNJHtOBJxi+q4y 9wdrqJ7cJrjuDDQ1sBXyW9mLspDxWONEwwFiL60VeyhoRtljM7vOqtkTH0jf9F7vxQa6If0Fnpp1P SIvySs3pHabi2Qyi44ffdU/8pReTw8chpubuPa2hoAAU8OnKbQ9ZuS+BQRM/LHTYQ7JPT3CZfBDSe pWS4kCK6AD2XO6vyx+jw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oJCig-005SDm-UQ; Wed, 03 Aug 2022 11:39:22 +0000 Received: from mail-lf1-x130.google.com ([2a00:1450:4864:20::130]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oJCic-005S8U-Bc for linux-rockchip@lists.infradead.org; Wed, 03 Aug 2022 11:39:20 +0000 Received: by mail-lf1-x130.google.com with SMTP id t1so25979492lft.8 for ; Wed, 03 Aug 2022 04:39:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=8MZZ0oEY6nNZhBhfKV+zcplONcJQxnevzhBhdZaccrc=; b=lc7tQTTr/ygXNfabycR/8BIAJl35h/h1QxP3VWgaT51MYPgilLT5fdDSxNr7wp77jz FxnkYfIvIV4kDEYhNTDSw2GZtv5gB0bjEvxm2vZayy7Kwa4baFHsLGXt1KH/U/j44HJG 7/G38RGqfxAYObs2clampTmtesdEtJYcsKQitlvAX+0rN5aZZoKbDN7gPG1N8/kcbOPZ cs988ckLNZqu7Wd0XNP0/ZznhThxEYBSWuyboR6LdgwZxC4x7YBew1drJ0TsxWU5DM2z TGplrcTqBoebVgVxVYj+vqTFsDpZt2f+PfqQ1Rllo45FG75Kp2/fqfBx5C1TNUxXkIZz ccZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=8MZZ0oEY6nNZhBhfKV+zcplONcJQxnevzhBhdZaccrc=; b=mLisQ1CmajrvIzWMA3WmW46xSQd9AKKkp5ZjY8uZBi2hrP//kU+uGYLvYyIJ9iscd/ tBcLdAoM6Fi6nSYPIXg5HiD1pEm6tIal4v7YrIPg0jEUlBZa5b60wpGlsgBdkT3dY8lY NI246jeU8LDwB4YMFpPh0bugt37cOPO6DDC6WnbRnOY/2km8Dzjwd0/5vxH7HB/B3Q64 qkw2IKLxgtOoevd09j1OdyU0X/LbaZzOj9I6lYQvvlXlG5PLhlajibd1R48lnUvCb4Zd L7joEn3dhbTuWdqLhrehA6re4wC9Buk9Mq3ZfIy7dBkq5/hDbDHPl7I+H1YxLfpxLu9r QIOA== X-Gm-Message-State: ACgBeo102cq/tkQXWdZVDcRjplC080Xl8rXj0co+zKULDpuQIaLm9UfN FGf3zqYEl2UWDBBHZGxNuyR46Q== X-Google-Smtp-Source: AA6agR77sn308/0hr2la0OlOPTBlCJeQ5gjLPt6ejGMTr23q/Jcaj3ga/UVaZwxx4c12GNQ+4uLWpw== X-Received: by 2002:a05:6512:239e:b0:48b:287d:cbd3 with SMTP id c30-20020a056512239e00b0048b287dcbd3mr218702lfv.409.1659526754252; Wed, 03 Aug 2022 04:39:14 -0700 (PDT) Received: from [192.168.1.6] ([77.222.167.48]) by smtp.gmail.com with ESMTPSA id e12-20020a05651c038c00b0025e436214c8sm1605311ljp.78.2022.08.03.04.39.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Aug 2022 04:39:13 -0700 (PDT) Message-ID: <9db34922-f3e1-1536-59ce-c95d364ffe2c@linaro.org> Date: Wed, 3 Aug 2022 13:39:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v2 02/20] dt-bindings: power: Add power-domain header for RV1126 Content-Language: en-US To: Jagan Teki Cc: Heiko Stuebner , Rob Herring , Krzysztof Kozlowski , Kever Yang , linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, Elaine Zhang References: <20220731174726.72631-1-jagan@edgeble.ai> <20220731174726.72631-3-jagan@edgeble.ai> <4f8b8b98-c0ef-4924-6ff1-ccfeae77fc21@linaro.org> <288b4d6e-68f9-26ef-c80d-cbcdaf9d2eed@linaro.org> <88a18350-33fb-81e9-7984-7490da83a4a3@linaro.org> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220803_043918_562226_7E749A00 X-CRM114-Status: GOOD ( 13.30 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On 03/08/2022 13:30, Jagan Teki wrote: > On Wed, 3 Aug 2022 at 16:57, Krzysztof Kozlowski > wrote: >> >> On 03/08/2022 12:46, Jagan Teki wrote: >>> On Wed, 3 Aug 2022 at 16:13, Krzysztof Kozlowski >>> wrote: >>>> >>>> On 03/08/2022 12:24, Jagan Teki wrote: >>>>>> Vendor in filename is needed. >>>>> >>>>> Yes this follows how similar rockchip vendor notation >>>>> >>>>> $ ls include/dt-bindings/power/rk3* -l >>>>> include/dt-bindings/power/rk3036-power.h >>>>> include/dt-bindings/power/rk3066-power.h >>>>> include/dt-bindings/power/rk3128-power.h >>>>> include/dt-bindings/power/rk3188-power.h >>>>> include/dt-bindings/power/rk3228-power.h >>>>> include/dt-bindings/power/rk3288-power.h >>>>> include/dt-bindings/power/rk3328-power.h >>>>> include/dt-bindings/power/rk3366-power.h >>>>> include/dt-bindings/power/rk3368-power.h >>>>> include/dt-bindings/power/rk3399-power.h >>>>> include/dt-bindings/power/rk3568-power.h >>>> >>>> >>>> So when are we going to switch to vendor,device pattern if you keep >>>> adding files with wrong naming? >>> >>> Do you mean the above files are following the wrong naming pattern? >> >> Yes, or at least discouraged naming. The recommended naming which I hope >> all new files will follow are vendor,device.h. > > rockchip-rv1126-power.h > > Will this be Okay? After vendor prefix goes coma, so rockchip,rv1126-power.h Best regards, Krzysztof _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E33F3C19F28 for ; Wed, 3 Aug 2022 11:40:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GWfwNv8wr6O1WCbrUCAIoCb4YoFLYhazkOQAIXyODhk=; b=wufqv9B0GJ86on KgKuufTYCL41+aGIzv3RCj3rkxQlWXQWQvSld98Nee5e2lDBUtESL0pc7GkWdTCnfZ6pnSnqTE96g 8OMirwOGua+pFhQBtmkARuNi9K9JLQvWfs6oukOQuTglqgUmuwYusyvAejLyWAr+U58DURTf85GuP oEKsc/S2aHOUNrbYtYmyeUdnr8IMELnMpWDix7wofScpnfQe8h/BpS1BhgFgih/A633MaKCjJRTqf YDnthTXvK4zZ0luRTrgX0nJPAAY6OzhsvAkP9WsoxUdk6wP8gq5W2UDX19V3Iu5wrUp/0XxLTD1mB gyeelBzHNWz2xsTyNXDw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oJCij-005SFM-PF; Wed, 03 Aug 2022 11:39:26 +0000 Received: from mail-lf1-x12e.google.com ([2a00:1450:4864:20::12e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oJCic-005S8V-Ba for linux-arm-kernel@lists.infradead.org; Wed, 03 Aug 2022 11:39:20 +0000 Received: by mail-lf1-x12e.google.com with SMTP id x39so16415249lfu.7 for ; Wed, 03 Aug 2022 04:39:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=8MZZ0oEY6nNZhBhfKV+zcplONcJQxnevzhBhdZaccrc=; b=lc7tQTTr/ygXNfabycR/8BIAJl35h/h1QxP3VWgaT51MYPgilLT5fdDSxNr7wp77jz FxnkYfIvIV4kDEYhNTDSw2GZtv5gB0bjEvxm2vZayy7Kwa4baFHsLGXt1KH/U/j44HJG 7/G38RGqfxAYObs2clampTmtesdEtJYcsKQitlvAX+0rN5aZZoKbDN7gPG1N8/kcbOPZ cs988ckLNZqu7Wd0XNP0/ZznhThxEYBSWuyboR6LdgwZxC4x7YBew1drJ0TsxWU5DM2z TGplrcTqBoebVgVxVYj+vqTFsDpZt2f+PfqQ1Rllo45FG75Kp2/fqfBx5C1TNUxXkIZz ccZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=8MZZ0oEY6nNZhBhfKV+zcplONcJQxnevzhBhdZaccrc=; b=WmXLz54M202psl9FahcnGRqFR1+WaZJ5gGpeLWynpgTXpWu3qZThegPZ4G9WsRmlh7 mbcIPRwrbTieq2ENLvWY1/uuRLw3Xr20RWttkmrFx2NY9Je7g27JGDMg1MFTleuZsEBO jkt2RzzYC+IupFspF+ljAZmXzCukHCYN8KjeFnkpzbTRQTk+tSMJ6gNGUY7eF7qhvhLJ jkUfOpyqnDIy5PXrazs4AcfrzggWRP4R1Fb0JKALFbeNbqOdQI2ncqAfZGtaYKiy2DX7 kKEueXIPU44t2xABlIA+e9sEEdpG6LAFJ8fGIqFHd3+tSe3nFeuiVsjMVybsr0yxHq9F 4Iyg== X-Gm-Message-State: ACgBeo0jb3EaRcj94xwKDCaK20uGFAXYffEV+/nQaZrDjlSGgxF3XrNa RLLdaTXBL9FLotZNRxIQFXHJtg== X-Google-Smtp-Source: AA6agR77sn308/0hr2la0OlOPTBlCJeQ5gjLPt6ejGMTr23q/Jcaj3ga/UVaZwxx4c12GNQ+4uLWpw== X-Received: by 2002:a05:6512:239e:b0:48b:287d:cbd3 with SMTP id c30-20020a056512239e00b0048b287dcbd3mr218702lfv.409.1659526754252; Wed, 03 Aug 2022 04:39:14 -0700 (PDT) Received: from [192.168.1.6] ([77.222.167.48]) by smtp.gmail.com with ESMTPSA id e12-20020a05651c038c00b0025e436214c8sm1605311ljp.78.2022.08.03.04.39.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Aug 2022 04:39:13 -0700 (PDT) Message-ID: <9db34922-f3e1-1536-59ce-c95d364ffe2c@linaro.org> Date: Wed, 3 Aug 2022 13:39:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v2 02/20] dt-bindings: power: Add power-domain header for RV1126 Content-Language: en-US To: Jagan Teki Cc: Heiko Stuebner , Rob Herring , Krzysztof Kozlowski , Kever Yang , linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, Elaine Zhang References: <20220731174726.72631-1-jagan@edgeble.ai> <20220731174726.72631-3-jagan@edgeble.ai> <4f8b8b98-c0ef-4924-6ff1-ccfeae77fc21@linaro.org> <288b4d6e-68f9-26ef-c80d-cbcdaf9d2eed@linaro.org> <88a18350-33fb-81e9-7984-7490da83a4a3@linaro.org> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220803_043918_568312_1458EC4A X-CRM114-Status: GOOD ( 14.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 03/08/2022 13:30, Jagan Teki wrote: > On Wed, 3 Aug 2022 at 16:57, Krzysztof Kozlowski > wrote: >> >> On 03/08/2022 12:46, Jagan Teki wrote: >>> On Wed, 3 Aug 2022 at 16:13, Krzysztof Kozlowski >>> wrote: >>>> >>>> On 03/08/2022 12:24, Jagan Teki wrote: >>>>>> Vendor in filename is needed. >>>>> >>>>> Yes this follows how similar rockchip vendor notation >>>>> >>>>> $ ls include/dt-bindings/power/rk3* -l >>>>> include/dt-bindings/power/rk3036-power.h >>>>> include/dt-bindings/power/rk3066-power.h >>>>> include/dt-bindings/power/rk3128-power.h >>>>> include/dt-bindings/power/rk3188-power.h >>>>> include/dt-bindings/power/rk3228-power.h >>>>> include/dt-bindings/power/rk3288-power.h >>>>> include/dt-bindings/power/rk3328-power.h >>>>> include/dt-bindings/power/rk3366-power.h >>>>> include/dt-bindings/power/rk3368-power.h >>>>> include/dt-bindings/power/rk3399-power.h >>>>> include/dt-bindings/power/rk3568-power.h >>>> >>>> >>>> So when are we going to switch to vendor,device pattern if you keep >>>> adding files with wrong naming? >>> >>> Do you mean the above files are following the wrong naming pattern? >> >> Yes, or at least discouraged naming. The recommended naming which I hope >> all new files will follow are vendor,device.h. > > rockchip-rv1126-power.h > > Will this be Okay? After vendor prefix goes coma, so rockchip,rv1126-power.h Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel