From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v3 00/22] net/atlantic: Aquantia aQtion 10G
 NIC Family DPDK PMD driver
Date: Thu, 4 Oct 2018 11:29:52 +0100
Message-ID: <9dc8e261-e322-aaae-0703-d1f774449b56@intel.com>
References: <cover.1538215990.git.igor.russkikh@aquantia.com>
 <43067ae0-bb4f-5f6d-22dd-7d24b7409ae1@intel.com>
 <cfc6e1d6-4074-22a6-8894-8af10f1055f8@aquantia.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: Pavel Belous <Pavel.Belous@aquantia.com>
To: Igor Russkikh <Igor.Russkikh@aquantia.com>, "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 91CEE1B1A0
 for <dev@dpdk.org>; Thu,  4 Oct 2018 12:29:55 +0200 (CEST)
In-Reply-To: <cfc6e1d6-4074-22a6-8894-8af10f1055f8@aquantia.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 10/4/2018 10:42 AM, Igor Russkikh wrote:
> Hi Ferruh,
> 
> Thanks again for the review, we'll investigate and work on your comments!
> 
>>> +CONFIG_RTE_LIBRTE_ATLANTIC_PMD=y
>> Just to check, default enable in "common_base" means PMD supports all
>> architectures (x86_64, i686, arm, ppc) and both Linux and FreeBSD.
>> If this is not the case, please disable in common_base and enable in whatever
>> supported.
> 
> We actually don't have an ability to test and verify on PPC.
> We are pretty confident on x86_64, i686 and arm.
> 
> Thus, will it be ok to add `N` into defconfig_ppc_64-power8-linuxapp-gcc only?

If FreeBSD is also supported yes, above will be OK.

> 
>> Thanks for the update. But a reminder, each patch should be build and
>> functional, there are build errors when first patch applied. I think build is
>> broken until 7/22.
>>
>> Can you please re-work the patchset to make each patch compiles?
> 
> Thats strange because we explicitly tested that.
> CI also states its OK:
> http://patchwork.dpdk.org/project/dpdk/list/?series=1598&submitter=&state=*&q=&archive=&delegate=
> 
> Could it be some custom build environment on your side, or may be you do apply it
> on different base, not master?

I double checked, after fist patch applied getting following build error [1],
and it seems valid because "atl_eth_dev_ops" not used at all.


[1]
.../drivers/net/atlantic/atl_ethdev.c:63:33: error: unused variable
'atl_eth_dev_ops' [-Werror,-Wunused-const-variable]
static const struct eth_dev_ops atl_eth_dev_ops = {
                                ^