From: Guenter Roeck <linux@roeck-us.net>
To: Jean Delvare <jdelvare@suse.de>, Sascha Hauer <s.hauer@pengutronix.de>
Cc: linux-hwmon@vger.kernel.org
Subject: Re: [PATCH] hwmon: (jc42) Fix name to have no illegal characters
Date: Fri, 17 Apr 2020 20:14:54 -0700 [thread overview]
Message-ID: <9ddf4f81-ac0d-8b76-134b-b5074b17ddfb@roeck-us.net> (raw)
In-Reply-To: <20200417115503.249d4d48@endymion>
On 4/17/20 2:55 AM, Jean Delvare wrote:
> Hi Sascha,
>
> On Fri, 17 Apr 2020 11:28:53 +0200, Sascha Hauer wrote:
>> The jc42 driver passes I2C client's name as hwmon device name. In case
>> of device tree probed devices this ends up being part of the compatible
>> string, "jc-42.4-temp". This name contains hyphens and the hwmon core
>> doesn't like this:
>>
>> jc42 2-0018: hwmon: 'jc-42.4-temp' is not a valid name attribute, please fix
>>
>> This changes the name to "jc42" which doesn't have any illegal
>> characters.
>
> I don't think "jc-42.4-temp" is a valid i2c client name either. I
> believe this should be fixed at the of->i2c level, rather than the
> i2c->hwmon level. Not sure how other drivers are dealing with that, it
> seems that in most cases the name part of the compatible string matches
> exactly the expected client name so no conversion is needed.
>
The problem here is that the compatible string is simply wrong. It
precedes the time when I understood devicetree properties well enough
to understand what I was doing. Oh well.
No idea what to do at this point other than accepting this patch.
Guenter
next prev parent reply other threads:[~2020-04-18 3:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 9:28 [PATCH] hwmon: (jc42) Fix name to have no illegal characters Sascha Hauer
2020-04-17 9:55 ` Jean Delvare
2020-04-17 10:32 ` Sascha Hauer
2020-04-17 13:47 ` Jean Delvare
2020-04-18 3:19 ` Guenter Roeck
2020-04-18 3:14 ` Guenter Roeck [this message]
2020-04-18 17:13 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ddf4f81-ac0d-8b76-134b-b5074b17ddfb@roeck-us.net \
--to=linux@roeck-us.net \
--cc=jdelvare@suse.de \
--cc=linux-hwmon@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.