From: Arnout Vandecappelle <arnout@mind.be>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/nmap: add zlib optional dependency
Date: Wed, 6 Oct 2021 21:26:21 +0200 [thread overview]
Message-ID: <9de2436a-09d8-9fd4-faae-911c8f9e5990@mind.be> (raw)
In-Reply-To: <20210923221555.1409302-1-fontaine.fabrice@gmail.com>
On 24/09/2021 00:15, Fabrice Fontaine wrote:
> zlib is an optional dependency since bump to version 7.60 in commit
> c4faf1d4d11764da769abdd252dd3925d83378cb and
> https://github.com/nmap/nmap/commit/0c142333bb356b6ff15fff5c95522c4cfc410a9c.
> If it is not disabled, nmap will build its own zlib version which can
> result in the following build failure:
>
> /home/giuliobenetti/autobuild/run/instance-1/output-1/host/opt/ext-toolchain/bin/../lib/gcc/i686-buildroot-linux-uclibc/9.3.0/../../../../i686-buildroot-linux-uclibc/bin/ld: attempted static link of dynamic object `libz.so.1.2.11'
>
> Fixes:
> - http://autobuild.buildroot.org/results/da9469e24390c94fe74f133152dc320c21872159
> - http://autobuild.buildroot.org/results/53034d8dd506bc033dc92343f9a37cd4ac8b2142
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Applied to master, thanks.
Regards,
Arnout
> ---
> package/nmap/nmap.mk | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/package/nmap/nmap.mk b/package/nmap/nmap.mk
> index 13414a56ee..34cf61ff0b 100644
> --- a/package/nmap/nmap.mk
> +++ b/package/nmap/nmap.mk
> @@ -44,6 +44,13 @@ else
> NMAP_CONF_OPTS += --without-openssl
> endif
>
> +ifeq ($(BR2_PACKAGE_ZLIB),y)
> +NMAP_CONF_OPTS += --with-libz="$(STAGING_DIR)/usr"
> +NMAP_DEPENDENCIES += zlib
> +else
> +NMAP_CONF_OPTS += --without-libz
> +endif
> +
> NMAP_INSTALL_TARGET_OPTS = DESTDIR=$(TARGET_DIR)
>
> ifeq ($(BR2_PACKAGE_NMAP_NCAT),y)
>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2021-10-06 19:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-23 22:15 [Buildroot] [PATCH 1/1] package/nmap: add zlib optional dependency Fabrice Fontaine
2021-10-06 19:26 ` Arnout Vandecappelle [this message]
2021-10-07 7:46 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9de2436a-09d8-9fd4-faae-911c8f9e5990@mind.be \
--to=arnout@mind.be \
--cc=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.