From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Date: Sun, 12 Jun 2016 11:32:52 +0000 Subject: Re: [PATCH v2 05/17] sh: command line passing chosen/bootargs in devicetree Message-Id: <9def6543-5185-0248-72fd-67c6dae3b962@cogentembedded.com> List-Id: References: <1465714475-24111-1-git-send-email-ysato@users.sourceforge.jp> <1465714475-24111-6-git-send-email-ysato@users.sourceforge.jp> In-Reply-To: <1465714475-24111-6-git-send-email-ysato@users.sourceforge.jp> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Yoshinori Sato , linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org On 6/12/2016 9:54 AM, Yoshinori Sato wrote: > Signed-off-by: Yoshinori Sato > --- > arch/sh/kernel/setup.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/sh/kernel/setup.c b/arch/sh/kernel/setup.c > index 8e3b099..d97de16 100644 > --- a/arch/sh/kernel/setup.c > +++ b/arch/sh/kernel/setup.c > @@ -280,6 +280,8 @@ void __init setup_arch(char **cmdline_p) > #endif > enable_mmu(); > > + Another empty line hardly needed here. > +#ifndef CONFIG_OF > ROOT_DEV = old_decode_dev(ORIG_ROOT_DEV); > > printk(KERN_NOTICE "Boot params:\n" [...] MBR, Sergei From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932641AbcFLLcz (ORCPT ); Sun, 12 Jun 2016 07:32:55 -0400 Received: from mail-lf0-f44.google.com ([209.85.215.44]:35017 "EHLO mail-lf0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932528AbcFLLcx (ORCPT ); Sun, 12 Jun 2016 07:32:53 -0400 Subject: Re: [PATCH v2 05/17] sh: command line passing chosen/bootargs in devicetree To: Yoshinori Sato , linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org References: <1465714475-24111-1-git-send-email-ysato@users.sourceforge.jp> <1465714475-24111-6-git-send-email-ysato@users.sourceforge.jp> From: Sergei Shtylyov Message-ID: <9def6543-5185-0248-72fd-67c6dae3b962@cogentembedded.com> Date: Sun, 12 Jun 2016 14:32:52 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <1465714475-24111-6-git-send-email-ysato@users.sourceforge.jp> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/12/2016 9:54 AM, Yoshinori Sato wrote: > Signed-off-by: Yoshinori Sato > --- > arch/sh/kernel/setup.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/sh/kernel/setup.c b/arch/sh/kernel/setup.c > index 8e3b099..d97de16 100644 > --- a/arch/sh/kernel/setup.c > +++ b/arch/sh/kernel/setup.c > @@ -280,6 +280,8 @@ void __init setup_arch(char **cmdline_p) > #endif > enable_mmu(); > > + Another empty line hardly needed here. > +#ifndef CONFIG_OF > ROOT_DEV = old_decode_dev(ORIG_ROOT_DEV); > > printk(KERN_NOTICE "Boot params:\n" [...] MBR, Sergei