All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christophe LEROY <christophe.leroy@c-s.fr>
To: Michael Ellerman <mpe@ellerman.id.au>,
	Andreas Schwab <schwab@linux-m68k.org>,
	Michael Neuling <mikey@neuling.org>
Cc: "Michal Suchánek" <msuchanek@suse.de>,
	linuxppc-dev@lists.ozlabs.org,
	"Nicholas Piggin" <npiggin@gmail.com>,
	"Haren Myneni" <haren@linux.vnet.ibm.com>
Subject: Re: [PATCH v4] powerpc: Avoid code patching freed init sections
Date: Wed, 3 Oct 2018 07:42:25 +0200	[thread overview]
Message-ID: <9df89bf6-6c7f-1b60-c023-3a73169eb5e0@c-s.fr> (raw)
In-Reply-To: <87va6jk97a.fsf@concordia.ellerman.id.au>



Le 03/10/2018 à 05:20, Michael Ellerman a écrit :
> Andreas Schwab <schwab@linux-m68k.org> writes:
> 
>> On Sep 14 2018, Michael Neuling <mikey@neuling.org> wrote:
>>
>>> This stops us from doing code patching in init sections after they've
>>> been freed.
>>
>> This breaks booting on PowerBook6,7, crashing very early.
> 
> Crud, sorry.
> 
> My CI setup tests with the mac99 qemu model, but that boots happily, not
> sure why.

Maybe mac99 doesn't use relocation ?

The issue is that during early boot, 'init_mem_is_free' is not yet at 
its definitif address.

I sent a fix for it : https://patchwork.ozlabs.org/patch/977195/

Christophe

  reply	other threads:[~2018-10-03  5:47 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20180914011411.3184-1-mikey__14553.8904158913$1536887645$gmane$org@neuling.org>
2018-10-02 21:35 ` [PATCH v4] powerpc: Avoid code patching freed init sections Andreas Schwab
2018-10-03  1:57   ` Michael Neuling
2018-10-03  3:20   ` Michael Ellerman
2018-10-03  5:42     ` Christophe LEROY [this message]
     [not found] ` <871s98av6p.fsf__4781.35763337395$1538516654$gmane$org@igel.home>
2018-10-02 22:33   ` [PATCH] powerpc: use PTRRELOC during early init Andreas Schwab
2018-10-03  6:22     ` Christophe LEROY
2018-10-03 11:18       ` Andreas Schwab
2018-09-14  1:14 [PATCH v4] powerpc: Avoid code patching freed init sections Michael Neuling
2018-09-14  4:22 ` Nicholas Piggin
2018-09-18  8:52   ` Christophe LEROY
2018-09-18 11:35     ` Michal Suchánek
2018-09-14  5:32 ` Christophe LEROY

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9df89bf6-6c7f-1b60-c023-3a73169eb5e0@c-s.fr \
    --to=christophe.leroy@c-s.fr \
    --cc=haren@linux.vnet.ibm.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mikey@neuling.org \
    --cc=mpe@ellerman.id.au \
    --cc=msuchanek@suse.de \
    --cc=npiggin@gmail.com \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.