All of lore.kernel.org
 help / color / mirror / Atom feed
From: Saeed Mahameed <saeedm@mellanox.com>
To: "jakub.kicinski@netronome.com" <jakub.kicinski@netronome.com>
Cc: Eran Ben Elisha <eranbe@mellanox.com>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	Tariq Toukan <tariqt@mellanox.com>
Subject: Re: [net 04/15] net/mlx5e: kTLS, Size of a Dump WQE is fixed
Date: Tue, 22 Oct 2019 18:06:11 +0000	[thread overview]
Message-ID: <9dfe7833e5b0a5f9a664c0207e79756c8a868e23.camel@mellanox.com> (raw)
In-Reply-To: <20191018161302.7dffc832@cakuba.netronome.com>

On Fri, 2019-10-18 at 16:13 -0700, Jakub Kicinski wrote:
> On Fri, 18 Oct 2019 19:38:09 +0000, Saeed Mahameed wrote:
> > From: Tariq Toukan <tariqt@mellanox.com>
> > 
> > No Eth segment, so no dynamic inline headers.
> > The size of a Dump WQE is fixed, use constants and remove
> > unnecessary checks.
> > 
> > Fixes: d2ead1f360e8 ("net/mlx5e: Add kTLS TX HW offload support")
> > Signed-off-by: Tariq Toukan <tariqt@mellanox.com>
> > Reviewed-by: Eran Ben Elisha <eranbe@mellanox.com>
> > Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
> 
> Is this a fix?


sort of, this patch fundamentally changes the way mlx5 treats kTLS TX
descriptors, to make downstream patches simpler and more correct.

  reply	other threads:[~2019-10-22 18:06 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-18 19:37 [pull request][net 00/15] Mellanox, mlx5 kTLS fixes 18-10-2019 Saeed Mahameed
2019-10-18 19:38 ` [net 01/15] net/mlx5e: Tx, Fix assumption of single WQEBB of NOP in cleanup flow Saeed Mahameed
2019-10-18 19:38 ` [net 02/15] net/mlx5e: Tx, Zero-memset WQE info struct upon update Saeed Mahameed
2019-10-18 19:38 ` [net 03/15] net/mlx5e: kTLS, Release reference on DUMPed fragments in shutdown flow Saeed Mahameed
2019-10-18 19:38 ` [net 04/15] net/mlx5e: kTLS, Size of a Dump WQE is fixed Saeed Mahameed
2019-10-18 23:13   ` Jakub Kicinski
2019-10-22 18:06     ` Saeed Mahameed [this message]
2019-10-18 19:38 ` [net 05/15] net/mlx5e: kTLS, Save only the frag page to release at completion Saeed Mahameed
2019-10-18 19:38 ` [net 06/15] net/mlx5e: kTLS, Save by-value copy of the record frags Saeed Mahameed
2019-10-18 19:38 ` [net 07/15] net/mlx5e: kTLS, Fix page refcnt leak in TX resync error flow Saeed Mahameed
2019-10-18 19:38 ` [net 08/15] net/mlx5e: kTLS, Fix missing SQ edge fill Saeed Mahameed
2019-10-18 19:38 ` [net 09/15] net/mlx5e: kTLS, Limit DUMP wqe size Saeed Mahameed
2019-10-18 19:38 ` [net 10/15] net/mlx5e: kTLS, Remove unneeded cipher type checks Saeed Mahameed
2019-10-18 23:13   ` Jakub Kicinski
2019-10-18 19:38 ` [net 11/15] net/mlx5e: kTLS, Save a copy of the crypto info Saeed Mahameed
2019-10-18 23:16   ` Jakub Kicinski
2019-10-20  7:46     ` Tariq Toukan
2019-10-20 17:08       ` Jakub Kicinski
2019-10-18 19:38 ` [net 12/15] net/mlx5e: kTLS, Enhance TX resync flow Saeed Mahameed
2019-10-19  1:51   ` Jakub Kicinski
2019-10-22 18:10     ` Saeed Mahameed
2019-10-22 18:42       ` Jakub Kicinski
2019-10-22 18:52         ` Saeed Mahameed
2019-10-18 19:38 ` [net 13/15] net/mlx5e: TX, Fix consumer index of error cqe dump Saeed Mahameed
2019-10-18 19:38 ` [net 14/15] net/mlx5: prevent memory leak in mlx5_fpga_conn_create_cq Saeed Mahameed
2019-10-18 19:38 ` [net 15/15] net/mlx5: fix memory leak in mlx5_fw_fatal_reporter_dump Saeed Mahameed
2019-10-21 16:19 ` [pull request][net 00/15] Mellanox, mlx5 kTLS fixes 18-10-2019 David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9dfe7833e5b0a5f9a664c0207e79756c8a868e23.camel@mellanox.com \
    --to=saeedm@mellanox.com \
    --cc=davem@davemloft.net \
    --cc=eranbe@mellanox.com \
    --cc=jakub.kicinski@netronome.com \
    --cc=netdev@vger.kernel.org \
    --cc=tariqt@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.