From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1fQIOo-00039N-Sq for mharc-grub-devel@gnu.org; Tue, 05 Jun 2018 16:17:46 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58059) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fQIOm-00039C-5c for grub-devel@gnu.org; Tue, 05 Jun 2018 16:17:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fQIOi-0000Nw-Vm for grub-devel@gnu.org; Tue, 05 Jun 2018 16:17:44 -0400 Received: from genode.genode-labs.com ([94.130.141.228]:43058) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fQIOi-0000Nb-Nx for grub-devel@gnu.org; Tue, 05 Jun 2018 16:17:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=genode-labs.com; s=2018-03; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:To:Cc:From:References:Subject:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=btqs5YLVZhu6gVkdV5j25LWy9B+Dk2GpVSQ17MefOeI=; b=cekL8Ox4E78MWHtYMzrmuSLoXE WEXmoNVcQg4oTYw3vzTkbTpD7Lh/hWTRaNBIFF3ZgSGwDNJL/rcbKj3J5EYprC10+r48IBJ2vw/sT rbotN734lApxzBRzQ9EhGrT69/Y2TiqIwdnTJcgTqdFPocfqMLXbkaKu4VwgsBvt1r824rxbMfsPO 0HJVXRY0m7JlER3QSSte8CzA9meUZVRveVIlNyzOmlwDiJzhlX9o9WzwXxLLcJiz1PxD1mf/VOX3o rozs9tVQHw79vc7C7agBlJ4sLLPOBZeCI/lSAYpYMzEf1ycWQTb1rc3Qxo17HMFmepgteWC3DOM6U lp+JtAgg==; Received: by genode.genode-labs.com (Exim 4.89) with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (envelope-from ) id 1fQI7L-00079j-U2 ; Tue, 05 Jun 2018 21:59:44 +0200 Subject: Re: [PATCH] mbi: use per segment a separate relocator chunk References: <20180515134229.GC16845@router-fw-old.local.net-space.pl> From: Alexander Boettcher Openpgp: preference=signencrypt Autocrypt: addr=alexander.boettcher@genode-labs.com; prefer-encrypt=mutual; keydata= xsDiBENh6oYRBACj1vmFXEmokJh0q1apXxDLKZsoE+EpKPrTwd+3Zn9eddUPHLNSbt49g7ia 9xp0oayb2JF0ePr9ye+NbKJKfOf96D7+kYS7S7DvWdKhaTCtCspClkTkhB+BYVWfxxjVOUnO rU0I7r7HpRi3q26yDVTz0jgAOVwF9adnKY04JTB60wCg7BUxM4GpebidTtLrtb8lx2kq8gUD +wWw32D/lbCmh2wpCBMkVeX8Le3C7mVB8U4vNG1svZ/tEkn4zqJDFktRxeHt7ySk2LG4yXC2 yd7SZsKCX3D3qMEm1N65LTjrEDDWTWdovk7Fix/g7W2fP6dEIYu50h6Rr/kIf89aZg8Y/PQG pAN4sfM+dt03ESxXyAua4hBN6asRA/9D4/zjRQHYCl/DK0v0ae4QOdnHFKHphUlWLutpg9QL mM3Gfm+L1i7vmwEy/g/ttJhJCtyXSlViA2QSgPsryyLQXfPj5ibC92i4GlVbdXPsjEMlp88v axcPbopgt2+rEfefrSywIkjF6itPOqYWVrtgCu3wcp1Kcm0ifwAOYEzDBM07QWxleGFuZGVy IEJvZXR0Y2hlciA8YWxleGFuZGVyLmJvZXR0Y2hlckBpbmYudHUtZHJlc2Rlbi5kZT7CXgQT EQIAHgIbAwYLCQgHAwIDFQIDAxYCAQIeAQIXgAUCT8xr4QAKCRCqNEr0pjMls07PAJ49S5VB Hzv30U4bByy/XNuSUGqtUACfTA84wXAxgmNmRAztgiPlIkhbgSLOw00EQ2HrHhAQAMnzwK9t et1ytoSVNucqlcXF+Fo0+vReUD33pNO0cO5ALZw7YdSNi6EMqdDwy0+Y2KnmXXIMHmNCwKw/ 7qhqwE0OFvKh06BfJAKQ+YuBHK1rL7U+61OT9YnCi0468GSXKkYosN194DYMomcfQO7Fe8KN ysasYHyCO07rg+E85Bs62H47EGOejLzSwWIKfMFgCLErocbNnEmxYQ1XUhys/5CbbzMjkQ79 6p7AFJUymuRGuibjRKY3UgJz46NMVIdcVVlVfL8cbArHBrNJqow1Ek/ZeRitCQKKxtOzGzjY o7wAlUfm0u6R04/fsMT7mLlZzsVBlf0Rg0Nun0JThev9nxjZgJvauQacFbcbvo10CwAXj90h 6R0zxay0qI6P7wzcaz7WtRCcsWcDkQmSfwbEqRIwQAj9iVZlvBsGhMbHxohBxCx2LYuIURQs miFHIAzXs0+xEl8IxQKJsCwwY/ezZnxl8BTDXfTZ/lsAFH5Ki9RzRFRthjbcFwgnaYJ7R/Dd OmY+MOcyMB5rj5rP4i68NsOScPG4lAf8eFumtiv3F6eg3S84GePPqU+KgUt4gYUkZN5H+BlA NaR0DoS+lstY/d1HB2ZgqrfP0HuemL+bw9rTZuTAAVwhjJ6IOWLxgA0JafSdgUAm9skQIhhF VAx5oeaUTBBjTg/W1GmfG0KVd91jAAMGD/kByNzEP+QoZLFJ2i66skk9Q0J6zdXadqCox2om ydwTnYx7EFBka2BNzBVwnweqO6ZZTTyrIYQ6Ppx2H4X2YvmMIb3G3zmunkueglSWgwSVymub h3cfLEQnjoh/6Tu0j5Kv4x+5VCjx9L+VeYTs8alqqCQhxNg2jCctkUJcAAL01Pw2o0bjS08d +eoWQ/6BU10NkKeJr0c3yNzTpTHKsQlov+k16yEvaAML6Zp9ODTt6rkJ/Va0KdvFpxAK4ZUT uNTA/p0JKHQ0BqhhRR27Dccwl0km6bR2e8R68012aGcZM5k4xC9k7ARdItv95RKwgbd0veYZ FRs5bPqJqU1sGEz03xy6yNMUUT2QAYUt5zxdPgMu7vmEcTrawAnNfpiStRETPCOwN5hKTQVm 1OTSKBhT4aZ7OgmyAfVY2lK9zrsz5v1Wu3aet1fIuvcfjdwv0fTkSTzlX/2pMNDZ7bCmGFSg Vjp1QnT7pkVqwhVrrsh7HBn133v3Ll2Oe4BmRz3MHKUTC2Vhz9p9+PAXjj23EOHIZrtz7AEF cuGb6m8+DtHF5yVDKhMT0k8ZFbwSYRzktX0zzwQQ2jG/vpxPJL7hQP++XaUS/nbKrvlZJzwk KW4gqLGKy8RwDCHmeIMeh/GfmIo8Rq3l4x9gWhv4fa8LIv1HlA8zVqZVSAzQ0F2qHE2I3sJJ BBgRAgAJBQJDYeseAhsMAAoJEKo0SvSmMyWzFlkAoNfdUebMy9AS4blEKD7mZEb5EldKAKC5 39vTrz5Hkd3EiFhGX4kig6tL3w== Cc: Daniel Kiper To: The development of GNU GRUB Message-ID: <9e0d0cb1-ac0b-7a3c-4bc3-d248cd47d877@genode-labs.com> Date: Tue, 5 Jun 2018 21:59:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180515134229.GC16845@router-fw-old.local.net-space.pl> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam_score: 0.0 X-Spam_score_int: 0 X-Spam_bar: / X-Spam_report: NO_RELAYS=-0.001,URIBL_BLOCKED=0.001 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 94.130.141.228 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jun 2018 20:17:45 -0000 On 15.05.2018 15:42, Daniel Kiper wrote: > On Mon, May 14, 2018 at 09:02:00PM +0200, Alexander Boettcher wrote: >> grub_relocator_chunk_t ch; >> - grub_uint32_t load_offset, load_size; >> + grub_uint32_t load_offset = 0, load_size; >> int i; >> - void *source; >> + void *source = NULL; > > It seems to me that this change is not needed. > I am thinking about "void *source = NULL;". > The compiler complains if I remove the NULL assignment with: error: ‘source’ may be used uninitialized in this function [-Werror=maybe-uninitialized] grub_memset ((grub_uint8_t *) source + load_offset + phdr(i)->p_filesz, 0, I try to incorporate your further comments and re-send the patch. -- Alexander Boettcher Genode Labs http://www.genode-labs.com - http://www.genode.org Genode Labs GmbH - Amtsgericht Dresden - HRB 28424 - Sitz Dresden Geschäftsführer: Dr.-Ing. Norman Feske, Christian Helmuth