From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com ([134.134.136.100]:33048 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387973AbfETQHE (ORCPT ); Mon, 20 May 2019 12:07:04 -0400 Reply-To: thor.thayer@linux.intel.com Subject: Re: [PATCH 1/3] ARM: dts: cyclone5: Add stmmac ptp_ref clock References: <20190515162058.32368-1-dalon.westergreen@linux.intel.com> From: Thor Thayer Message-ID: <9e10b403-d45d-2d07-8765-b0e0d029e2e7@linux.intel.com> Date: Mon, 20 May 2019 11:09:12 -0500 MIME-Version: 1.0 In-Reply-To: <20190515162058.32368-1-dalon.westergreen@linux.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: devicetree-owner@vger.kernel.org To: Dalon Westergreen , dinguyen@kernel.org, devicetree@vger.kernel.org List-ID: On 5/15/19 11:20 AM, Dalon Westergreen wrote: > Add the ptp_ref clock to gmac0 / gmac1 specifying the default clk > of osc1. The stmmac driver defaults the ptp_ref clock to the main > stmmac clock if ptp_ref is not provided. This is inappropriate for > the Cyclone5 or Arria5 devices. > > Signed-off-by: Dalon Westergreen > --- > arch/arm/boot/dts/socfpga.dtsi | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi > index 28ecb4bdf5aa..c1c9d6a2bb91 100644 > --- a/arch/arm/boot/dts/socfpga.dtsi > +++ b/arch/arm/boot/dts/socfpga.dtsi > @@ -557,8 +557,8 @@ > interrupts = <0 115 4>; > interrupt-names = "macirq"; > mac-address = [00 00 00 00 00 00];/* Filled in by U-Boot */ > - clocks = <&emac_0_clk>; > - clock-names = "stmmaceth"; > + clocks = <&emac_0_clk>, <&osc1>; > + clock-names = "stmmaceth", "ptp_ref"; > resets = <&rst EMAC0_RESET>; > reset-names = "stmmaceth"; > snps,multicast-filter-bins = <256>; > @@ -575,8 +575,8 @@ > interrupts = <0 120 4>; > interrupt-names = "macirq"; > mac-address = [00 00 00 00 00 00];/* Filled in by U-Boot */ > - clocks = <&emac_1_clk>; > - clock-names = "stmmaceth"; > + clocks = <&emac_1_clk>, <&osc1>; > + clock-names = "stmmaceth", "ptp_ref"; > resets = <&rst EMAC1_RESET>; > reset-names = "stmmaceth"; > snps,multicast-filter-bins = <256>; > Reviewed-by: Thor Thayer