From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67D41C433EF for ; Mon, 11 Jul 2022 12:02:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231186AbiGKMCS (ORCPT ); Mon, 11 Jul 2022 08:02:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56022 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231138AbiGKMCO (ORCPT ); Mon, 11 Jul 2022 08:02:14 -0400 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F7A83C14E for ; Mon, 11 Jul 2022 05:02:06 -0700 (PDT) Received: by mail-lf1-x131.google.com with SMTP id r9so278244lfp.10 for ; Mon, 11 Jul 2022 05:02:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=QVqxg0dp3wEYOZpL9v9ilM2FSVRUoonO6i41pxiTzI8=; b=hFlw6gC8Q7phUNCtcoZ+mnhDG3DT2Icr9ctPW9MH8XjMtD29CbFUV/+EqObdE85V3+ 84TFY8D/cPCLDmxM+Yjze8C5OqepE/+Jks3xTPjY8bvxWBK6PIcNzNssTM1CFhs9LtEk jwd7bOEnaXnycO0NG4YXMJQxd0/Iydvchv52ywJ4QVSlfLFKenAy31lHszz6+D8Fiwtu 0PxvFQZMrFg2Ig2iOO7St7bU6PIywmAR7oIdOA8wSFtGZNMLW2Wx+fOS0U4T/Sc9xrDA yiqr7V7dxkxre7p2jDbyB8gkHTM4L7MGLh1bGnShicdj+usImIZHWFNsR4CLEWZT0lgl /CIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=QVqxg0dp3wEYOZpL9v9ilM2FSVRUoonO6i41pxiTzI8=; b=jedf3ODMkHoFYPh48eEcw2slJkB2pkLEpPPC1Xsdl/L6DdDolfy6zKz9xvVp/p2jx9 BW7c/+d0lMjLzSqlOiQbA/FH+X0vmWlLFiAQmbI4kym3tBpWKbhSN9Nx74lgKDthKLiw HzqmtWaeo+CNG+zQQYRVXCdsRhq+IpE2Ka6ZZj2k6Zze6U6GmuV5gPtswUaLEZ7p2a7W JSi2foPEumaFZUnhAZIviH5EQMki17ie5bZIgZXcOybJ+LkUI9XrLctnPEdNJjn8vZNa k1gxcuLc+G1TdLOVF8vj3+iYY/0yhjG8evh71bHNbiYpoJG76ll6h/fCi/+XPM7cc4O6 dKUQ== X-Gm-Message-State: AJIora+ZueSL/YhJHweGykyuBnxM6D+zFGNej75YujfHq5cygPS6tLfs RSHPqWB4EJfFYbY/vtT4j1IGUw== X-Google-Smtp-Source: AGRyM1tPFsxY/xB1ICxsLpx4b0d9lJislbMty935ePwpSxLaNm08XHOXHHUPjHR/WWsfjwVIeBOlQg== X-Received: by 2002:a05:6512:398c:b0:488:f524:b7e9 with SMTP id j12-20020a056512398c00b00488f524b7e9mr10868068lfu.259.1657540924386; Mon, 11 Jul 2022 05:02:04 -0700 (PDT) Received: from [10.0.0.8] (fwa5cab-55.bb.online.no. [88.92.171.55]) by smtp.gmail.com with ESMTPSA id d28-20020ac25edc000000b00489c719b809sm1492196lfq.284.2022.07.11.05.02.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Jul 2022 05:02:03 -0700 (PDT) Message-ID: <9e1ff864-3952-6442-13db-a3d8e18f86c3@linaro.org> Date: Mon, 11 Jul 2022 14:02:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 4/6] clk: qcom: apss-ipq6018: add MODULE_ALIAS Content-Language: en-US To: Robert Marko Cc: Bjorn Andersson , Andy Gross , Konrad Dybcio , Michael Turquette , Stephen Boyd , Rob Herring , krzysztof.kozlowski+dt@linaro.org, sivaprak@codeaurora.org, linux-arm-msm , linux-clk@vger.kernel.org, Devicetree List , open list References: <20220711104719.40939-1-robimarko@gmail.com> <20220711104719.40939-4-robimarko@gmail.com> <4de38d90-0020-c2db-b283-319b4a0e2ce5@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 11/07/2022 13:46, Robert Marko wrote: > On Mon, 11 Jul 2022 at 13:05, Krzysztof Kozlowski > wrote: >> >> On 11/07/2022 12:47, Robert Marko wrote: >>> Add MODULE_ALIAS so that driver will be autoloaded if built as a module. >>> >>> Signed-off-by: Robert Marko >>> --- >>> drivers/clk/qcom/apss-ipq6018.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/drivers/clk/qcom/apss-ipq6018.c b/drivers/clk/qcom/apss-ipq6018.c >>> index f2f502e2d5a4..963c69f2c0c2 100644 >>> --- a/drivers/clk/qcom/apss-ipq6018.c >>> +++ b/drivers/clk/qcom/apss-ipq6018.c >>> @@ -101,5 +101,6 @@ static struct platform_driver apss_ipq6018_driver = { >>> >>> module_platform_driver(apss_ipq6018_driver); >>> >>> +MODULE_ALIAS("platform:qcom,apss-ipq6018-clk"); >> >> That's not correct alias (no commas) and usually alias is not needed at >> all. If you need one, please explain why it is needed. Module >> autoloading works fine without aliases... > > Hi Krzysztof, > alias is required here as the driver does not use a DT compatible but > is registered > by the APCS driver, if built as a module, it won't get autoloaded > without an alias. Instead you need device ID table. Aliases are not a workaround for missing core driver elements. > > I can only fix up the driver name here and in APCS first to have an > alias without commas. I see that the comma is used in driver name, so this is an independent issue. Maybe change it to '-' in separate commit? Best regards, Krzysztof