From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ale.deltatee.com (ale.deltatee.com [207.54.116.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E9381203B85B8 for ; Tue, 22 May 2018 14:28:35 -0700 (PDT) References: <20180423233046.21476-1-logang@deltatee.com> <20180423233046.21476-7-logang@deltatee.com> <59b7762e-6d38-7746-20f3-22fd762ecfe7@infradead.org> From: Logan Gunthorpe Message-ID: <9e20024d-8b32-61ff-4b9a-c9392082987f@deltatee.com> Date: Tue, 22 May 2018 15:28:19 -0600 MIME-Version: 1.0 In-Reply-To: <59b7762e-6d38-7746-20f3-22fd762ecfe7@infradead.org> Content-Language: en-US Subject: Re: [PATCH v4 06/14] PCI/P2PDMA: Add P2P DMA driver writer's documentation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Randy Dunlap , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-nvme@lists.infradead.org, linux-rdma@vger.kernel.org, linux-nvdimm@lists.01.org, linux-block@vger.kernel.org Cc: Jens Axboe , =?UTF-8?Q?Christian_K=c3=b6nig?= , Benjamin Herrenschmidt , Jonathan Corbet , Alex Williamson , Keith Busch , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Jason Gunthorpe , Bjorn Helgaas , Max Gurtovoy , Christoph Hellwig List-ID: Thanks for the review Randy! I'll make the changes for the next time we post the series. On 22/05/18 03:24 PM, Randy Dunlap wrote: >> +The first task an orchestrator driver must do is compile a list of >> +all client drivers that will be involved in a given transaction. For >> +example, the NVMe Target driver creates a list including all NVMe drives > ^^^^^^ > or drivers ? > Could be either, I guess, but the previous sentence says "compile a list of drivers." I did mean "drives". But perhaps "devices" would be more clear. A list of all NVMe drivers doesn't make much sense as I'm pretty sure there is only one NVMe driver. Logan _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: To: Randy Dunlap , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-nvme@lists.infradead.org, linux-rdma@vger.kernel.org, linux-nvdimm@lists.01.org, linux-block@vger.kernel.org Cc: Stephen Bates , Christoph Hellwig , Jens Axboe , Keith Busch , Sagi Grimberg , Bjorn Helgaas , Jason Gunthorpe , Max Gurtovoy , Dan Williams , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Benjamin Herrenschmidt , Alex Williamson , =?UTF-8?Q?Christian_K=c3=b6nig?= , Jonathan Corbet References: <20180423233046.21476-1-logang@deltatee.com> <20180423233046.21476-7-logang@deltatee.com> <59b7762e-6d38-7746-20f3-22fd762ecfe7@infradead.org> From: Logan Gunthorpe Message-ID: <9e20024d-8b32-61ff-4b9a-c9392082987f@deltatee.com> Date: Tue, 22 May 2018 15:28:19 -0600 MIME-Version: 1.0 In-Reply-To: <59b7762e-6d38-7746-20f3-22fd762ecfe7@infradead.org> Content-Type: text/plain; charset=utf-8 Subject: Re: [PATCH v4 06/14] PCI/P2PDMA: Add P2P DMA driver writer's documentation List-ID: Thanks for the review Randy! I'll make the changes for the next time we post the series. On 22/05/18 03:24 PM, Randy Dunlap wrote: >> +The first task an orchestrator driver must do is compile a list of >> +all client drivers that will be involved in a given transaction. For >> +example, the NVMe Target driver creates a list including all NVMe drives > ^^^^^^ > or drivers ? > Could be either, I guess, but the previous sentence says "compile a list of drivers." I did mean "drives". But perhaps "devices" would be more clear. A list of all NVMe drivers doesn't make much sense as I'm pretty sure there is only one NVMe driver. Logan From mboxrd@z Thu Jan 1 00:00:00 1970 From: Logan Gunthorpe Subject: Re: [PATCH v4 06/14] PCI/P2PDMA: Add P2P DMA driver writer's documentation Date: Tue, 22 May 2018 15:28:19 -0600 Message-ID: <9e20024d-8b32-61ff-4b9a-c9392082987f@deltatee.com> References: <20180423233046.21476-1-logang@deltatee.com> <20180423233046.21476-7-logang@deltatee.com> <59b7762e-6d38-7746-20f3-22fd762ecfe7@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <59b7762e-6d38-7746-20f3-22fd762ecfe7-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org Sender: "Linux-nvdimm" To: Randy Dunlap , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org, linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: Jens Axboe , =?UTF-8?Q?Christian_K=c3=b6nig?= , Benjamin Herrenschmidt , Jonathan Corbet , Alex Williamson , Keith Busch , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Jason Gunthorpe , Bjorn Helgaas , Max Gurtovoy , Christoph Hellwig List-Id: linux-rdma@vger.kernel.org Thanks for the review Randy! I'll make the changes for the next time we post the series. On 22/05/18 03:24 PM, Randy Dunlap wrote: >> +The first task an orchestrator driver must do is compile a list of >> +all client drivers that will be involved in a given transaction. For >> +example, the NVMe Target driver creates a list including all NVMe drives > ^^^^^^ > or drivers ? > Could be either, I guess, but the previous sentence says "compile a list of drivers." I did mean "drives". But perhaps "devices" would be more clear. A list of all NVMe drivers doesn't make much sense as I'm pretty sure there is only one NVMe driver. Logan From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: To: Randy Dunlap , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-nvme@lists.infradead.org, linux-rdma@vger.kernel.org, linux-nvdimm@lists.01.org, linux-block@vger.kernel.org References: <20180423233046.21476-1-logang@deltatee.com> <20180423233046.21476-7-logang@deltatee.com> <59b7762e-6d38-7746-20f3-22fd762ecfe7@infradead.org> From: Logan Gunthorpe Message-ID: <9e20024d-8b32-61ff-4b9a-c9392082987f@deltatee.com> Date: Tue, 22 May 2018 15:28:19 -0600 MIME-Version: 1.0 In-Reply-To: <59b7762e-6d38-7746-20f3-22fd762ecfe7@infradead.org> Subject: Re: [PATCH v4 06/14] PCI/P2PDMA: Add P2P DMA driver writer's documentation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jens Axboe , Sagi Grimberg , =?UTF-8?Q?Christian_K=c3=b6nig?= , Benjamin Herrenschmidt , Jonathan Corbet , Alex Williamson , Stephen Bates , Keith Busch , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Jason Gunthorpe , Bjorn Helgaas , Max Gurtovoy , Dan Williams , Christoph Hellwig Content-Type: text/plain; charset="us-ascii" Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+bjorn=helgaas.com@lists.infradead.org List-ID: Thanks for the review Randy! I'll make the changes for the next time we post the series. On 22/05/18 03:24 PM, Randy Dunlap wrote: >> +The first task an orchestrator driver must do is compile a list of >> +all client drivers that will be involved in a given transaction. For >> +example, the NVMe Target driver creates a list including all NVMe drives > ^^^^^^ > or drivers ? > Could be either, I guess, but the previous sentence says "compile a list of drivers." I did mean "drives". But perhaps "devices" would be more clear. A list of all NVMe drivers doesn't make much sense as I'm pretty sure there is only one NVMe driver. Logan _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme From mboxrd@z Thu Jan 1 00:00:00 1970 From: logang@deltatee.com (Logan Gunthorpe) Date: Tue, 22 May 2018 15:28:19 -0600 Subject: [PATCH v4 06/14] PCI/P2PDMA: Add P2P DMA driver writer's documentation In-Reply-To: <59b7762e-6d38-7746-20f3-22fd762ecfe7@infradead.org> References: <20180423233046.21476-1-logang@deltatee.com> <20180423233046.21476-7-logang@deltatee.com> <59b7762e-6d38-7746-20f3-22fd762ecfe7@infradead.org> Message-ID: <9e20024d-8b32-61ff-4b9a-c9392082987f@deltatee.com> Thanks for the review Randy! I'll make the changes for the next time we post the series. On 22/05/18 03:24 PM, Randy Dunlap wrote: >> +The first task an orchestrator driver must do is compile a list of >> +all client drivers that will be involved in a given transaction. For >> +example, the NVMe Target driver creates a list including all NVMe drives > ^^^^^^ > or drivers ? > Could be either, I guess, but the previous sentence says "compile a list of drivers." I did mean "drives". But perhaps "devices" would be more clear. A list of all NVMe drivers doesn't make much sense as I'm pretty sure there is only one NVMe driver. Logan