All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hannes Reinecke <hare@suse.de>
To: James Smart <jsmart2021@gmail.com>, linux-scsi@vger.kernel.org
Cc: Dick Kennedy <dick.kennedy@broadcom.com>
Subject: Re: [PATCH 5/9] lpfc: Change default queue allocation for reduced memory consumption
Date: Thu, 7 May 2020 11:49:21 +0200	[thread overview]
Message-ID: <9e20e9e8-5437-d57c-7242-7b39c455d1b1@suse.de> (raw)
In-Reply-To: <20200501214310.91713-6-jsmart2021@gmail.com>

On 5/1/20 11:43 PM, James Smart wrote:
> By default, the driver attempts to allocate a hdwq per logical cpu in
> order to provide good cpu affinity. Some systems have extremely high cpu
> counts and this can significantly raise memory consumption.
> 
> In testing on x86 platforms (non-AMD) it is found that sharing of a hdwq
> by a physical cpu and it's HT cpu can occur with little performance
> degredation. By sharing the hdwq count can be halved, significantly
> reducing the memory overhead.
> 
> Change the default behavior of the driver on non-AMD x86 platforms to
> share a hdwq by the cpu and its HT cpu.
> 
> Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com>
> Signed-off-by: James Smart <jsmart2021@gmail.com>
> ---
>   drivers/scsi/lpfc/lpfc.h      |  23 ++++++--
>   drivers/scsi/lpfc/lpfc_attr.c | 106 +++++++++++++++++++++++++++-------
>   drivers/scsi/lpfc/lpfc_init.c |  82 +++++++++++---------------
>   drivers/scsi/lpfc/lpfc_sli4.h |   2 +-
>   4 files changed, 137 insertions(+), 76 deletions(-)
> I do assume that you've checked that this matches with blk-mq queue 
layout, right?

Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke            Teamlead Storage & Networking
hare@suse.de                               +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer

  reply	other threads:[~2020-05-07  9:49 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-01 21:43 [PATCH 0/9] lpfc: Update lpfc to revision 12.8.0.1 James Smart
2020-05-01 21:43 ` [PATCH 1/9] lpfc: Synchronize NVME transport and lpfc driver devloss_tmo James Smart
2020-05-03 14:42   ` James Smart
2020-05-07  9:11   ` Hannes Reinecke
2020-05-01 21:43 ` [PATCH 2/9] lpfc: Maintain atomic consistency of queue_claimed flag James Smart
2020-05-07  9:12   ` Hannes Reinecke
2020-05-01 21:43 ` [PATCH 3/9] lpfc: Remove re-binding of nvme rport during registration James Smart
2020-05-07  9:13   ` Hannes Reinecke
2020-05-01 21:43 ` [PATCH 4/9] lpfc: Fix negation of else clause in lpfc_prep_node_fc4type James Smart
2020-05-07  9:14   ` Hannes Reinecke
2020-05-01 21:43 ` [PATCH 5/9] lpfc: Change default queue allocation for reduced memory consumption James Smart
2020-05-07  9:49   ` Hannes Reinecke [this message]
2020-05-01 21:43 ` [PATCH 6/9] lpfc: Remove unnecessary lockdep_assert_held calls James Smart
2020-05-07  9:50   ` Hannes Reinecke
2020-05-01 21:43 ` [PATCH 7/9] lpfc: Fix noderef and address space warnings James Smart
2020-05-07  9:50   ` Hannes Reinecke
2020-05-01 21:43 ` [PATCH 8/9] lpfc: Fix MDS Diagnostic Enablement definition James Smart
2020-05-07  9:50   ` Hannes Reinecke
2020-05-01 21:43 ` [PATCH 9/9] lpfc: Update lpfc version to 12.8.0.1 James Smart
2020-05-07  9:51   ` Hannes Reinecke
2020-05-08  2:54 ` [PATCH 0/9] lpfc: Update lpfc to revision 12.8.0.1 Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9e20e9e8-5437-d57c-7242-7b39c455d1b1@suse.de \
    --to=hare@suse.de \
    --cc=dick.kennedy@broadcom.com \
    --cc=jsmart2021@gmail.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.