From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail1.windriver.com (mail1.windriver.com [147.11.146.13]) by mail.openembedded.org (Postfix) with ESMTP id 87C046FEFE for ; Tue, 22 Nov 2016 16:55:38 +0000 (UTC) Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail1.windriver.com (8.15.2/8.15.1) with ESMTPS id uAMGtaMT017501 (version=TLSv1 cipher=AES128-SHA bits=128 verify=FAIL); Tue, 22 Nov 2016 08:55:37 -0800 (PST) Received: from [128.224.56.48] (128.224.56.48) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server id 14.3.294.0; Tue, 22 Nov 2016 08:55:35 -0800 To: akuster808 , References: <1656a2c98cd4f8113972d3c86870dc1eaf323760.1479830169.git.bruce.ashfield@windriver.com> From: Bruce Ashfield Message-ID: <9e211241-6674-f0b7-246f-3d91df15dbd0@windriver.com> Date: Tue, 22 Nov 2016 11:55:35 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Cc: openembedded-core@lists.openembedded.org Subject: Re: [PATCH 7/7] kern-tools: error checking and tree generation fixes X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Nov 2016 16:55:38 -0000 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit On 2016-11-22 11:53 AM, akuster808 wrote: > Bruce, > > > On 11/22/2016 07:59 AM, Bruce Ashfield wrote: >> During processing of the kernel meta data the kern tools were >> not properly exiting on syntax errors or invalid commands. > > Does Morty need this? It won't do any harm, if you also pick up my kernel SRCREV updates, and will help find any issues that may be lurking. We had a bug in the kernel meta-data where some fragments weren't being picked up due to a syntax error. It now traps and points you at the issue. Bruce > -Armin >> >> Noticing and debugging these issues wasn't trivial. To make this >> easier, we now trap the error and dump the offending meta-data >> for the user to see. >> >> There was also an issue with creating branches during tree >> generation, which is resolved by always switching to the >> active branch. >> >> The following are the commit logs of the changes themselves: >> >> [ >> commit b36f6f9a5695f2084b83823393e13ca42284bed9 >> Author: Paul Gortmaker >> Date: Sat Oct 22 17:23:25 2016 -0400 >> >> kgit-scc: dont mention meta-repo in help ; it doesnt exist >> >> Signed-off-by: Paul Gortmaker >> Signed-off-by: Bruce Ashfield >> >> commit 08463d684c1952e74c25344cddace4c3f24c739d >> Author: Bruce Ashfield >> Date: Mon Oct 31 14:30:12 2016 -0400 >> >> scc: exit on error >> >> If there is an error in the processing of the input files, scc >> should exit and inform the user. >> >> scc is executed on a combined/preprocessed file and as a result >> it doesn't have the granularity to see each input file >> individually. >> >> Rather than moving preprocessing into scc (from spp), we can trap >> the line number of the error and dump context around the line. >> This gives the user a pointer to the input file and the specific >> line that caused the problem. >> >> Signed-off-by: Bruce Ashfield >> >> commit bf99953e8ac14cee653e559f2d4a6022c847a182 >> Author: Bruce Ashfield >> Date: Fri Oct 28 21:23:27 2016 -0400 >> >> kgit-meta: always checkout branches on branch commands >> >> During a tree generation we must always make the branch active >> when >> we see any kind of branch command. This ensures that any >> subsequent >> patches are applied in the proper context. >> >> Previously, only branch creation was changing the active >> branch, and >> this mean that tree generation was not determinstic and relied >> on the order of processing to generate a correct tree. >> >> Signed-off-by: Bruce Ashfield >> ] >> >> Signed-off-by: Bruce Ashfield >> --- >> meta/recipes-kernel/kern-tools/kern-tools-native_git.bb | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/meta/recipes-kernel/kern-tools/kern-tools-native_git.bb >> b/meta/recipes-kernel/kern-tools/kern-tools-native_git.bb >> index d8041ddd38c5..88b1aee729c9 100644 >> --- a/meta/recipes-kernel/kern-tools/kern-tools-native_git.bb >> +++ b/meta/recipes-kernel/kern-tools/kern-tools-native_git.bb >> @@ -4,7 +4,7 @@ LIC_FILES_CHKSUM = >> "file://git/tools/kgit;beginline=5;endline=9;md5=a6c2fa8aef1b >> DEPENDS = "git-native" >> -SRCREV = "9a3995ee8daabf37e92e1b51b133cf8582d85809" >> +SRCREV = "b36f6f9a5695f2084b83823393e13ca42284bed9" >> PR = "r12" >> PV = "0.2+git${SRCPV}" >> >