From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH i-g-t] benchmarks/gem_wsim: Heap allocate VLA structs Date: Fri, 24 May 2019 09:44:12 +0100 Message-ID: <9e387397-0541-7197-707e-2c9cca3d0d45@linux.intel.com> References: <20190524072551.24429-1-chris@chris-wilson.co.uk> <155868683254.28319.251717788186809854@skylake-alporthouse-com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <155868683254.28319.251717788186809854@skylake-alporthouse-com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: igt-dev@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDI0LzA1LzIwMTkgMDk6MzMsIENocmlzIFdpbHNvbiB3cm90ZToKPiBRdW90aW5nIFR2cnRr byBVcnN1bGluICgyMDE5LTA1LTI0IDA5OjIwOjQ3KQo+Pgo+PiBPbiAyNC8wNS8yMDE5IDA4OjI1 LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4+PiBBcHBhcmVudGx5IFZMQSBzdHJ1Y3RzIChlLmcuIHN0 cnVjdCB7IGludCBhcnJheVtjb3VudF0gfSkgaXMgYSBnY2MKPj4+IGV4dGVuc2lvbiB0aGF0IGNs YW5nIHJlZnVzZXMgdG8gc3VwcG9ydCBhcyBoYW5kbGluZyBtZW1vcnkgbGF5b3V0IGlzIHRvbwo+ Pj4gZGlmZmljdWx0IGZvciBpdC4KPj4+Cj4+PiBNb3ZlIHRoZSBvbi1zdGFjayBWTEEgdG8gdGhl IGhlYXAuCj4+Pgo+Pj4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13 aWxzb24uY28udWs+Cj4+PiBDYzogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVs LmNvbT4KPj4+IC0tLQo+Pj4gICAgYmVuY2htYXJrcy9nZW1fd3NpbS5jIHwgMTQ2ICsrKysrKysr KysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLQo+Pj4gICAgMSBmaWxlIGNoYW5nZWQs IDk1IGluc2VydGlvbnMoKyksIDUxIGRlbGV0aW9ucygtKQo+Pj4KPj4+IGRpZmYgLS1naXQgYS9i ZW5jaG1hcmtzL2dlbV93c2ltLmMgYi9iZW5jaG1hcmtzL2dlbV93c2ltLmMKPj4+IGluZGV4IGUy ZmZiOTNhOS4uMGEwMDMyYmZmIDEwMDY0NAo+Pj4gLS0tIGEvYmVuY2htYXJrcy9nZW1fd3NpbS5j Cj4+PiArKysgYi9iZW5jaG1hcmtzL2dlbV93c2ltLmMKPj4+IEBAIC0xNDQxLDYgKzE0NDEsNDgg QEAgc2V0X2N0eF9zc2V1KHN0cnVjdCBjdHggKmN0eCwgdWludDY0X3Qgc2xpY2VfbWFzaykKPj4+ ICAgICAgICByZXR1cm4gc2xpY2VfbWFzazsKPj4+ICAgIH0KPj4+ICAgIAo+Pj4gK3N0YXRpYyBz aXplX3Qgc2l6ZW9mX2xvYWRfYmFsYW5jZShpbnQgY291bnQpCj4+PiArewo+Pj4gKyAgICAgc3Ry dWN0IGk5MTVfY29udGV4dF9lbmdpbmVzX2xvYWRfYmFsYW5jZSAqcHRyOwo+Pj4gKwo+Pj4gKyAg ICAgYXNzZXJ0KHNpemVvZihwdHItPmVuZ2luZXNbY291bnRdKSA9PSBjb3VudCAqIHNpemVvZihw dHItPmVuZ2luZXNbMF0pKTsKPj4KPj4gVGhpcyBzZWVtcyB3cm9uZyAtIGlzIGJvdW5kIHRvIHRy aWdnZXIuCj4gCj4gV2h5IGRvZXMgaXQgc2VlbSB3cm9uZz8gVGhhdCdzIHRoZSBjYWxjdWxhdGlv biB1c2VkIHByZXZpb3VzbHksIGFuZCB0aGUKPiBwdHItPmVuZ2luZXNbXSB3YXMgbWVhbnQgdG8g YmUgcGFja2VkIGluIG9yZGVyIGZvcgo+IHNpemVvZihwdHItPmVuZ2luZXNbY291bnRdKSA9PSBj b3VudCAqIHNpemVvZihwdHItPmVuZ2luZXNbMF0pLiBBbnl3YXksCj4gSSB0aHJldyBpdCBpbiB0 aGVyZSB0byBjaGVjayBpZiB0aGUgY2FsY3VsYXRpb24gd2FzIHNhbmUuCgpCZWNhdXNlIHNpemVv ZihwdHItPmVuZ2luZXNbMF0pID09IHNpemVvZihwdHItPmVuZ2luZXNbTl0pLCBzaW5jZSB0aGUg CmNvZGUgaXMgbm90IGRlY2xhcmluZyBOIGJpZyBhcnJheSwganVzdCByZWZlcmVuY2luZyB0aGUg ZWxlbWVudCBOLiBTbyAKZm9yIG1vcmUgdGhhbiBvbmUgZW5naW5lIEkgZXhwZWN0IGl0IGV4cGxv ZGVzLiBVbmxlc3MgSSBhbSB3YXkgd3JvbmcuLiBJIApndWVzcyBzb21lb25lIG5lZWRzIHRvIHJ1 biBpdC4uIDopCgo+Pj4gKyAgICAgcmV0dXJuIHNpemVvZigqcHRyKSArIHNpemVvZihwdHItPmVu Z2luZXNbY291bnRdKTsKPj4KPj4gU28gc2l6ZSBvZiBvZiBlbmdpbmUgbmVlZHMgdG8gYmUgbXVs dGlwbGllZCBieSBjb3VudC4KPiAKPiAoSnVzdCBub3RlIHRoaXMgaXMgdGhlIHdoYXQgdGhlIGN1 cnJlbnQgVkxBIGV2YWx1YXRlcyB0byA6KQo+IAo+Pj4gK30KPj4+ICsKPj4+ICtzdGF0aWMgc3Ry dWN0IGk5MTVfY29udGV4dF9lbmdpbmVzX2xvYWRfYmFsYW5jZSAqCj4+PiArYWxsb2NfbG9hZF9i YWxhbmNlKGludCBjb3VudCkKPj4+ICt7Cj4+PiArICAgICByZXR1cm4gY2FsbG9jKDEsIHNpemVv Zl9sb2FkX2JhbGFuY2UoY291bnQpKTsKPj4KPj4gSG93IGFib3V0IGFsbG9jYSBzbyBjbGVhbnVw IGlzIHNpbXBsZXI/IE9yIGlzIGFsbG9jYSBhbHNvIG9uIHRoZQo+PiB1bnBvcHVsYXIgbGlzdD8K PiAKPiBJIGRvbid0IG1pbmQuIFdvdWxkIHNoYXZlIGEgZmV3IGxpbmVzIGluZGVlZCwgYnV0IHdl IG5lZWQgdGhlIG1lbXNldHMKPiBiYWNrLiAjZGVmaW5lIGFsbG9jYTAoKT8KCkFuZCBhIGhlbHBl ciBtYWNybyB0byBnZW5lcmljYWxseSBkZWFsIHdpdGggc3RydWN0IGhlYWRlciArIGVuZ2luZXMg CmFycmF5IHNvIGl0IGRvZXNuJ3QgbmVlZCB0byBiZSByZXBlYXRlZCB0aHJlZSB0aW1lcy4gWWFk YXlhZGEgdG9vIG11Y2ggCndvcmsuLiA6KSAuLi4KCj4+IE9yIHBvc3NpYmx5IHdoYXQgU2ltb24g c3VnZ2VzdGVkLCBqdXN0IGEgbGFyZ2UgdGVtcG9yYXJ5IHN0YWNrIGFycmF5cwo+PiB3b3VsZCBi ZSBlbm91Z2ggYW5kIGVhc2llc3QgZGlmZi4gSnVzdCB3aXRoIGFuIGFzc2VydCB0aGF0IGl0IGZp dHMuCj4gCj4gSSBkb24ndCB0aGluayB0aGF0IGlzIGFzIGNsZWFuIGZvciB0aGUgbG9uZyB0ZXJt LgoKLi4uIHRoaXMgc2hvdWxkIGJlIGp1c3QgZmluZSBmb3Igbm93IHNvIEknZCB2b3RlIGZvciBp dC4KClJlZ2FyZHMsCgpUdnJ0a28KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v aW50ZWwtZ2Z4