From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C636C4709C for ; Mon, 24 May 2021 16:04:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4D45B613CB for ; Mon, 24 May 2021 16:04:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236503AbhEXQE0 (ORCPT ); Mon, 24 May 2021 12:04:26 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:38125 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235193AbhEXP5q (ORCPT ); Mon, 24 May 2021 11:57:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621871778; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=J8qJxDVQ1kylKNxI/QIRmzuDHoPUvchv3PrsNjGkPtA=; b=RtzUCCI9g79y398UdqB2WHkqvbhD6+CvULNXZJHkXmFaMyvMr857Cmq/Z0PZ9+lME/5HTy nkeBKjzKiZ2g5sHEX5eyEhp3kY9LL2EEAW8TZdKPc/zdVsLchNzFmxT2gKlDlxgqwAH3AV uw9i/wa6rPGL6YfjBwODAcRegJek+mQ= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-553-lUZXS0Y1PAuvtkqGUnSp0Q-1; Mon, 24 May 2021 11:56:16 -0400 X-MC-Unique: lUZXS0Y1PAuvtkqGUnSp0Q-1 Received: by mail-ej1-f72.google.com with SMTP id la2-20020a170906ad82b02903d4bcc8de3bso7738067ejb.4 for ; Mon, 24 May 2021 08:56:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=J8qJxDVQ1kylKNxI/QIRmzuDHoPUvchv3PrsNjGkPtA=; b=RnzVQO/dARn59soWxl9AFMcMGjvWpNgtIR6GM+kS3MFKFtsWTiXfRP4RYGgrSu+T84 R9YJHF9gqG5wA6kkxu629tlpIiTrpA4DUO4ZVE/+pvG0yJEeo1euRDg/GHNzw9jat/7x OhXs1BXFNZ04j0oZyFpLxWimdi6v/YvLkGJOW0CHuLH67wd4Wqq9jfu6bPS6c3ReWPZE bKvyMTqDP3hn8rrp+zz61c8g5mizhfvtqEPopvENfPHpsjg2R9zRiIqX1h1UhYiE/8eg jcsPe8UcaG3VCTxj9cHQwk+r/cJ5ve/PFkiCv9jbbHfeQXaB2cIuL5JFY8Tfzky4VqxT 08qg== X-Gm-Message-State: AOAM532NmHoeXohYHyAGkd9tUUeYRs0Tkkg13RQn4T1I06CzRm3ugAWw sa04SbbevPApm9HnJNjPVO6GuprtvyRsVbGmGreAVrUrtwK/qwwDOYs3k4ErhzV2bUap7Drb9HT Ogr4ou0junpQlyUAZR9Lshan5 X-Received: by 2002:aa7:c9c9:: with SMTP id i9mr26499478edt.17.1621871775634; Mon, 24 May 2021 08:56:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwxqIAdA2twCY/NYuWM5QhkC1u2I0/XA7NDRD7mYc3MYp9cHHNqJGAHpd6kL6COESUVJ4IpJQ== X-Received: by 2002:aa7:c9c9:: with SMTP id i9mr26499455edt.17.1621871775453; Mon, 24 May 2021 08:56:15 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id h9sm9168331ede.93.2021.05.24.08.56.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 May 2021 08:56:14 -0700 (PDT) Subject: Re: [PATCH v3 04/12] KVM: X86: Add a ratio parameter to kvm_scale_tsc() To: Sean Christopherson Cc: Ilias Stamatis , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, mlevitsk@redhat.com, vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com, joro@8bytes.org, zamsden@gmail.com, mtosatti@redhat.com, dwmw@amazon.co.uk References: <20210521102449.21505-1-ilstam@amazon.com> <20210521102449.21505-5-ilstam@amazon.com> From: Paolo Bonzini Message-ID: <9e3ccebe-cd18-ed4f-d362-384de0ebfa4a@redhat.com> Date: Mon, 24 May 2021 17:56:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24/05/21 17:48, Sean Christopherson wrote: > > if (msr_info->host_initiated) { > offset = vcpu->arch.l1_tsc_offset; > ratio = vcpu->arch.l1_tsc_scaling_ratio; > } else { > offset = vcpu->arch.tsc_offset; > ratio = vcpu->arch.tsc_scaling_ratio; > } > msr_info->data = kvm_scale_tsc(vcpu, rdtsc(), ratio) + offset; Looks good, indeed I didn't do this just out of laziness really (and instead got a typo). Paolo