From: David Rhodes <drhodes@opensource.cirrus.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
<broonie@kernel.org>, <robh@kernel.org>,
<ckeepax@opensource.cirrus.com>, <brian.austin@cirrus.com>,
<patches@opensource.cirrus.com>, <alsa-devel@alsa-project.org>,
<david.rhodes@cirrus.com>
Subject: Re: [PATCH v2 1/2] ASoC: cs35l41: CS35L41 Boosted Smart Amplifier
Date: Wed, 30 Jun 2021 16:35:07 -0500 [thread overview]
Message-ID: <9e432f81-9229-57d3-5231-50d6f935d084@opensource.cirrus.com> (raw)
In-Reply-To: <b14da5ca-2b5a-43fc-11bb-7f87c873d3c4@linux.intel.com>
On 6/29/21 6:51 PM, Pierre-Louis Bossart wrote:
>
>> +#ifdef CONFIG_ACPI
>> +static const struct acpi_device_id cs35l41_acpi_match[] = {
>> + { "CSC3541", 0 }, /* Cirrus Logic PCI ID + part ID */
>
> Wrong comment or wrong ID, "CSC" is clearly not a PCI ID?
>
CSC is a PnP ID, not a PCI ID. I will change the comment to reflect this.
Thanks for the review. I will fix the license headers, NULL checks,
includes, dev_crit, and inits in the next revision as well.
next prev parent reply other threads:[~2021-06-30 21:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-29 22:27 [PATCH v2 0/2] Cirrus Logic CS35L41 Amplifier David Rhodes
2021-06-29 22:27 ` [PATCH v2 1/2] ASoC: cs35l41: CS35L41 Boosted Smart Amplifier David Rhodes
2021-06-29 23:51 ` Pierre-Louis Bossart
2021-06-30 21:35 ` David Rhodes [this message]
2021-07-01 11:54 ` Pierre-Louis Bossart
2021-07-01 20:22 ` David Rhodes
2021-07-02 12:08 ` Mark Brown
2021-07-02 15:23 ` David Rhodes
2021-07-02 15:48 ` Mark Brown
2021-07-02 15:52 ` David Rhodes
2021-07-12 8:32 ` Charles Keepax
2021-06-29 22:27 ` [PATCH v2 2/2] ASoC: cs35l41: Add bindings for CS35L41 David Rhodes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e432f81-9229-57d3-5231-50d6f935d084@opensource.cirrus.com \
--to=drhodes@opensource.cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=brian.austin@cirrus.com \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=david.rhodes@cirrus.com \
--cc=patches@opensource.cirrus.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.