From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Julien Grall <julien.grall@arm.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Wei Liu <wei.liu2@citrix.com>,
Xen-devel <xen-devel@lists.xen.org>,
Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH] xen/build-id: Fix xen_build_id_check() to be robust against malformed notes
Date: Mon, 7 Jan 2019 17:34:30 +0000 [thread overview]
Message-ID: <9e49a9d5-0079-c3c8-ea21-5085bf7b6d96@citrix.com> (raw)
In-Reply-To: <5C332BC6020000780020AC6D@prv1-mh.provo.novell.com>
On 07/01/2019 10:36, Jan Beulich wrote:
>>>> On 31.12.18 at 18:34, <andrew.cooper3@citrix.com> wrote:
>> A NT_GNU_BUILD_ID with namesz longer than 4 will cause the strncmp() to use
>> bytes in adjacent stringtable entries.
>>
>> Instead, check for namesz exactly equal to 4,
> Is that a requirement spelled out anywhere? Till now I've been
> under the impression that e.g. 8 bytes of name are fine as well,
> as long as the first four of them are "GNU\0".
No idea, but if this is true then we've got bigger problems with parsing
the notes.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-01-07 17:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-31 17:34 [PATCH] xen/build-id: Fix xen_build_id_check() to be robust against malformed notes Andrew Cooper
2019-01-02 10:38 ` Roger Pau Monné
2019-01-02 10:43 ` Wei Liu
2019-01-02 12:01 ` Andrew Cooper
2019-01-07 10:33 ` Jan Beulich
2019-01-07 10:36 ` Jan Beulich
2019-01-07 17:34 ` Andrew Cooper [this message]
2019-01-08 8:44 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e49a9d5-0079-c3c8-ea21-5085bf7b6d96@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=julien.grall@arm.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.