From: Lubomir Rintel <lkundrak@v3.sk>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Arnd Bergmann <arnd@arndb.de>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] misc: hx8837: add a HiMax HX8837 display controller driver
Date: Tue, 18 Dec 2018 16:28:05 +0100 [thread overview]
Message-ID: <9e501c50ed5e9a965f7cbedd7079c24d2d95a352.camel@v3.sk> (raw)
In-Reply-To: <20181127074140.GB13965@kroah.com>
On Tue, 2018-11-27 at 08:41 +0100, Greg Kroah-Hartman wrote:
> On Mon, Nov 12, 2018 at 03:39:29AM +0100, Lubomir Rintel wrote:
> > HiMax HX8837 is a display controller used on OLPC platforms. It controls
> > backlight and is able to capture and freeze a frame when the LCD controller
> > (and the rest of the plaform) is powered off.
> >
> > This driver is based on the same code as drivers/staging/olpc_dcon.
> > I modernized it to use managed GPIO, device-tree bindings, sysfs attribtue
> > groups, essentially fixing the staging driver's TODO.
>
> You are creating custom sysfs files, with no Documentation/ABI/ update
> for us to know what those files are or how they are used :(
>
> Why do you need custom sysfs files in the first place? Isn't there
> already an api for this type of device in the kernel?
I am actually not sure. I certainly didn't find anything similar.
I've later discovered that this should perhaps be a DRM encoder driver,
because it sits between the LCDC and the panel; I'm submitting an
updated RFC version to the dri list.
Perhaps the color swizzling and frame freezing functionality that's
exposed via sysfs in this version could be exposed as a DRI property
instead.
>
> thanks,
>
> greg k-h
Lubo
next prev parent reply other threads:[~2018-12-18 15:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-12 2:39 [PATCH v3 1/2] dt-bindings: himax,hx8837: add HiMax HX8837 bindings Lubomir Rintel
2018-11-12 2:39 ` [PATCH 2/2] misc: hx8837: add a HiMax HX8837 display controller driver Lubomir Rintel
2018-11-27 7:41 ` Greg Kroah-Hartman
2018-12-18 15:28 ` Lubomir Rintel [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-10-08 20:23 [PATCH 1/2] dt-bindings: himax,hx8837: add HiMax HX8837 bindings Lubomir Rintel
2018-10-08 20:23 ` [PATCH 2/2] misc: hx8837: add a HiMax HX8837 display controller driver Lubomir Rintel
2018-10-17 14:07 ` Rob Herring
2018-10-17 14:07 ` Rob Herring
2018-09-18 20:43 [PATCH 1/2] dt-bindings: himax,hx8837: add HiMax HX8837 bindings Lubomir Rintel
2018-09-18 20:43 ` [PATCH 2/2] misc: hx8837: add a HiMax HX8837 display controller driver Lubomir Rintel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e501c50ed5e9a965f7cbedd7079c24d2d95a352.camel@v3.sk \
--to=lkundrak@v3.sk \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.