[PATCH net-next] tcp: tcp_init_buffer_space can be static

[PATCH net-next] tcp: tcp_init_buffer_space can be static

[Florian Westphal]

As of commit 98fa6271cfcb
("tcp: refactor setting the initial congestion window") this is called
only from tcp_input.c, so it can be static.

Signed-off-by: Florian Westphal <fw@strlen.de>
---
 include/net/tcp.h    | 1 -
 net/ipv4/tcp_input.c | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/include/net/tcp.h b/include/net/tcp.h
index 66e4b8331850..bca761ffa25f 100644
--- a/include/net/tcp.h
+++ b/include/net/tcp.h
@@ -662,7 +662,6 @@ void tcp_initialize_rcv_mss(struct sock *sk);
 int tcp_mtu_to_mss(struct sock *sk, int pmtu);
 int tcp_mss_to_mtu(struct sock *sk, int mss);
 void tcp_mtup_init(struct sock *sk);
-void tcp_init_buffer_space(struct sock *sk);
 
 static inline void tcp_bound_rto(const struct sock *sk)
 {
diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
index ad90102f5dfb..83330a6cb242 100644
--- a/net/ipv4/tcp_input.c
+++ b/net/ipv4/tcp_input.c
@@ -437,7 +437,7 @@ static void tcp_grow_window(struct sock *sk, const struct sk_buff *skb)
 /* 3. Try to fixup all. It is made immediately after connection enters
  *    established state.
  */
-void tcp_init_buffer_space(struct sock *sk)
+static void tcp_init_buffer_space(struct sock *sk)
 {
 	int tcp_app_win = sock_net(sk)->ipv4.sysctl_tcp_app_win;
 	struct tcp_sock *tp = tcp_sk(sk);
-- 
2.26.2

Re: [PATCH net-next] tcp: tcp_init_buffer_space can be static

[Eric Dumazet]

On 5/28/20 3:01 PM, Florian Westphal wrote:
> As of commit 98fa6271cfcb
> ("tcp: refactor setting the initial congestion window") this is called
> only from tcp_input.c, so it can be static.
> 
> Signed-off-by: Florian Westphal <fw@strlen.de>

Reviewed-by: Eric Dumazet <edumazet@google.com>

Re: [PATCH net-next] tcp: tcp_init_buffer_space can be static

[David Miller]

From: Florian Westphal <fw@strlen.de>
Date: Fri, 29 May 2020 00:01:52 +0200

> As of commit 98fa6271cfcb
> ("tcp: refactor setting the initial congestion window") this is called
> only from tcp_input.c, so it can be static.
> 
> Signed-off-by: Florian Westphal <fw@strlen.de>

Applied, thanks Florian.