From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752607AbcAGEZt (ORCPT ); Wed, 6 Jan 2016 23:25:49 -0500 Received: from host18.canaca.com ([66.49.204.205]:43817 "EHLO host18.canaca.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751272AbcAGEZo (ORCPT ); Wed, 6 Jan 2016 23:25:44 -0500 Message-ID: <9e5fd1510809a1b291e449e8e8070c8f.squirrel@mungewell.org> In-Reply-To: <20160107014721.GA35823@dtor-ws> References: <1447345535-2912-1-git-send-email-simon@mungewell.org> <1447345535-2912-2-git-send-email-simon@mungewell.org> <20151119183106.GC24773@dtor-ws> <20151210170853.GC16026@mail.corp.redhat.com> <20160104095524.GB20222@mail.corp.redhat.com> <20160107014721.GA35823@dtor-ws> Date: Wed, 6 Jan 2016 21:25:44 -0700 Subject: Re: [Patch-V2 1/6] INPUT: xpad: Add minimal support for Logitech G920 Wheel From: "Simon Wood" To: "Dmitry Torokhov" Cc: "Jiri Kosina" , "Benjamin Tissoires" , "Simon Wood" , "linux-input@vger.kernel.org" , "lkml" , "Edwin" , =?iso-8859-1?Q?=22Michal_Mal=FD=22?= , "elias vanderstuyft" User-Agent: SquirrelMail/1.5.2 [SVN] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - host18.canaca.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - mungewell.org X-Get-Message-Sender-Via: host18.canaca.com: authenticated_id: simon@mungewell.org X-Authenticated-Sender: host18.canaca.com: simon@mungewell.org X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, January 6, 2016 6:47 pm, Dmitry Torokhov wrote: > It is wrong. Aside form the fact that IMO xpad.c is the wrong place for > this code to be in, why are we waiting for the input device to be opened by > userspace before we do the switch instead of doing it immediately? The 'send magic' might be better in a probe() call, but I don't believe that it requires userspace interaction as it stands. The wheel will disconnect almost immediately without me doing anything other than plug it in. -- Jan 6 21:18:50 speedster kernel: [ 439.604037] usb 5-1: new full-speed USB device number 2 using uhci_hcd Jan 6 21:18:50 speedster kernel: [ 439.791153] usb 5-1: New USB device found, idVendor=046d, idProduct=c261 Jan 6 21:18:50 speedster kernel: [ 439.791160] usb 5-1: New USB device strings: Mfr=1, Product=2, SerialNumber=3 Jan 6 21:18:50 speedster kernel: [ 439.791164] usb 5-1: Product: G920 Driving Force Racing Wheel for Xbox One Jan 6 21:18:50 speedster kernel: [ 439.791167] usb 5-1: Manufacturer: Logitech Jan 6 21:18:50 speedster kernel: [ 439.791170] usb 5-1: SerialNumber: 00005d1d5129cebe Jan 6 21:18:50 speedster mtp-probe: checking bus 5, device 2: "/sys/devices/pci0000:00/0000:00:1d.3/usb5/5-1" Jan 6 21:18:50 speedster mtp-probe: bus: 5, device: 2 was not an MTP device Jan 6 21:18:51 speedster kernel: [ 440.815191] input: Logitech G920 Driving Force Racing Wheel as /devices/pci0000:00/0000:00:1d.3/usb5/5-1/5-1:1.0/input/input4 Jan 6 21:18:51 speedster kernel: [ 440.815310] usbcore: registered new interface driver xpad Jan 6 21:18:52 speedster kernel: [ 441.340093] usb 5-1: USB disconnect, device number 2 Jan 6 21:18:52 speedster kernel: [ 442.052037] usb 5-1: new full-speed USB device number 3 using uhci_hcd Jan 6 21:18:52 speedster kernel: [ 442.239129] usb 5-1: New USB device found, idVendor=046d, idProduct=c262 Jan 6 21:18:52 speedster kernel: [ 442.239136] usb 5-1: New USB device strings: Mfr=1, Product=2, SerialNumber=3 Jan 6 21:18:52 speedster kernel: [ 442.239139] usb 5-1: Product: G920 Driving Force Racing Wheel for Xbox One Jan 6 21:18:52 speedster kernel: [ 442.239142] usb 5-1: Manufacturer: Logitech Jan 6 21:18:52 speedster kernel: [ 442.239145] usb 5-1: SerialNumber: 00005d1d5129cebe Jan 6 21:18:52 speedster mtp-probe: checking bus 5, device 3: "/sys/devices/pci0000:00/0000:00:1d.3/usb5/5-1" Jan 6 21:18:52 speedster mtp-probe: bus: 5, device: 3 was not an MTP device Jan 6 21:18:52 speedster kernel: [ 442.267248] input: Logitech G920 Driving Force Racing Wheel for Xbox One as /devices/pci0000:00/0000:00:1d.3/usb5/5-1/5-1:1.0/0003:046D:C262.0002/input/input5 Jan 6 21:18:52 speedster kernel: [ 442.267510] logitech-hidpp-device 0003:046D:C262.0002: input,hiddev0,hidraw1: USB HID v1.11 Joystick [Logitech G920 Driving Force Racing Wheel for Xbox One] on usb-0000:00:1d.3-1/input0 Jan 6 21:18:53 speedster kernel: [ 442.322160] logitech-hidpp-device 0003:046D:C262.0002: HID++ 4.2 device connected. -- I also did a quick check with the 'send magic' disabled. Xpad creates the js0 and populates buttons, but pressing buttons/turning wheel does not result in any change in js0. I don't disagree to it being a seperate module, but don't have the time to implement/test at the moment. If some else does that would be good, can we make sure that the kconfig/makefile stuff uses same/sensible HID_CONFIGs? Simon