All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Sean Christopherson <seanjc@google.com>
Cc: kvm@vger.kernel.org, zxwang42@gmail.com, marcorr@google.com,
	jroedel@suse.de, varad.gautam@suse.com,
	Jim Mattson <jmattson@google.com>
Subject: Re: [PATCH kvm-unit-tests 1/2] unify structs for GDT descriptors
Date: Wed, 20 Oct 2021 21:10:03 +0200	[thread overview]
Message-ID: <9e61972b-3eb9-9693-3eab-274676a78be8@redhat.com> (raw)
In-Reply-To: <YXBYzvnclL+HfIMr@google.com>

On 20/10/21 19:58, Sean Christopherson wrote:
> Changelog says "unify struct", yet gdt_entry_t and gdt_desc_entry_t have fully
> redundant information.  Apparently anonymous structs aren't a thing (or I'm just
> doing it wrong), but even so, fully unifying this is not hugely problematic for
> the sole consumer.

Right, the unification is more between 32- and 64 bits.

"Unifying" the reply to both patches, the best thing to do is:

- always use gdt_entry_t as the argument

- use your definition of gdt_desc_entry_t and call it 
gdt_system_desc_entry_t.

- read the type and, if needed, cast to gdt_system_desc_entry_t to "OR" 
in the base4 field.

Paolo


  reply	other threads:[~2021-10-20 19:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-20 16:53 [PATCH kvm-unit-tests 0/2] remove tss_descr, replace with a function Paolo Bonzini
2021-10-20 16:53 ` [PATCH kvm-unit-tests 1/2] unify structs for GDT descriptors Paolo Bonzini
2021-10-20 17:58   ` Sean Christopherson
2021-10-20 19:10     ` Paolo Bonzini [this message]
2021-10-20 20:05   ` Jim Mattson
2021-10-20 16:53 ` [PATCH kvm-unit-tests 2/2] replace tss_descr global with a function Paolo Bonzini
2021-10-20 18:01   ` Sean Christopherson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9e61972b-3eb9-9693-3eab-274676a78be8@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=jmattson@google.com \
    --cc=jroedel@suse.de \
    --cc=kvm@vger.kernel.org \
    --cc=marcorr@google.com \
    --cc=seanjc@google.com \
    --cc=varad.gautam@suse.com \
    --cc=zxwang42@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.