All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kever Yang <kever.yang@rock-chips.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] rockchip: make_fit_atf.py: fix loadables property set error
Date: Fri, 5 Jul 2019 15:33:12 +0800	[thread overview]
Message-ID: <9e69263a-7afa-f205-52d3-5ff7e84f98bf@rock-chips.com> (raw)
In-Reply-To: <20190704094440.30896-1-andy.yan@rock-chips.com>

Hi Christoph,

    Could you check this issue on your side?

    This is pretty important for rk3399, this will break the support for ATF

for rk3399 boards other than puma.


On 07/04/2019 05:44 PM, Andy Yan wrote:
> Commit b238e4b00ced ("rockchip: Cleanup of make_fit_atf.py.") set
> firmware = "atf_1";
> loadables = "uboot","atf_1","atf_2";
>
> Actually it should be:
> firmware = "atf_1";
> loadables = "uboot","atf_2","atf_3";
>
> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever
> ---
>
>  arch/arm/mach-rockchip/make_fit_atf.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-rockchip/make_fit_atf.py b/arch/arm/mach-rockchip/make_fit_atf.py
> index 45ec105887..db0ae96ca8 100755
> --- a/arch/arm/mach-rockchip/make_fit_atf.py
> +++ b/arch/arm/mach-rockchip/make_fit_atf.py
> @@ -94,7 +94,7 @@ def append_conf_section(file, cnt, dtname, segments):
>      if segments != 0:
>          file.write(',')
>      for i in range(1, segments):
> -        file.write('"atf_%d"' % (i))
> +        file.write('"atf_%d"' % (i + 1))
>          if i != (segments - 1):
>              file.write(',')
>          else:

  reply	other threads:[~2019-07-05  7:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-04  9:44 [U-Boot] [PATCH] rockchip: make_fit_atf.py: fix loadables property set error Andy Yan
2019-07-05  7:33 ` Kever Yang [this message]
2019-07-05  9:15 ` Christoph Müllner
2019-07-05 10:06   ` Andy Yan
2019-07-05 10:26     ` Christoph Müllner
2019-07-05 11:38   ` Kever Yang
2019-07-05 12:03     ` Mark Kettenis
2019-07-06 15:02       ` [U-Boot] [PATCH] rockchip: make_fit_atf.py: fix loadables property set error【请注意,邮件由mark.kettenis@sibelius.xs4all.nl代发】 Kever Yang
2019-07-06 17:32         ` Christoph Müllner
2019-07-08  1:07           ` Andy Yan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9e69263a-7afa-f205-52d3-5ff7e84f98bf@rock-chips.com \
    --to=kever.yang@rock-chips.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.