From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28C63C433E0 for ; Wed, 6 Jan 2021 09:19:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C88592310B for ; Wed, 6 Jan 2021 09:19:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726308AbhAFJSz (ORCPT ); Wed, 6 Jan 2021 04:18:55 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:55762 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726295AbhAFJSy (ORCPT ); Wed, 6 Jan 2021 04:18:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1609924648; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=74reAFMP9bENCEIgFbfQOXKA/PsWi2wcOMNMUHX6jRs=; b=NncPIcfMenZN+GlJydfVWrMld/lrhzHQHBmSoMdt9BAVrc98/miKmT9CZfD71AH9I4EDor OG5dlzqln/LgNIKh8S9GBG9FkqbFroffq24LyCc0MpUWK+eKDAl9LMI4eik2RDaRE+gOlZ N0nTZf5G460yhn3MV6GzAFch0WLdemY= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-170-m-6rdBCDMTC02NjtrIhNZQ-1; Wed, 06 Jan 2021 04:17:26 -0500 X-MC-Unique: m-6rdBCDMTC02NjtrIhNZQ-1 Received: by mail-ed1-f69.google.com with SMTP id g6so1695006edw.13 for ; Wed, 06 Jan 2021 01:17:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=74reAFMP9bENCEIgFbfQOXKA/PsWi2wcOMNMUHX6jRs=; b=M1fF6+tAVnL6z/xocC+pIHxaeKhhC5prQfYwYZmFZoDUW1DEAmqFCJ555c+V9mQVz/ YSmffr/erd5Hn52htLcbYzOiPIYfREZPTTO0qHn47ET5R0KnHZLSWcnOqc8uPFEsjG+6 PvOW3EMQbdeZHFgTBbjmgRbH0g0kQvuraMMKpVVRnV7YNJ7Cgt3q++Zc1wei7lVGmeun EVTlgT4Io10aSzxlPMmDce9buTJklqRGCZZJY96sWYGaz/fUpM7OWz9aiRTWSX3pAcwQ 1LCgRcWgTUdPAqXsRuTo1KHO00ShnCSMWCs3EgjxuNNqiNpLM4htYnBAkI+Dim5SeVb2 kmWg== X-Gm-Message-State: AOAM531/xlAA1EhLOZkUpNJiQzsecHEFTgEeveQFgU6QZz1Ogtqppjgh 5xnwc7XeNWXeckeggtwTC6UMOrAInfLApECsEcowK7C8xLvvDcXX1ZIVMWCnQtKr/67b4Gyrs7z lnnV04BpUOeGhCXGXsEBHkg== X-Received: by 2002:a05:6402:746:: with SMTP id p6mr3354039edy.313.1609924645421; Wed, 06 Jan 2021 01:17:25 -0800 (PST) X-Google-Smtp-Source: ABdhPJySWOSAgxnffC8LBV3wDGbija0UW5bX4NCm1gy26Oam0C1xmlbog1r2rFQq7ZWJYvqHt58O5w== X-Received: by 2002:a05:6402:746:: with SMTP id p6mr3354035edy.313.1609924645315; Wed, 06 Jan 2021 01:17:25 -0800 (PST) Received: from x1.localdomain (2001-1c00-0c1e-bf00-37a3-353b-be90-1238.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:37a3:353b:be90:1238]) by smtp.gmail.com with ESMTPSA id z24sm1187871edr.9.2021.01.06.01.17.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Jan 2021 01:17:24 -0800 (PST) Subject: Re: [PATCH 0/2] IdeaPad platform profile support To: "Rafael J. Wysocki" Cc: Jiaxun Yang , Platform Driver , "Rafael J. Wysocki" , Len Brown , Mark Gross , Ike Panhc , Mark Pearson , ACPI Devel Maling List , Linux Kernel Mailing List References: <20210101125629.20974-1-jiaxun.yang@flygoat.com> <35ac853a-266c-6944-6e5e-6286456865e3@redhat.com> <6a29f338-d9e4-150c-81dd-2ffb54f5bc35@redhat.com> From: Hans de Goede Message-ID: <9e745724-d704-6250-9bfb-e347f3611ec4@redhat.com> Date: Wed, 6 Jan 2021 10:17:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Hi, On 1/5/21 6:18 PM, Rafael J. Wysocki wrote: > On Mon, Jan 4, 2021 at 9:58 PM Hans de Goede wrote: >> Patch 1/2 does use a slightly different approach then I suggest above, >> thinking more about this it would be cleaner IMHO to just pass the >> cur_profile pointer to the callbacks as the pseudo-code patch which I >> wrote above does. Drivers which use globals can then just ignore >> the extra argument (and keep the platform_profile_handler struct const) >> where as drivers which use dynamic allocation can embed the struct in >> their driver's data-struct. > > Agreed. Note that Jiaxun has provided a v2 of this patch-set with patch 1/2 implementing the new approach. Can you merge merge that patch please and then once you're happy that this has seen enough exposure in -next, provide me with an immutable branch with the 3 platform-profile patches in it ? Regards, Hans