From: James Smart <jsmart2021@gmail.com>
To: linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvmet/fc: do not check for invalid target port in nvmet_fc_handle_fcp_rqst()
Date: Thu, 3 Jun 2021 16:52:54 -0700 [thread overview]
Message-ID: <9e76d0b2-fa41-03d0-2230-f7ecc2444485@gmail.com> (raw)
In-Reply-To: <20210525125414.68118-1-hare@suse.de>
On 5/25/2021 5:54 AM, Hannes Reinecke wrote:
> When parsing a request in nvmet_fc_handle_fcp_rqst() we should not
> check for invalid target ports; if we do the command is aborted
> from the fcp layer, causing the host to assume a transport error.
> Rather we should still forward this request to the nvmet layer, which
> will then correctly fail the command with an appropriate error status.
>
> Signed-off-by: Hannes Reinecke <hare@suse.de>
Well, correct behavior either way as I to would think it is a transport
error if the port hasn't been tied to any subsystem yet. But, I guess
it's fine to let nvmet_find_get_subsys() see the null port pointer and
fail Connect with INVALID_PARAM|DNR as well.
so - ok
Reviewed-by: James Smart <jsmart2021@gmail.com>
-- james
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-06-03 23:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-25 12:54 [PATCH] nvmet/fc: do not check for invalid target port in nvmet_fc_handle_fcp_rqst() Hannes Reinecke
2021-06-03 23:52 ` James Smart [this message]
2021-06-08 16:43 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e76d0b2-fa41-03d0-2230-f7ecc2444485@gmail.com \
--to=jsmart2021@gmail.com \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.