All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Liang, Kan" <kan.liang@linux.intel.com>
To: acme@kernel.org, jolsa@kernel.org, mingo@redhat.com,
	linux-kernel@vger.kernel.org
Cc: ak@linux.intel.com
Subject: Re: [PATCH] perf vendor events intel: Add uncore_upi JSON support
Date: Mon, 13 May 2019 17:29:30 -0400	[thread overview]
Message-ID: <9e816fed-5d00-c490-21b3-ad9c56dac446@linux.intel.com> (raw)
In-Reply-To: <1557234991-130456-1-git-send-email-kan.liang@linux.intel.com>

Hi Arnaldo,

Could you please apply this fix?

Thanks,
Kan

On 5/7/2019 9:16 AM, kan.liang@linux.intel.com wrote:
> From: Kan Liang <kan.liang@linux.intel.com>
> 
> Perf cannot parse UPI events.
> 
>      #perf stat -e UPI_DATA_BANDWIDTH_TX
>      event syntax error: 'UPI_DATA_BANDWIDTH_TX'
>                       \___ parser error
>      Run 'perf list' for a list of valid events
> 
> The JSON lists call the box UPI LL, while perf calls it upi.
> Add conversion support to json to convert the unit properly.
> 
> Signed-off-by: Kan Liang <kan.liang@linux.intel.com>
> ---
>   tools/perf/pmu-events/jevents.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/tools/perf/pmu-events/jevents.c b/tools/perf/pmu-events/jevents.c
> index 68c92bb..daaea50 100644
> --- a/tools/perf/pmu-events/jevents.c
> +++ b/tools/perf/pmu-events/jevents.c
> @@ -235,6 +235,7 @@ static struct map {
>   	{ "iMPH-U", "uncore_arb" },
>   	{ "CPU-M-CF", "cpum_cf" },
>   	{ "CPU-M-SF", "cpum_sf" },
> +	{ "UPI LL", "uncore_upi" },
>   	{}
>   };
>   
> 

  reply	other threads:[~2019-05-13 21:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-07 13:16 [PATCH] perf vendor events intel: Add uncore_upi JSON support kan.liang
2019-05-13 21:29 ` Liang, Kan [this message]
2019-05-13 22:05   ` Arnaldo Carvalho de Melo
2019-05-14 12:59   ` Arnaldo Carvalho de Melo
2019-05-14 14:42     ` Liang, Kan
2019-05-18  8:58 ` [tip:perf/core] " tip-bot for Kan Liang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9e816fed-5d00-c490-21b3-ad9c56dac446@linux.intel.com \
    --to=kan.liang@linux.intel.com \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.