From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26D6CC433E0 for ; Fri, 24 Jul 2020 10:34:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0C8052073E for ; Fri, 24 Jul 2020 10:34:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726483AbgGXKeD (ORCPT ); Fri, 24 Jul 2020 06:34:03 -0400 Received: from foss.arm.com ([217.140.110.172]:59732 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726329AbgGXKeD (ORCPT ); Fri, 24 Jul 2020 06:34:03 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4808730E; Fri, 24 Jul 2020 03:34:02 -0700 (PDT) Received: from [10.163.85.90] (unknown [10.163.85.90]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 773A53F66E; Fri, 24 Jul 2020 03:33:58 -0700 (PDT) Subject: Re: [PATCH -next] arm64: Export __cpu_logical_map To: Catalin Marinas , Mark Rutland Cc: Kefeng Wang , Will Deacon , Mikko Perttunen , Sumit Gupta , Viresh Kumar , Hulk Robot , "linux-kernel@vger.kernel.org List" , linux-arm-kernel@lists.infradead.org References: <20200724030433.22287-1-wangkefeng.wang@huawei.com> <82f750c4-d423-1ed8-a158-e75153745e07@huawei.com> <7998529f-da52-5e46-dd09-b9b11d83ec1a@arm.com> <20200724091308.GA44746@C02TD0UTHF1T.local> <20200724093528.GB23388@gaia> From: Anshuman Khandual Message-ID: <9e84050e-d748-5840-128c-2438ac005416@arm.com> Date: Fri, 24 Jul 2020 16:03:20 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200724093528.GB23388@gaia> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/24/2020 03:05 PM, Catalin Marinas wrote: > On Fri, Jul 24, 2020 at 10:13:52AM +0100, Mark Rutland wrote: >> On Fri, Jul 24, 2020 at 01:46:18PM +0530, Anshuman Khandual wrote: >>> On 07/24/2020 08:38 AM, Kefeng Wang wrote: >>>>> Reported-by: Hulk Robot >>>>> Signed-off-by: Kefeng Wang >>>>> --- >>>>> � arch/arm64/kernel/setup.c | 1 + >>>>> � 1 file changed, 1 insertion(+) >>>>> >>>>> diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c >>>>> index c793276ec7ad9..3aea05fbb9998 100644 >>>>> --- a/arch/arm64/kernel/setup.c >>>>> +++ b/arch/arm64/kernel/setup.c >>>>> @@ -275,6 +275,7 @@ static int __init reserve_memblock_reserved_regions(void) >>>>> � arch_initcall(reserve_memblock_reserved_regions); >>>>> � � u64 __cpu_logical_map[NR_CPUS] = { [0 ... NR_CPUS-1] = INVALID_HWID }; >>>>> +EXPORT_SYMBOL(__cpu_logical_map); >> >> If modules are using cpu_logical_map(), this looks sane ot me, but I >> wonder if we should instead turn cpu_logical_map() into a C wrapper in >> smp.c, or at least mark __cpu_logical_map as __ro_after_init lest >> someone have the bright idea to fiddle with it. > > I'd go for a C wrapper and also change a couple of instances where we > assign a value directly to cpu_logical_map(cpu). Probably also create a set_cpu_logical_map(cpu, hwid) for those instances as well. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B365C433DF for ; Fri, 24 Jul 2020 10:35:28 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 43D53206C1 for ; Fri, 24 Jul 2020 10:35:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="m46IPouH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 43D53206C1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=i+kXbnr7mQHaT555Bmx4lA2WeFFtrdWOYQ4Vixfl7Js=; b=m46IPouHIPhsJFdUHdkKVK3pL UIGZLdt8xx2s7T3XNjIxoNoDZ9AOp2Ejl6zar3d+MUdukl53wR8pKQyxkY+0D3OSOjj5wbBPvBnka TpNcmtzjVhLpyYPDpA2YByyI971XfpmEdfMnxvDpnj0gVUgUKTvLoicTCxtbRrM7Zv565UiMidyDQ vnwXPBcaijQu0e8F3VV7mBb06Vkg42nJTt16o2bAlP75GXlTXaFz+n/yRz75zA8h3pO1v5txvuvBL 4viATicxm5irFittMMiLiuzHc9iUP2t5yk86IUuaunXgT9Be/wrM8zJaWwBuXCqkNTDsvY/Spe3GY p+Fjf58hw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jyv1i-0005Qm-E5; Fri, 24 Jul 2020 10:34:06 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jyv1g-0005Q6-Eq for linux-arm-kernel@lists.infradead.org; Fri, 24 Jul 2020 10:34:05 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4808730E; Fri, 24 Jul 2020 03:34:02 -0700 (PDT) Received: from [10.163.85.90] (unknown [10.163.85.90]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 773A53F66E; Fri, 24 Jul 2020 03:33:58 -0700 (PDT) Subject: Re: [PATCH -next] arm64: Export __cpu_logical_map To: Catalin Marinas , Mark Rutland References: <20200724030433.22287-1-wangkefeng.wang@huawei.com> <82f750c4-d423-1ed8-a158-e75153745e07@huawei.com> <7998529f-da52-5e46-dd09-b9b11d83ec1a@arm.com> <20200724091308.GA44746@C02TD0UTHF1T.local> <20200724093528.GB23388@gaia> From: Anshuman Khandual Message-ID: <9e84050e-d748-5840-128c-2438ac005416@arm.com> Date: Fri, 24 Jul 2020 16:03:20 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200724093528.GB23388@gaia> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200724_063404_561767_AD38620D X-CRM114-Status: GOOD ( 15.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kefeng Wang , Viresh Kumar , "linux-kernel@vger.kernel.org List" , Mikko Perttunen , Hulk Robot , Sumit Gupta , Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org CgpPbiAwNy8yNC8yMDIwIDAzOjA1IFBNLCBDYXRhbGluIE1hcmluYXMgd3JvdGU6Cj4gT24gRnJp LCBKdWwgMjQsIDIwMjAgYXQgMTA6MTM6NTJBTSArMDEwMCwgTWFyayBSdXRsYW5kIHdyb3RlOgo+ PiBPbiBGcmksIEp1bCAyNCwgMjAyMCBhdCAwMTo0NjoxOFBNICswNTMwLCBBbnNodW1hbiBLaGFu ZHVhbCB3cm90ZToKPj4+IE9uIDA3LzI0LzIwMjAgMDg6MzggQU0sIEtlZmVuZyBXYW5nIHdyb3Rl Ogo+Pj4+PiBSZXBvcnRlZC1ieTogSHVsayBSb2JvdCA8aHVsa2NpQGh1YXdlaS5jb20+Cj4+Pj4+ IFNpZ25lZC1vZmYtYnk6IEtlZmVuZyBXYW5nIDx3YW5na2VmZW5nLndhbmdAaHVhd2VpLmNvbT4K Pj4+Pj4gLS0tCj4+Pj4+IMOvwr/CvSBhcmNoL2FybTY0L2tlcm5lbC9zZXR1cC5jIHwgMSArCj4+ Pj4+IMOvwr/CvSAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKykKPj4+Pj4KPj4+Pj4gZGlm ZiAtLWdpdCBhL2FyY2gvYXJtNjQva2VybmVsL3NldHVwLmMgYi9hcmNoL2FybTY0L2tlcm5lbC9z ZXR1cC5jCj4+Pj4+IGluZGV4IGM3OTMyNzZlYzdhZDkuLjNhZWEwNWZiYjk5OTggMTAwNjQ0Cj4+ Pj4+IC0tLSBhL2FyY2gvYXJtNjQva2VybmVsL3NldHVwLmMKPj4+Pj4gKysrIGIvYXJjaC9hcm02 NC9rZXJuZWwvc2V0dXAuYwo+Pj4+PiBAQCAtMjc1LDYgKzI3NSw3IEBAIHN0YXRpYyBpbnQgX19p bml0IHJlc2VydmVfbWVtYmxvY2tfcmVzZXJ2ZWRfcmVnaW9ucyh2b2lkKQo+Pj4+PiDDr8K/wr0g YXJjaF9pbml0Y2FsbChyZXNlcnZlX21lbWJsb2NrX3Jlc2VydmVkX3JlZ2lvbnMpOwo+Pj4+PiDD r8K/wr0gw6/Cv8K9IHU2NCBfX2NwdV9sb2dpY2FsX21hcFtOUl9DUFVTXSA9IHsgWzAgLi4uIE5S X0NQVVMtMV0gPSBJTlZBTElEX0hXSUQgfTsKPj4+Pj4gK0VYUE9SVF9TWU1CT0woX19jcHVfbG9n aWNhbF9tYXApOwo+Pgo+PiBJZiBtb2R1bGVzIGFyZSB1c2luZyBjcHVfbG9naWNhbF9tYXAoKSwg dGhpcyBsb29rcyBzYW5lIG90IG1lLCBidXQgSQo+PiB3b25kZXIgaWYgd2Ugc2hvdWxkIGluc3Rl YWQgdHVybiBjcHVfbG9naWNhbF9tYXAoKSBpbnRvIGEgQyB3cmFwcGVyIGluCj4+IHNtcC5jLCBv ciBhdCBsZWFzdCBtYXJrIF9fY3B1X2xvZ2ljYWxfbWFwIGFzIF9fcm9fYWZ0ZXJfaW5pdCBsZXN0 Cj4+IHNvbWVvbmUgaGF2ZSB0aGUgYnJpZ2h0IGlkZWEgdG8gZmlkZGxlIHdpdGggaXQuCj4gCj4g SSdkIGdvIGZvciBhIEMgd3JhcHBlciBhbmQgYWxzbyBjaGFuZ2UgYSBjb3VwbGUgb2YgaW5zdGFu Y2VzIHdoZXJlIHdlCj4gYXNzaWduIGEgdmFsdWUgZGlyZWN0bHkgdG8gY3B1X2xvZ2ljYWxfbWFw KGNwdSkuCgpQcm9iYWJseSBhbHNvIGNyZWF0ZSBhIHNldF9jcHVfbG9naWNhbF9tYXAoY3B1LCBo d2lkKSBmb3IgdGhvc2UgaW5zdGFuY2VzCmFzIHdlbGwuCgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdAps aW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVh ZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==