From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C159C47096 for ; Fri, 4 Jun 2021 01:22:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 08BD9613F4 for ; Fri, 4 Jun 2021 01:22:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229917AbhFDBYk (ORCPT ); Thu, 3 Jun 2021 21:24:40 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:33571 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229576AbhFDBYj (ORCPT ); Thu, 3 Jun 2021 21:24:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622769773; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AiiEtVElMgCs593JVIVumZLvj+RIl3xZvMt3+bseh5s=; b=UZGEFjujhD+8cDGF19bMTsF/waadFYiEjwgtsGSKPtckBOOpbrYkHGHFoCfn6S1efBEcs0 icscgBcfccfQZsTL3MZ4+TcFZNwSh8Jsc8DNZew4QF0qbgUflUkHKan7Co/ifJ5gDqPuiP QzcpsIU/yGKZLNbVVjyeMZkF3CJYJY4= Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-286-Xd7xZOJRPOugNkXryYETRg-1; Thu, 03 Jun 2021 21:22:52 -0400 X-MC-Unique: Xd7xZOJRPOugNkXryYETRg-1 Received: by mail-pf1-f197.google.com with SMTP id g144-20020a6252960000b029023d959faca6so4429409pfb.9 for ; Thu, 03 Jun 2021 18:22:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=AiiEtVElMgCs593JVIVumZLvj+RIl3xZvMt3+bseh5s=; b=AFbWF3/wumpxoT3+WB44XTc1eKS4Bd45xSxEjRjlrs4cyKAoutII4nG5p9pbGMnbFf bB61MdoU45aFA4GmTcIalaAb4So6/iWR9BSv2wNfMUZtyYKtCvMEVBLkrIuwJeg/H5tD k5xkEehaRAVu3+FumqtwGa7zLJcllA4E08tFqq6A2LvQX7ed6kDC4+vJouR2HFqfjzT5 JXZrrsVwuhzItdI5pBZCoOdTTk0n0Ow8zgb0m36A7t/HknOVQA7taSMw7FXXJMIMi/DN n5ugei3kZBYD2J0Wv+wOiaVcb/CNI12zrmXp53eORiJjOnCBgyFzzsLCgaUQbWzmkRLB bc+w== X-Gm-Message-State: AOAM532HdCkUd0FqoG/gTFVbB7DLCDWzeoG+wRrLf8CiF8OIYXHUnd11 4yjy1yzuDl6Sx3rx9oyqPm7o/7Jjm2Dkb5c9PhxIYESaIBUrTWQumyLO1+wH7qYfLqhygwht6LY /HRoXsA/t/bfixFyBwb7VT9EaBpzU5aF1pECRJMK3UUtHs+4AB9Hm2b6R1JvQojyw2vinwoWVJg Nl X-Received: by 2002:aa7:8a5a:0:b029:2ec:7134:7540 with SMTP id n26-20020aa78a5a0000b02902ec71347540mr2069655pfa.66.1622769771440; Thu, 03 Jun 2021 18:22:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy8I13DZmKGfIc2huzbd5KLYaSyAe/mhYmV3rOnMwUy40nEmTkBCn9htxKDX0fkN/UX8S97Dg== X-Received: by 2002:aa7:8a5a:0:b029:2ec:7134:7540 with SMTP id n26-20020aa78a5a0000b02902ec71347540mr2069623pfa.66.1622769771073; Thu, 03 Jun 2021 18:22:51 -0700 (PDT) Received: from wangxiaodeMacBook-Air.local ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id k17sm232575pff.66.2021.06.03.18.22.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Jun 2021 18:22:50 -0700 (PDT) Subject: Re: [PATCH v1 1/8] virtio: Force only split mode with protected guest To: Andy Lutomirski , Andi Kleen , mst@redhat.com Cc: virtualization@lists.linux-foundation.org, hch@lst.de, m.szyprowski@samsung.com, robin.murphy@arm.com, iommu@lists.linux-foundation.org, the arch/x86 maintainers , sathyanarayanan.kuppuswamy@linux.intel.com, Josh Poimboeuf , Linux Kernel Mailing List References: <20210603004133.4079390-1-ak@linux.intel.com> <20210603004133.4079390-2-ak@linux.intel.com> <2b2dec75-a0c1-4013-ac49-a49f30d5ac3c@www.fastmail.com> From: Jason Wang Message-ID: <9e842353-fec7-667e-8b76-61dbb092f0d8@redhat.com> Date: Fri, 4 Jun 2021 09:22:45 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: <2b2dec75-a0c1-4013-ac49-a49f30d5ac3c@www.fastmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2021/6/4 上午3:31, Andy Lutomirski 写道: > > On Thu, Jun 3, 2021, at 11:00 AM, Andi Kleen wrote: >> On 6/3/2021 10:33 AM, Andy Lutomirski wrote: >>> On 6/2/21 5:41 PM, Andi Kleen wrote: >>>> Only allow split mode when in a protected guest. Followon >>>> patches harden the split mode code paths, and we don't want >>>> an malicious host to force anything else. Also disallow >>>> indirect mode for similar reasons. >>> I read this as "the virtio driver is buggy. Let's disable most of the >>> buggy code in one special case in which we need a driver without bugs. >>> In all the other cases (e.g. hardware virtio device connected over >>> USB-C), driver bugs are still allowed." >> My understanding is most of the other modes (except for split with >> separate descriptors) are obsolete and just there for compatibility. As >> long as they're deprecated they won't harm anyone. >> >> > Tell that to every crypto downgrade attack ever. > > I see two credible solutions: > > 1. Actually harden the virtio driver. > > 2. Have a new virtio-modern driver and use it for modern use cases. Maybe rename the old driver virtio-legacy or virtio-insecure. They can share code. Note that we had already split legacy driver out which can be turned off via Kconfig. > > Another snag you may hit: virtio’s heuristic for whether to use proper DMA ops or to bypass them is a giant kludge. I’m very slightly optimistic that getting the heuristic wrong will make the driver fail to operate but won’t allow the host to take over the guest, but I’m not really convinced. And I wrote that code! A virtio-modern mode probably should not have a heuristic, and the various iommu-bypassing modes should be fixed to work at the bus level, not the device level. I remember there's a very long discussion about this and probably without any conclusion. Fortunately, the management layer has been taught to enforce VIRTIO_F_ACCESS_PLATFORM for encrypted guests. A possible way to fix this is without any conflicts is to mandate the VIRTIO_F_ACCESS_PLATFORM in version 1.2. Thanks > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03E95C47082 for ; Fri, 4 Jun 2021 01:23:00 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AA449613FE for ; Fri, 4 Jun 2021 01:22:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AA449613FE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 785164068F; Fri, 4 Jun 2021 01:22:59 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8sHUkQfcmaLh; Fri, 4 Jun 2021 01:22:58 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp4.osuosl.org (Postfix) with ESMTP id 30C5040691; Fri, 4 Jun 2021 01:22:58 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 9B309C0023; Fri, 4 Jun 2021 01:22:57 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 4310CC0011 for ; Fri, 4 Jun 2021 01:22:57 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 0EB1840609 for ; Fri, 4 Jun 2021 01:22:56 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NDzAvUwQx7xU for ; Fri, 4 Jun 2021 01:22:55 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by smtp4.osuosl.org (Postfix) with ESMTPS id 31D8B4068F for ; Fri, 4 Jun 2021 01:22:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622769773; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AiiEtVElMgCs593JVIVumZLvj+RIl3xZvMt3+bseh5s=; b=UZGEFjujhD+8cDGF19bMTsF/waadFYiEjwgtsGSKPtckBOOpbrYkHGHFoCfn6S1efBEcs0 icscgBcfccfQZsTL3MZ4+TcFZNwSh8Jsc8DNZew4QF0qbgUflUkHKan7Co/ifJ5gDqPuiP QzcpsIU/yGKZLNbVVjyeMZkF3CJYJY4= Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-513-58P9QTaOPw6-8yURu9GMCg-1; Thu, 03 Jun 2021 21:22:52 -0400 X-MC-Unique: 58P9QTaOPw6-8yURu9GMCg-1 Received: by mail-pg1-f198.google.com with SMTP id 4-20020a6317440000b029021689797ccaso4980088pgx.4 for ; Thu, 03 Jun 2021 18:22:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=AiiEtVElMgCs593JVIVumZLvj+RIl3xZvMt3+bseh5s=; b=jzMmtNn+iemq1Xk1AzIcwviYyOGFiyzQtCFqsLnz+zsmD22pd7oM5mgPCdZdJgcoY2 2XBUlhVU6KS5VRdqNqltA/xaZzgqPbP5ES7ruZKnwpZdeMBWvlQrjLYOoH4BWVA8TPF3 vowNIsHSSwXQff4cKVgqePh35C2KmOIeDdts77DNAOI2BjMHPd0mEmCY5cMMycMubijV 8edyN3Fctn5vNdyPPDUZZDGCk9rj8jCbLE9UXqIzt+C6v8PZlge1+r1nFz8xA6rGpAGV zkoPkoqOzcCTvnV6NJhFAAJN7DVK5W1+XCF9YPJCX/wE97FAw3uWGkR6pHko3fhFo2sr suAA== X-Gm-Message-State: AOAM531/ODvOzxjlBPC+E655KhjnYHO/62FP7B0fmxLwo+/FdZS0rFtm Qa4fVGQVy8eZ3hdm7yNGPl5K1EiKd74S7/Z+ZxfZWg0W1Q8OUPCmj333WB5jsSfiNvF8prGVj/P VaWmKg5xSWpgLtxvcIaulVc/lT6icWQ== X-Received: by 2002:aa7:8a5a:0:b029:2ec:7134:7540 with SMTP id n26-20020aa78a5a0000b02902ec71347540mr2069636pfa.66.1622769771345; Thu, 03 Jun 2021 18:22:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy8I13DZmKGfIc2huzbd5KLYaSyAe/mhYmV3rOnMwUy40nEmTkBCn9htxKDX0fkN/UX8S97Dg== X-Received: by 2002:aa7:8a5a:0:b029:2ec:7134:7540 with SMTP id n26-20020aa78a5a0000b02902ec71347540mr2069623pfa.66.1622769771073; Thu, 03 Jun 2021 18:22:51 -0700 (PDT) Received: from wangxiaodeMacBook-Air.local ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id k17sm232575pff.66.2021.06.03.18.22.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Jun 2021 18:22:50 -0700 (PDT) Subject: Re: [PATCH v1 1/8] virtio: Force only split mode with protected guest To: Andy Lutomirski , Andi Kleen , mst@redhat.com References: <20210603004133.4079390-1-ak@linux.intel.com> <20210603004133.4079390-2-ak@linux.intel.com> <2b2dec75-a0c1-4013-ac49-a49f30d5ac3c@www.fastmail.com> From: Jason Wang Message-ID: <9e842353-fec7-667e-8b76-61dbb092f0d8@redhat.com> Date: Fri, 4 Jun 2021 09:22:45 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: <2b2dec75-a0c1-4013-ac49-a49f30d5ac3c@www.fastmail.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jasowang@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Cc: the arch/x86 maintainers , Linux Kernel Mailing List , virtualization@lists.linux-foundation.org, iommu@lists.linux-foundation.org, Josh Poimboeuf , robin.murphy@arm.com, hch@lst.de X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" CuWcqCAyMDIxLzYvNCDkuIrljYgzOjMxLCBBbmR5IEx1dG9taXJza2kg5YaZ6YGTOgo+Cj4gT24g VGh1LCBKdW4gMywgMjAyMSwgYXQgMTE6MDAgQU0sIEFuZGkgS2xlZW4gd3JvdGU6Cj4+IE9uIDYv My8yMDIxIDEwOjMzIEFNLCBBbmR5IEx1dG9taXJza2kgd3JvdGU6Cj4+PiBPbiA2LzIvMjEgNTo0 MSBQTSwgQW5kaSBLbGVlbiB3cm90ZToKPj4+PiBPbmx5IGFsbG93IHNwbGl0IG1vZGUgd2hlbiBp biBhIHByb3RlY3RlZCBndWVzdC4gRm9sbG93b24KPj4+PiBwYXRjaGVzIGhhcmRlbiB0aGUgc3Bs aXQgbW9kZSBjb2RlIHBhdGhzLCBhbmQgd2UgZG9uJ3Qgd2FudAo+Pj4+IGFuIG1hbGljaW91cyBo b3N0IHRvIGZvcmNlIGFueXRoaW5nIGVsc2UuIEFsc28gZGlzYWxsb3cKPj4+PiBpbmRpcmVjdCBt b2RlIGZvciBzaW1pbGFyIHJlYXNvbnMuCj4+PiBJIHJlYWQgdGhpcyBhcyAidGhlIHZpcnRpbyBk cml2ZXIgaXMgYnVnZ3kuICBMZXQncyBkaXNhYmxlIG1vc3Qgb2YgdGhlCj4+PiBidWdneSBjb2Rl IGluIG9uZSBzcGVjaWFsIGNhc2UgaW4gd2hpY2ggd2UgbmVlZCBhIGRyaXZlciB3aXRob3V0IGJ1 Z3MuCj4+PiBJbiBhbGwgdGhlIG90aGVyIGNhc2VzIChlLmcuIGhhcmR3YXJlIHZpcnRpbyBkZXZp Y2UgY29ubmVjdGVkIG92ZXIKPj4+IFVTQi1DKSwgZHJpdmVyIGJ1Z3MgYXJlIHN0aWxsIGFsbG93 ZWQuIgo+PiBNeSB1bmRlcnN0YW5kaW5nIGlzIG1vc3Qgb2YgdGhlIG90aGVyIG1vZGVzIChleGNl cHQgZm9yIHNwbGl0IHdpdGgKPj4gc2VwYXJhdGUgZGVzY3JpcHRvcnMpIGFyZSBvYnNvbGV0ZSBh bmQganVzdCB0aGVyZSBmb3IgY29tcGF0aWJpbGl0eS4gQXMKPj4gbG9uZyBhcyB0aGV5J3JlIGRl cHJlY2F0ZWQgdGhleSB3b24ndCBoYXJtIGFueW9uZS4KPj4KPj4KPiBUZWxsIHRoYXQgdG8gZXZl cnkgY3J5cHRvIGRvd25ncmFkZSBhdHRhY2sgZXZlci4KPgo+IEkgc2VlIHR3byBjcmVkaWJsZSBz b2x1dGlvbnM6Cj4KPiAxLiBBY3R1YWxseSBoYXJkZW4gdGhlIHZpcnRpbyBkcml2ZXIuCj4KPiAy LiBIYXZlIGEgbmV3IHZpcnRpby1tb2Rlcm4gZHJpdmVyIGFuZCB1c2UgaXQgZm9yIG1vZGVybiB1 c2UgY2FzZXMuIE1heWJlIHJlbmFtZSB0aGUgb2xkIGRyaXZlciB2aXJ0aW8tbGVnYWN5IG9yIHZp cnRpby1pbnNlY3VyZS4gIFRoZXkgY2FuIHNoYXJlIGNvZGUuCgoKTm90ZSB0aGF0IHdlIGhhZCBh bHJlYWR5IHNwbGl0IGxlZ2FjeSBkcml2ZXIgb3V0IHdoaWNoIGNhbiBiZSB0dXJuZWQgb2ZmIAp2 aWEgS2NvbmZpZy4KCgo+Cj4gQW5vdGhlciBzbmFnIHlvdSBtYXkgaGl0OiB2aXJ0aW/igJlzIGhl dXJpc3RpYyBmb3Igd2hldGhlciB0byB1c2UgcHJvcGVyIERNQSBvcHMgb3IgdG8gYnlwYXNzIHRo ZW0gaXMgYSBnaWFudCBrbHVkZ2UuIEnigJltIHZlcnkgc2xpZ2h0bHkgb3B0aW1pc3RpYyB0aGF0 IGdldHRpbmcgdGhlIGhldXJpc3RpYyB3cm9uZyB3aWxsIG1ha2UgdGhlIGRyaXZlciBmYWlsIHRv IG9wZXJhdGUgYnV0IHdvbuKAmXQgYWxsb3cgdGhlIGhvc3QgdG8gdGFrZSBvdmVyIHRoZSBndWVz dCwgYnV0IEnigJltIG5vdCByZWFsbHkgY29udmluY2VkLiBBbmQgSSB3cm90ZSB0aGF0IGNvZGUh ICBBIHZpcnRpby1tb2Rlcm4gbW9kZSBwcm9iYWJseSBzaG91bGQgbm90IGhhdmUgYSBoZXVyaXN0 aWMsIGFuZCB0aGUgdmFyaW91cyBpb21tdS1ieXBhc3NpbmcgbW9kZXMgc2hvdWxkIGJlIGZpeGVk IHRvIHdvcmsgYXQgdGhlIGJ1cyBsZXZlbCwgbm90IHRoZSBkZXZpY2UgbGV2ZWwuCgoKSSByZW1l bWJlciB0aGVyZSdzIGEgdmVyeSBsb25nIGRpc2N1c3Npb24gYWJvdXQgdGhpcyBhbmQgcHJvYmFi bHkgCndpdGhvdXQgYW55IGNvbmNsdXNpb24uIEZvcnR1bmF0ZWx5LCB0aGUgbWFuYWdlbWVudCBs YXllciBoYXMgYmVlbiAKdGF1Z2h0IHRvIGVuZm9yY2UgVklSVElPX0ZfQUNDRVNTX1BMQVRGT1JN IGZvciBlbmNyeXB0ZWQgZ3Vlc3RzLgoKQSBwb3NzaWJsZSB3YXkgdG8gZml4IHRoaXMgaXMgd2l0 aG91dCBhbnkgY29uZmxpY3RzIGlzIHRvIG1hbmRhdGUgdGhlIApWSVJUSU9fRl9BQ0NFU1NfUExB VEZPUk0gaW4gdmVyc2lvbiAxLjIuCgpUaGFua3MKCgo+CgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwppb21tdSBtYWlsaW5nIGxpc3QKaW9tbXVAbGlzdHMu bGludXgtZm91bmRhdGlvbi5vcmcKaHR0cHM6Ly9saXN0cy5saW51eGZvdW5kYXRpb24ub3JnL21h aWxtYW4vbGlzdGluZm8vaW9tbXU= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1366C47096 for ; Fri, 4 Jun 2021 01:22:59 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 517AA613E3 for ; Fri, 4 Jun 2021 01:22:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 517AA613E3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=virtualization-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 201BC84376; Fri, 4 Jun 2021 01:22:59 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8BGwmQndYFqA; Fri, 4 Jun 2021 01:22:58 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp1.osuosl.org (Postfix) with ESMTP id AEC9884373; Fri, 4 Jun 2021 01:22:57 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 395EDC000E; Fri, 4 Jun 2021 01:22:57 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 1C155C0001 for ; Fri, 4 Jun 2021 01:22:56 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 008A940691 for ; Fri, 4 Jun 2021 01:22:56 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp4.osuosl.org (amavisd-new); dkim=pass (1024-bit key) header.d=redhat.com Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VWp5S_jI1iEE for ; Fri, 4 Jun 2021 01:22:55 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by smtp4.osuosl.org (Postfix) with ESMTPS id 019CF40609 for ; Fri, 4 Jun 2021 01:22:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622769773; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AiiEtVElMgCs593JVIVumZLvj+RIl3xZvMt3+bseh5s=; b=UZGEFjujhD+8cDGF19bMTsF/waadFYiEjwgtsGSKPtckBOOpbrYkHGHFoCfn6S1efBEcs0 icscgBcfccfQZsTL3MZ4+TcFZNwSh8Jsc8DNZew4QF0qbgUflUkHKan7Co/ifJ5gDqPuiP QzcpsIU/yGKZLNbVVjyeMZkF3CJYJY4= Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-193-p0I_PoRZMOuiJyT-0xi1zQ-1; Thu, 03 Jun 2021 21:22:52 -0400 X-MC-Unique: p0I_PoRZMOuiJyT-0xi1zQ-1 Received: by mail-pj1-f71.google.com with SMTP id mw15-20020a17090b4d0fb0290157199aadbaso6564601pjb.7 for ; Thu, 03 Jun 2021 18:22:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=AiiEtVElMgCs593JVIVumZLvj+RIl3xZvMt3+bseh5s=; b=TPCgKwBlYvm44V2cUyJxv471wzzWHP5FuVdOjz+PnSCQH2Iom64JdI2oIgaJDX+Vv1 RWMf/iBiAU3+aYKu11JqhZmhjpuap631hcIKhrp++PFYdfzKj/V1PXh9OxWounKgJVyb I6NATYwSfnapVbsT4Jt75G9IwIN0Q2ZZebDx8UQ9Lf6HeGvl3ZCJ5oc3cDc2OchiU5jz ZPtRx6ShRJB1b1Wk6XXlLioF15gX4l5HzURXzAO4UFtYplOLkpO6Kh8JL+bq0TQeWXSH HtpPikk3dWTyQUcjkKVtB4WW7J3N9NAEAqFRpWov/FNsp4j+eKZK1P9FrYnRMyjU5B+o +Chg== X-Gm-Message-State: AOAM530EU6vVveaEoYuejxVSxlPo5LspNwLl/zbk4ZoH3Cru2Oc/W4qL vEjaq1rXW7Wd8M+gntP/QrfUxzWXbMEc7wEQmgiJ3F3MiTB6YXN1rcLqfHupTlyr1yc8yvOnjK1 U5pBdczFCIC1AD2ElgE/UUuYoYiZnt7vK9g/E4h9Osg== X-Received: by 2002:aa7:8a5a:0:b029:2ec:7134:7540 with SMTP id n26-20020aa78a5a0000b02902ec71347540mr2069643pfa.66.1622769771346; Thu, 03 Jun 2021 18:22:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy8I13DZmKGfIc2huzbd5KLYaSyAe/mhYmV3rOnMwUy40nEmTkBCn9htxKDX0fkN/UX8S97Dg== X-Received: by 2002:aa7:8a5a:0:b029:2ec:7134:7540 with SMTP id n26-20020aa78a5a0000b02902ec71347540mr2069623pfa.66.1622769771073; Thu, 03 Jun 2021 18:22:51 -0700 (PDT) Received: from wangxiaodeMacBook-Air.local ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id k17sm232575pff.66.2021.06.03.18.22.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Jun 2021 18:22:50 -0700 (PDT) Subject: Re: [PATCH v1 1/8] virtio: Force only split mode with protected guest To: Andy Lutomirski , Andi Kleen , mst@redhat.com References: <20210603004133.4079390-1-ak@linux.intel.com> <20210603004133.4079390-2-ak@linux.intel.com> <2b2dec75-a0c1-4013-ac49-a49f30d5ac3c@www.fastmail.com> From: Jason Wang Message-ID: <9e842353-fec7-667e-8b76-61dbb092f0d8@redhat.com> Date: Fri, 4 Jun 2021 09:22:45 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: <2b2dec75-a0c1-4013-ac49-a49f30d5ac3c@www.fastmail.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jasowang@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Cc: sathyanarayanan.kuppuswamy@linux.intel.com, the arch/x86 maintainers , Linux Kernel Mailing List , virtualization@lists.linux-foundation.org, iommu@lists.linux-foundation.org, Josh Poimboeuf , robin.murphy@arm.com, hch@lst.de, m.szyprowski@samsung.com X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" CuWcqCAyMDIxLzYvNCDkuIrljYgzOjMxLCBBbmR5IEx1dG9taXJza2kg5YaZ6YGTOgo+Cj4gT24g VGh1LCBKdW4gMywgMjAyMSwgYXQgMTE6MDAgQU0sIEFuZGkgS2xlZW4gd3JvdGU6Cj4+IE9uIDYv My8yMDIxIDEwOjMzIEFNLCBBbmR5IEx1dG9taXJza2kgd3JvdGU6Cj4+PiBPbiA2LzIvMjEgNTo0 MSBQTSwgQW5kaSBLbGVlbiB3cm90ZToKPj4+PiBPbmx5IGFsbG93IHNwbGl0IG1vZGUgd2hlbiBp biBhIHByb3RlY3RlZCBndWVzdC4gRm9sbG93b24KPj4+PiBwYXRjaGVzIGhhcmRlbiB0aGUgc3Bs aXQgbW9kZSBjb2RlIHBhdGhzLCBhbmQgd2UgZG9uJ3Qgd2FudAo+Pj4+IGFuIG1hbGljaW91cyBo b3N0IHRvIGZvcmNlIGFueXRoaW5nIGVsc2UuIEFsc28gZGlzYWxsb3cKPj4+PiBpbmRpcmVjdCBt b2RlIGZvciBzaW1pbGFyIHJlYXNvbnMuCj4+PiBJIHJlYWQgdGhpcyBhcyAidGhlIHZpcnRpbyBk cml2ZXIgaXMgYnVnZ3kuICBMZXQncyBkaXNhYmxlIG1vc3Qgb2YgdGhlCj4+PiBidWdneSBjb2Rl IGluIG9uZSBzcGVjaWFsIGNhc2UgaW4gd2hpY2ggd2UgbmVlZCBhIGRyaXZlciB3aXRob3V0IGJ1 Z3MuCj4+PiBJbiBhbGwgdGhlIG90aGVyIGNhc2VzIChlLmcuIGhhcmR3YXJlIHZpcnRpbyBkZXZp Y2UgY29ubmVjdGVkIG92ZXIKPj4+IFVTQi1DKSwgZHJpdmVyIGJ1Z3MgYXJlIHN0aWxsIGFsbG93 ZWQuIgo+PiBNeSB1bmRlcnN0YW5kaW5nIGlzIG1vc3Qgb2YgdGhlIG90aGVyIG1vZGVzIChleGNl cHQgZm9yIHNwbGl0IHdpdGgKPj4gc2VwYXJhdGUgZGVzY3JpcHRvcnMpIGFyZSBvYnNvbGV0ZSBh bmQganVzdCB0aGVyZSBmb3IgY29tcGF0aWJpbGl0eS4gQXMKPj4gbG9uZyBhcyB0aGV5J3JlIGRl cHJlY2F0ZWQgdGhleSB3b24ndCBoYXJtIGFueW9uZS4KPj4KPj4KPiBUZWxsIHRoYXQgdG8gZXZl cnkgY3J5cHRvIGRvd25ncmFkZSBhdHRhY2sgZXZlci4KPgo+IEkgc2VlIHR3byBjcmVkaWJsZSBz b2x1dGlvbnM6Cj4KPiAxLiBBY3R1YWxseSBoYXJkZW4gdGhlIHZpcnRpbyBkcml2ZXIuCj4KPiAy LiBIYXZlIGEgbmV3IHZpcnRpby1tb2Rlcm4gZHJpdmVyIGFuZCB1c2UgaXQgZm9yIG1vZGVybiB1 c2UgY2FzZXMuIE1heWJlIHJlbmFtZSB0aGUgb2xkIGRyaXZlciB2aXJ0aW8tbGVnYWN5IG9yIHZp cnRpby1pbnNlY3VyZS4gIFRoZXkgY2FuIHNoYXJlIGNvZGUuCgoKTm90ZSB0aGF0IHdlIGhhZCBh bHJlYWR5IHNwbGl0IGxlZ2FjeSBkcml2ZXIgb3V0IHdoaWNoIGNhbiBiZSB0dXJuZWQgb2ZmIAp2 aWEgS2NvbmZpZy4KCgo+Cj4gQW5vdGhlciBzbmFnIHlvdSBtYXkgaGl0OiB2aXJ0aW/igJlzIGhl dXJpc3RpYyBmb3Igd2hldGhlciB0byB1c2UgcHJvcGVyIERNQSBvcHMgb3IgdG8gYnlwYXNzIHRo ZW0gaXMgYSBnaWFudCBrbHVkZ2UuIEnigJltIHZlcnkgc2xpZ2h0bHkgb3B0aW1pc3RpYyB0aGF0 IGdldHRpbmcgdGhlIGhldXJpc3RpYyB3cm9uZyB3aWxsIG1ha2UgdGhlIGRyaXZlciBmYWlsIHRv IG9wZXJhdGUgYnV0IHdvbuKAmXQgYWxsb3cgdGhlIGhvc3QgdG8gdGFrZSBvdmVyIHRoZSBndWVz dCwgYnV0IEnigJltIG5vdCByZWFsbHkgY29udmluY2VkLiBBbmQgSSB3cm90ZSB0aGF0IGNvZGUh ICBBIHZpcnRpby1tb2Rlcm4gbW9kZSBwcm9iYWJseSBzaG91bGQgbm90IGhhdmUgYSBoZXVyaXN0 aWMsIGFuZCB0aGUgdmFyaW91cyBpb21tdS1ieXBhc3NpbmcgbW9kZXMgc2hvdWxkIGJlIGZpeGVk IHRvIHdvcmsgYXQgdGhlIGJ1cyBsZXZlbCwgbm90IHRoZSBkZXZpY2UgbGV2ZWwuCgoKSSByZW1l bWJlciB0aGVyZSdzIGEgdmVyeSBsb25nIGRpc2N1c3Npb24gYWJvdXQgdGhpcyBhbmQgcHJvYmFi bHkgCndpdGhvdXQgYW55IGNvbmNsdXNpb24uIEZvcnR1bmF0ZWx5LCB0aGUgbWFuYWdlbWVudCBs YXllciBoYXMgYmVlbiAKdGF1Z2h0IHRvIGVuZm9yY2UgVklSVElPX0ZfQUNDRVNTX1BMQVRGT1JN IGZvciBlbmNyeXB0ZWQgZ3Vlc3RzLgoKQSBwb3NzaWJsZSB3YXkgdG8gZml4IHRoaXMgaXMgd2l0 aG91dCBhbnkgY29uZmxpY3RzIGlzIHRvIG1hbmRhdGUgdGhlIApWSVJUSU9fRl9BQ0NFU1NfUExB VEZPUk0gaW4gdmVyc2lvbiAxLjIuCgpUaGFua3MKCgo+CgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpWaXJ0dWFsaXphdGlvbiBtYWlsaW5nIGxpc3QKVmly dHVhbGl6YXRpb25AbGlzdHMubGludXgtZm91bmRhdGlvbi5vcmcKaHR0cHM6Ly9saXN0cy5saW51 eGZvdW5kYXRpb24ub3JnL21haWxtYW4vbGlzdGluZm8vdmlydHVhbGl6YXRpb24=