From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 869EEC3DA7D for ; Mon, 26 Dec 2022 12:28:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230497AbiLZM2d (ORCPT ); Mon, 26 Dec 2022 07:28:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45996 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232004AbiLZM2b (ORCPT ); Mon, 26 Dec 2022 07:28:31 -0500 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6621B273C for ; Mon, 26 Dec 2022 04:28:30 -0800 (PST) Received: by mail-lf1-x12a.google.com with SMTP id b3so15803035lfv.2 for ; Mon, 26 Dec 2022 04:28:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=o9VsUfbXpnBl5i0jqV0GHVfHb2fzN94uWi/WF4L80bQ=; b=EGt0tVqCcxNMIPHFjFmmSJmtfepupOLGU6WfTr20N1cfbTWvjad6h6ZyUMyzbXS0dO JwBOXpGJdV3w+qcgu5Rtn5uwfbndTK2SGADbeGhlzTuVf7uZXZEx8VcwS+kZjHfqtDIP 0tWkhL8h3pGUklT9nVvyHj4zjSRCy5xxV+pU7mEF8fHn8n2Pzbx/vNAJUk9eKyE4MOv6 /ROyOZvwmpzEkhxUOBbEQKal3v1MhUJFVTJoQnI2Ek26xL8C3MZk9lT2MbSWWw3qhtGc hcLQCFFEXXWcAowwQGVoYha+nXJpA+xlunoGYxSaFci2gOGQuDyynfLOtalsc1HLCyM3 GllA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=o9VsUfbXpnBl5i0jqV0GHVfHb2fzN94uWi/WF4L80bQ=; b=gNh1QdjmoDKclE8bdg3tIKCKRidFmif/fm9HafGrgUYF90grCiAN8cG7bzaCtx2+Vg BAHCmuQ5Jpc4w6RGndUSYee+CBOUJwVEUzc+tEmgwxK1G+vH6so2jT2uAkrmkLBbHTGS cvqCWbY5uRYKHoYyWrGCjt3dNuTd2xavEclWV4yhiZDp53051XyhBC1Ylmy4LrDEk0Fm fe2zmZWLZhf7SILFlRvGHDBPO3gXoezA+465CAbEuk88fGgHWRyOpzO51yuE3MbwtZKa 93FUjGjg2vIHRIAjBAh6Pjxwz7Mfk8109BUPHZt/oImxbAOi0gmEf1var8uXhIw5GRIa beKA== X-Gm-Message-State: AFqh2kqb+W/GoxT203sUe2YkLPVEEwlGgBBIEhXxr5WRwVRIQfJ9T6dL VmT8KVqWxfgBFGA29fY13mYfEA== X-Google-Smtp-Source: AMrXdXt+SG75PQYPAqAyfLTtW57mlbWYpcItg3HmguNy4OAxCp6Z8zw35YRYWDPCc637ckI/5JBHRQ== X-Received: by 2002:a05:6512:6d0:b0:4b5:d:efb2 with SMTP id u16-20020a05651206d000b004b5000defb2mr5311841lff.14.1672057708771; Mon, 26 Dec 2022 04:28:28 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id a11-20020ac25e6b000000b004cafd013f54sm1174058lfr.118.2022.12.26.04.28.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Dec 2022 04:28:28 -0800 (PST) Message-ID: <9e93a28b-c735-5250-34d0-9b41c0f488b5@linaro.org> Date: Mon, 26 Dec 2022 13:28:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [RFC PATCH 08/14] usb: dwc3: Add DT parameter to specify maximum number of interrupters Content-Language: en-US To: Dmitry Baryshkov , Wesley Cheng Cc: srinivas.kandagatla@linaro.org, mathias.nyman@intel.com, perex@perex.cz, broonie@kernel.org, lgirdwood@gmail.com, andersson@kernel.org, krzysztof.kozlowski+dt@linaro.org, gregkh@linuxfoundation.org, Thinh.Nguyen@synopsys.com, bgoswami@quicinc.com, tiwai@suse.com, robh+dt@kernel.org, agross@kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, quic_jackp@quicinc.com, quic_plai@quicinc.com References: <20221223233200.26089-1-quic_wcheng@quicinc.com> <20221223233200.26089-9-quic_wcheng@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 24/12/2022 12:13, Dmitry Baryshkov wrote: >> @@ -1468,6 +1469,9 @@ static void dwc3_get_properties(struct dwc3 *dwc) >> */ >> tx_fifo_resize_max_num = 6; >> >> + /* default to a single XHCI interrupter */ >> + num_hc_interrupters = 1; >> + >> dwc->maximum_speed = usb_get_maximum_speed(dev); >> dwc->max_ssp_rate = usb_get_maximum_ssp_rate(dev); >> dwc->dr_mode = usb_get_dr_mode(dev); >> @@ -1511,6 +1515,12 @@ static void dwc3_get_properties(struct dwc3 *dwc) >> &tx_thr_num_pkt_prd); >> device_property_read_u8(dev, "snps,tx-max-burst-prd", >> &tx_max_burst_prd); >> + device_property_read_u8(dev, "snps,num-hc-interrupters", >> + &num_hc_interrupters); > > bindings change? Undocumented bindings change :( Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2EB84C3DA79 for ; Mon, 26 Dec 2022 12:29:28 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 24B316040; Mon, 26 Dec 2022 13:28:36 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 24B316040 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1672057766; bh=k/rTNjA4h1zilOkfKIJ30N4Cd8KTHgFNcT0W1vl9YFs=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=lXrWvNgwTDkgWucMxWrNTI4nFVOa6nmxF7GFPP6w+X6k//m/RLF5Uc5wcWheKTSh2 Oxik+f7gvupeCKH8IxTHKeP5T0vuoZoZgw4oKxrNsjhhZs1DAHjaYBopyIRF0krFIr P0SNyUJz/afVU7whMPbGPuCINzMsgxo3gkwdP+aU= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id BE53BF8027B; Mon, 26 Dec 2022 13:28:35 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 15C96F802A0; Mon, 26 Dec 2022 13:28:34 +0100 (CET) Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id B521CF800F0 for ; Mon, 26 Dec 2022 13:28:30 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz B521CF800F0 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=EGt0tVqC Received: by mail-lf1-x12f.google.com with SMTP id p36so15743248lfa.12 for ; Mon, 26 Dec 2022 04:28:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=o9VsUfbXpnBl5i0jqV0GHVfHb2fzN94uWi/WF4L80bQ=; b=EGt0tVqCcxNMIPHFjFmmSJmtfepupOLGU6WfTr20N1cfbTWvjad6h6ZyUMyzbXS0dO JwBOXpGJdV3w+qcgu5Rtn5uwfbndTK2SGADbeGhlzTuVf7uZXZEx8VcwS+kZjHfqtDIP 0tWkhL8h3pGUklT9nVvyHj4zjSRCy5xxV+pU7mEF8fHn8n2Pzbx/vNAJUk9eKyE4MOv6 /ROyOZvwmpzEkhxUOBbEQKal3v1MhUJFVTJoQnI2Ek26xL8C3MZk9lT2MbSWWw3qhtGc hcLQCFFEXXWcAowwQGVoYha+nXJpA+xlunoGYxSaFci2gOGQuDyynfLOtalsc1HLCyM3 GllA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=o9VsUfbXpnBl5i0jqV0GHVfHb2fzN94uWi/WF4L80bQ=; b=Cf4KdHhSUpUNQ8DX1tMZ9ZbAyIXbGlCCZh+rzJ3MVJ4K+FWtjLImvAzdoPQmJ6bPPv nwYM5ITKut7xA61cw5SPhC2fpHuDIAde3D7oOm5vozUqYw92NTUgb4ygMGMpoKGE2Mxp dWAAbFPmwmxouED9c5bdENGUeGcxxSKOfPu/AgG2iGRYa86ZfU+cCQ+B3GEkdzFHUjHR d8tXyIgBHOq5krEcm8uh6DlTkGRqGYfcxC1pO5u2XxWQA6X3wgG/3ED6pwt44C7AyraD l3Rh7VYClOQzMyOavgwfYO/blyrw3qW+MkTRtXfif4S2Pr+3vPPMceM38ERXKRD17AGE gmdQ== X-Gm-Message-State: AFqh2kobgNxjXbmYFEdROW+Cp6ENh0TBl1M8ZVlx4OiwbjkGlQrpZfE1 302YrVJnwZV5wCn1VwEPfOm8Dg== X-Google-Smtp-Source: AMrXdXt+SG75PQYPAqAyfLTtW57mlbWYpcItg3HmguNy4OAxCp6Z8zw35YRYWDPCc637ckI/5JBHRQ== X-Received: by 2002:a05:6512:6d0:b0:4b5:d:efb2 with SMTP id u16-20020a05651206d000b004b5000defb2mr5311841lff.14.1672057708771; Mon, 26 Dec 2022 04:28:28 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id a11-20020ac25e6b000000b004cafd013f54sm1174058lfr.118.2022.12.26.04.28.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Dec 2022 04:28:28 -0800 (PST) Message-ID: <9e93a28b-c735-5250-34d0-9b41c0f488b5@linaro.org> Date: Mon, 26 Dec 2022 13:28:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [RFC PATCH 08/14] usb: dwc3: Add DT parameter to specify maximum number of interrupters Content-Language: en-US To: Dmitry Baryshkov , Wesley Cheng References: <20221223233200.26089-1-quic_wcheng@quicinc.com> <20221223233200.26089-9-quic_wcheng@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-usb@vger.kernel.org, bgoswami@quicinc.com, mathias.nyman@intel.com, gregkh@linuxfoundation.org, andersson@kernel.org, tiwai@suse.com, lgirdwood@gmail.com, robh+dt@kernel.org, broonie@kernel.org, srinivas.kandagatla@linaro.org, agross@kernel.org, krzysztof.kozlowski+dt@linaro.org, Thinh.Nguyen@synopsys.com, quic_plai@quicinc.com, linux-kernel@vger.kernel.org, quic_jackp@quicinc.com Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 24/12/2022 12:13, Dmitry Baryshkov wrote: >> @@ -1468,6 +1469,9 @@ static void dwc3_get_properties(struct dwc3 *dwc) >> */ >> tx_fifo_resize_max_num = 6; >> >> + /* default to a single XHCI interrupter */ >> + num_hc_interrupters = 1; >> + >> dwc->maximum_speed = usb_get_maximum_speed(dev); >> dwc->max_ssp_rate = usb_get_maximum_ssp_rate(dev); >> dwc->dr_mode = usb_get_dr_mode(dev); >> @@ -1511,6 +1515,12 @@ static void dwc3_get_properties(struct dwc3 *dwc) >> &tx_thr_num_pkt_prd); >> device_property_read_u8(dev, "snps,tx-max-burst-prd", >> &tx_max_burst_prd); >> + device_property_read_u8(dev, "snps,num-hc-interrupters", >> + &num_hc_interrupters); > > bindings change? Undocumented bindings change :( Best regards, Krzysztof