* [PATCH] drm/mgag200: make a const array static, makes object smaller
@ 2021-02-04 18:17 ` Colin King
0 siblings, 0 replies; 6+ messages in thread
From: Colin King @ 2021-02-04 18:17 UTC (permalink / raw)
To: Dave Airlie, Thomas Zimmermann, David Airlie, Daniel Vetter, dri-devel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Don't populate the const array m_div_val on the stack but instead make
it static. Makes the object code smaller by 29 bytes:
Before:
text data bss dec hex filename
34736 4552 0 39288 9978 drivers/gpu/drm/mgag200/mgag200_mode.o
After:
text data bss dec hex filename
34625 4616 0 39241 9949 drivers/gpu/drm/mgag200/mgag200_mode.o
(gcc version 10.2.0)
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/gpu/drm/mgag200/mgag200_mode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c b/drivers/gpu/drm/mgag200/mgag200_mode.c
index 1dfc42170059..27f33af09798 100644
--- a/drivers/gpu/drm/mgag200/mgag200_mode.c
+++ b/drivers/gpu/drm/mgag200/mgag200_mode.c
@@ -712,7 +712,7 @@ static int mga_g200er_set_plls(struct mga_device *mdev, long clock)
unsigned int p, m, n;
unsigned int computed, vco;
int tmp;
- const unsigned int m_div_val[] = { 1, 2, 4, 8 };
+ static const unsigned int m_div_val[] = { 1, 2, 4, 8 };
m = n = p = 0;
vcomax = 1488000;
--
2.29.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] drm/mgag200: make a const array static, makes object smaller
@ 2021-02-04 18:17 ` Colin King
0 siblings, 0 replies; 6+ messages in thread
From: Colin King @ 2021-02-04 18:17 UTC (permalink / raw)
To: Dave Airlie, Thomas Zimmermann, David Airlie, Daniel Vetter, dri-devel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Don't populate the const array m_div_val on the stack but instead make
it static. Makes the object code smaller by 29 bytes:
Before:
text data bss dec hex filename
34736 4552 0 39288 9978 drivers/gpu/drm/mgag200/mgag200_mode.o
After:
text data bss dec hex filename
34625 4616 0 39241 9949 drivers/gpu/drm/mgag200/mgag200_mode.o
(gcc version 10.2.0)
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/gpu/drm/mgag200/mgag200_mode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c b/drivers/gpu/drm/mgag200/mgag200_mode.c
index 1dfc42170059..27f33af09798 100644
--- a/drivers/gpu/drm/mgag200/mgag200_mode.c
+++ b/drivers/gpu/drm/mgag200/mgag200_mode.c
@@ -712,7 +712,7 @@ static int mga_g200er_set_plls(struct mga_device *mdev, long clock)
unsigned int p, m, n;
unsigned int computed, vco;
int tmp;
- const unsigned int m_div_val[] = { 1, 2, 4, 8 };
+ static const unsigned int m_div_val[] = { 1, 2, 4, 8 };
m = n = p = 0;
vcomax = 1488000;
--
2.29.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] drm/mgag200: make a const array static, makes object smaller
@ 2021-02-04 18:17 ` Colin King
0 siblings, 0 replies; 6+ messages in thread
From: Colin King @ 2021-02-04 18:17 UTC (permalink / raw)
To: Dave Airlie, Thomas Zimmermann, David Airlie, Daniel Vetter, dri-devel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Don't populate the const array m_div_val on the stack but instead make
it static. Makes the object code smaller by 29 bytes:
Before:
text data bss dec hex filename
34736 4552 0 39288 9978 drivers/gpu/drm/mgag200/mgag200_mode.o
After:
text data bss dec hex filename
34625 4616 0 39241 9949 drivers/gpu/drm/mgag200/mgag200_mode.o
(gcc version 10.2.0)
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/gpu/drm/mgag200/mgag200_mode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c b/drivers/gpu/drm/mgag200/mgag200_mode.c
index 1dfc42170059..27f33af09798 100644
--- a/drivers/gpu/drm/mgag200/mgag200_mode.c
+++ b/drivers/gpu/drm/mgag200/mgag200_mode.c
@@ -712,7 +712,7 @@ static int mga_g200er_set_plls(struct mga_device *mdev, long clock)
unsigned int p, m, n;
unsigned int computed, vco;
int tmp;
- const unsigned int m_div_val[] = { 1, 2, 4, 8 };
+ static const unsigned int m_div_val[] = { 1, 2, 4, 8 };
m = n = p = 0;
vcomax = 1488000;
--
2.29.2
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/mgag200: make a const array static, makes object smaller
2021-02-04 18:17 ` Colin King
(?)
@ 2021-02-04 18:27 ` Thomas Zimmermann
-1 siblings, 0 replies; 6+ messages in thread
From: Thomas Zimmermann @ 2021-02-04 18:27 UTC (permalink / raw)
To: Colin King, Dave Airlie, David Airlie, Daniel Vetter, dri-devel
Cc: kernel-janitors, linux-kernel
[-- Attachment #1.1: Type: text/plain, Size: 1953 bytes --]
Hi
Am 04.02.21 um 19:17 schrieb Colin King:
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate the const array m_div_val on the stack but instead make
> it static. Makes the object code smaller by 29 bytes:
>
> Before:
> text data bss dec hex filename
> 34736 4552 0 39288 9978 drivers/gpu/drm/mgag200/mgag200_mode.o
>
> After:
> text data bss dec hex filename
> 34625 4616 0 39241 9949 drivers/gpu/drm/mgag200/mgag200_mode.o
>
> (gcc version 10.2.0)
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Very nice. I'm actually surprised that the compiler doesn't figure this
out automatically. When I once tested this (in userspace) it did so.
Maybe the kernel is different?
For style reasons, I would have moved the static definition to the top
of the function; before the variable declarations. In any case:
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
If I don't here from you, I'll merge the patch soonish.
Best regards
Thomas
> ---
> drivers/gpu/drm/mgag200/mgag200_mode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c b/drivers/gpu/drm/mgag200/mgag200_mode.c
> index 1dfc42170059..27f33af09798 100644
> --- a/drivers/gpu/drm/mgag200/mgag200_mode.c
> +++ b/drivers/gpu/drm/mgag200/mgag200_mode.c
> @@ -712,7 +712,7 @@ static int mga_g200er_set_plls(struct mga_device *mdev, long clock)
> unsigned int p, m, n;
> unsigned int computed, vco;
> int tmp;
> - const unsigned int m_div_val[] = { 1, 2, 4, 8 };
> + static const unsigned int m_div_val[] = { 1, 2, 4, 8 };
>
> m = n = p = 0;
> vcomax = 1488000;
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/mgag200: make a const array static, makes object smaller
@ 2021-02-04 18:27 ` Thomas Zimmermann
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Zimmermann @ 2021-02-04 18:27 UTC (permalink / raw)
To: Colin King, Dave Airlie, David Airlie, Daniel Vetter, dri-devel
Cc: kernel-janitors, linux-kernel
[-- Attachment #1.1: Type: text/plain, Size: 1953 bytes --]
Hi
Am 04.02.21 um 19:17 schrieb Colin King:
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate the const array m_div_val on the stack but instead make
> it static. Makes the object code smaller by 29 bytes:
>
> Before:
> text data bss dec hex filename
> 34736 4552 0 39288 9978 drivers/gpu/drm/mgag200/mgag200_mode.o
>
> After:
> text data bss dec hex filename
> 34625 4616 0 39241 9949 drivers/gpu/drm/mgag200/mgag200_mode.o
>
> (gcc version 10.2.0)
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Very nice. I'm actually surprised that the compiler doesn't figure this
out automatically. When I once tested this (in userspace) it did so.
Maybe the kernel is different?
For style reasons, I would have moved the static definition to the top
of the function; before the variable declarations. In any case:
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
If I don't here from you, I'll merge the patch soonish.
Best regards
Thomas
> ---
> drivers/gpu/drm/mgag200/mgag200_mode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c b/drivers/gpu/drm/mgag200/mgag200_mode.c
> index 1dfc42170059..27f33af09798 100644
> --- a/drivers/gpu/drm/mgag200/mgag200_mode.c
> +++ b/drivers/gpu/drm/mgag200/mgag200_mode.c
> @@ -712,7 +712,7 @@ static int mga_g200er_set_plls(struct mga_device *mdev, long clock)
> unsigned int p, m, n;
> unsigned int computed, vco;
> int tmp;
> - const unsigned int m_div_val[] = { 1, 2, 4, 8 };
> + static const unsigned int m_div_val[] = { 1, 2, 4, 8 };
>
> m = n = p = 0;
> vcomax = 1488000;
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/mgag200: make a const array static, makes object smaller
@ 2021-02-04 18:27 ` Thomas Zimmermann
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Zimmermann @ 2021-02-04 18:27 UTC (permalink / raw)
To: Colin King, Dave Airlie, David Airlie, Daniel Vetter, dri-devel
Cc: kernel-janitors, linux-kernel
[-- Attachment #1.1.1: Type: text/plain, Size: 1953 bytes --]
Hi
Am 04.02.21 um 19:17 schrieb Colin King:
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate the const array m_div_val on the stack but instead make
> it static. Makes the object code smaller by 29 bytes:
>
> Before:
> text data bss dec hex filename
> 34736 4552 0 39288 9978 drivers/gpu/drm/mgag200/mgag200_mode.o
>
> After:
> text data bss dec hex filename
> 34625 4616 0 39241 9949 drivers/gpu/drm/mgag200/mgag200_mode.o
>
> (gcc version 10.2.0)
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Very nice. I'm actually surprised that the compiler doesn't figure this
out automatically. When I once tested this (in userspace) it did so.
Maybe the kernel is different?
For style reasons, I would have moved the static definition to the top
of the function; before the variable declarations. In any case:
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
If I don't here from you, I'll merge the patch soonish.
Best regards
Thomas
> ---
> drivers/gpu/drm/mgag200/mgag200_mode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c b/drivers/gpu/drm/mgag200/mgag200_mode.c
> index 1dfc42170059..27f33af09798 100644
> --- a/drivers/gpu/drm/mgag200/mgag200_mode.c
> +++ b/drivers/gpu/drm/mgag200/mgag200_mode.c
> @@ -712,7 +712,7 @@ static int mga_g200er_set_plls(struct mga_device *mdev, long clock)
> unsigned int p, m, n;
> unsigned int computed, vco;
> int tmp;
> - const unsigned int m_div_val[] = { 1, 2, 4, 8 };
> + static const unsigned int m_div_val[] = { 1, 2, 4, 8 };
>
> m = n = p = 0;
> vcomax = 1488000;
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-02-04 18:30 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-04 18:17 [PATCH] drm/mgag200: make a const array static, makes object smaller Colin King
2021-02-04 18:17 ` Colin King
2021-02-04 18:17 ` Colin King
2021-02-04 18:27 ` Thomas Zimmermann
2021-02-04 18:27 ` Thomas Zimmermann
2021-02-04 18:27 ` Thomas Zimmermann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.