From: Jens Axboe <axboe@kernel.dk>
To: Ming Lei <ming.lei@redhat.com>
Cc: linux-block@vger.kernel.org, stable@vger.kernel.org,
Omar Sandoval <osandov@fb.com>
Subject: Re: [PATCH V2] blk-mq: avoid to starve tag allocation after allocation process migrates
Date: Tue, 22 May 2018 14:20:37 -0600 [thread overview]
Message-ID: <9ea0bf13-8891-0214-d735-2088827b2937@kernel.dk> (raw)
In-Reply-To: <20180519074406.6045-1-ming.lei@redhat.com>
On 5/19/18 1:44 AM, Ming Lei wrote:
> When the allocation process is scheduled back and the mapped hw queue is
> changed, do one extra wake up on orignal queue for compensating wake up
> miss, so other allocations on the orignal queue won't be starved.
>
> This patch fixes one request allocation hang issue, which can be
> triggered easily in case of very low nr_request.
Can you explain what the actual bug is? The commit message doesn't
really say, it just explains what the code change does. What wake up
miss?
--
Jens Axboe
next prev parent reply other threads:[~2018-05-22 20:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-19 7:44 [PATCH V2] blk-mq: avoid to starve tag allocation after allocation process migrates Ming Lei
2018-05-22 20:20 ` Jens Axboe [this message]
2018-05-23 0:22 ` Ming Lei
2018-05-23 3:35 ` Jens Axboe
2018-05-23 3:59 ` Jens Axboe
2018-05-23 9:32 ` Ming Lei
2018-05-23 17:48 ` Omar Sandoval
2018-05-23 22:09 ` Ming Lei
2018-05-23 22:19 ` Jens Axboe
2018-05-23 22:56 ` Ming Lei
2018-05-23 22:47 ` Omar Sandoval
2018-05-23 17:40 ` Omar Sandoval
2018-05-24 2:20 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ea0bf13-8891-0214-d735-2088827b2937@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=osandov@fb.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.