From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: "Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>,
xen-devel@lists.xenproject.org
Cc: Jan Beulich <jbeulich@suse.com>,
Simon Gaiser <simon@invisiblethingslab.com>,
Juergen Gross <jgross@suse.com>,
Stefano Stabellini <sstabellini@kernel.org>,
YueHaibing <yuehaibing@huawei.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] xen-pciback: optionally allow interrupt enable flag writes
Date: Mon, 13 Jan 2020 16:25:02 -0500 [thread overview]
Message-ID: <9ea42829-6a1a-09eb-9d59-67a0487980b6@oracle.com> (raw)
In-Reply-To: <20200111034347.5270-1-marmarek@invisiblethingslab.com>
On 1/10/20 10:43 PM, Marek Marczykowski-Górecki wrote:
> @@ -117,6 +117,24 @@ static int command_write(struct pci_dev *dev, int offset, u16 value, void *data)
> pci_clear_mwi(dev);
> }
>
> + if (dev_data && dev_data->allow_interrupt_control) {
> + if ((cmd->val ^ val) & PCI_COMMAND_INTX_DISABLE) {
> + if (value & PCI_COMMAND_INTX_DISABLE) {
> + pci_intx(dev, 0);
> + } else {
> + /* Do not allow enabling INTx together with MSI or MSI-X. */
> + switch (xen_pcibk_get_interrupt_type(dev)) {
> + case INTERRUPT_TYPE_NONE:
> + case INTERRUPT_TYPE_INTX:
> + pci_intx(dev, 1);
If INTERRUPT_TYPE_INTX , why call pci_intx(1)?
(I think I asked this last time as well).
-boris
WARNING: multiple messages have this Message-ID (diff)
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: "Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>,
xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
Stefano Stabellini <sstabellini@kernel.org>,
YueHaibing <yuehaibing@huawei.com>,
open list <linux-kernel@vger.kernel.org>,
Simon Gaiser <simon@invisiblethingslab.com>,
Jan Beulich <jbeulich@suse.com>
Subject: Re: [Xen-devel] [PATCH v3] xen-pciback: optionally allow interrupt enable flag writes
Date: Mon, 13 Jan 2020 16:25:02 -0500 [thread overview]
Message-ID: <9ea42829-6a1a-09eb-9d59-67a0487980b6@oracle.com> (raw)
In-Reply-To: <20200111034347.5270-1-marmarek@invisiblethingslab.com>
On 1/10/20 10:43 PM, Marek Marczykowski-Górecki wrote:
> @@ -117,6 +117,24 @@ static int command_write(struct pci_dev *dev, int offset, u16 value, void *data)
> pci_clear_mwi(dev);
> }
>
> + if (dev_data && dev_data->allow_interrupt_control) {
> + if ((cmd->val ^ val) & PCI_COMMAND_INTX_DISABLE) {
> + if (value & PCI_COMMAND_INTX_DISABLE) {
> + pci_intx(dev, 0);
> + } else {
> + /* Do not allow enabling INTx together with MSI or MSI-X. */
> + switch (xen_pcibk_get_interrupt_type(dev)) {
> + case INTERRUPT_TYPE_NONE:
> + case INTERRUPT_TYPE_INTX:
> + pci_intx(dev, 1);
If INTERRUPT_TYPE_INTX , why call pci_intx(1)?
(I think I asked this last time as well).
-boris
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2020-01-13 21:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-11 3:43 [PATCH v3] xen-pciback: optionally allow interrupt enable flag writes Marek Marczykowski-Górecki
2020-01-11 3:43 ` [Xen-devel] " Marek Marczykowski-Górecki
2020-01-13 21:25 ` Boris Ostrovsky [this message]
2020-01-13 21:25 ` Boris Ostrovsky
2020-01-13 21:39 ` Marek Marczykowski-Górecki
2020-01-13 21:39 ` [Xen-devel] " Marek Marczykowski-Górecki
[not found] <202001112351.gy4c3aUU%lkp@intel.com>
2020-01-13 17:11 ` Nick Desaulniers
2020-01-13 17:11 ` Nick Desaulniers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ea42829-6a1a-09eb-9d59-67a0487980b6@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=jbeulich@suse.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marmarek@invisiblethingslab.com \
--cc=simon@invisiblethingslab.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.