All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v4] thermal: mediatek: add sensors-support
@ 2021-06-08 15:45 ` Frank Wunderlich
  0 siblings, 0 replies; 14+ messages in thread
From: Frank Wunderlich @ 2021-06-08 15:45 UTC (permalink / raw)
  To: linux-mediatek
  Cc: Frank Wunderlich, Daniel Lezcano, Amit Kucheria,
	Matthias Brugger, linux-pm, linux-arm-kernel, linux-kernel

From: Frank Wunderlich <frank-w@public-files.de>

add HWMON-support to mediateks thermal driver to allow lm-sensors
userspace tools read soc temperature

Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
---
v4: change message to dev_warn as suggested by matthias
v3: drop no_hwmon
v2: drop ifdef and used devm_thermal_add_hwmon_sysfs
---
 drivers/thermal/mtk_thermal.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mtk_thermal.c
index 97e8678ccf0e..ede94eadddda 100644
--- a/drivers/thermal/mtk_thermal.c
+++ b/drivers/thermal/mtk_thermal.c
@@ -23,6 +23,8 @@
 #include <linux/reset.h>
 #include <linux/types.h>
 
+#include "thermal_hwmon.h"
+
 /* AUXADC Registers */
 #define AUXADC_CON1_SET_V	0x008
 #define AUXADC_CON1_CLR_V	0x00c
@@ -1087,6 +1089,10 @@ static int mtk_thermal_probe(struct platform_device *pdev)
 		goto err_disable_clk_peri_therm;
 	}
 
+	ret = devm_thermal_add_hwmon_sysfs(tzdev);
+	if (ret)
+		dev_warn(&pdev->dev, "error in thermal_add_hwmon_sysfs");
+
 	return 0;
 
 err_disable_clk_peri_therm:
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH v4] thermal: mediatek: add sensors-support
@ 2021-06-08 15:45 ` Frank Wunderlich
  0 siblings, 0 replies; 14+ messages in thread
From: Frank Wunderlich @ 2021-06-08 15:45 UTC (permalink / raw)
  To: linux-mediatek
  Cc: Frank Wunderlich, Daniel Lezcano, Amit Kucheria,
	Matthias Brugger, linux-pm, linux-arm-kernel, linux-kernel

From: Frank Wunderlich <frank-w@public-files.de>

add HWMON-support to mediateks thermal driver to allow lm-sensors
userspace tools read soc temperature

Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
---
v4: change message to dev_warn as suggested by matthias
v3: drop no_hwmon
v2: drop ifdef and used devm_thermal_add_hwmon_sysfs
---
 drivers/thermal/mtk_thermal.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mtk_thermal.c
index 97e8678ccf0e..ede94eadddda 100644
--- a/drivers/thermal/mtk_thermal.c
+++ b/drivers/thermal/mtk_thermal.c
@@ -23,6 +23,8 @@
 #include <linux/reset.h>
 #include <linux/types.h>
 
+#include "thermal_hwmon.h"
+
 /* AUXADC Registers */
 #define AUXADC_CON1_SET_V	0x008
 #define AUXADC_CON1_CLR_V	0x00c
@@ -1087,6 +1089,10 @@ static int mtk_thermal_probe(struct platform_device *pdev)
 		goto err_disable_clk_peri_therm;
 	}
 
+	ret = devm_thermal_add_hwmon_sysfs(tzdev);
+	if (ret)
+		dev_warn(&pdev->dev, "error in thermal_add_hwmon_sysfs");
+
 	return 0;
 
 err_disable_clk_peri_therm:
-- 
2.25.1


_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH v4] thermal: mediatek: add sensors-support
@ 2021-06-08 15:45 ` Frank Wunderlich
  0 siblings, 0 replies; 14+ messages in thread
From: Frank Wunderlich @ 2021-06-08 15:45 UTC (permalink / raw)
  To: linux-mediatek
  Cc: Frank Wunderlich, Daniel Lezcano, Amit Kucheria,
	Matthias Brugger, linux-pm, linux-arm-kernel, linux-kernel

From: Frank Wunderlich <frank-w@public-files.de>

add HWMON-support to mediateks thermal driver to allow lm-sensors
userspace tools read soc temperature

Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
---
v4: change message to dev_warn as suggested by matthias
v3: drop no_hwmon
v2: drop ifdef and used devm_thermal_add_hwmon_sysfs
---
 drivers/thermal/mtk_thermal.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mtk_thermal.c
index 97e8678ccf0e..ede94eadddda 100644
--- a/drivers/thermal/mtk_thermal.c
+++ b/drivers/thermal/mtk_thermal.c
@@ -23,6 +23,8 @@
 #include <linux/reset.h>
 #include <linux/types.h>
 
+#include "thermal_hwmon.h"
+
 /* AUXADC Registers */
 #define AUXADC_CON1_SET_V	0x008
 #define AUXADC_CON1_CLR_V	0x00c
@@ -1087,6 +1089,10 @@ static int mtk_thermal_probe(struct platform_device *pdev)
 		goto err_disable_clk_peri_therm;
 	}
 
+	ret = devm_thermal_add_hwmon_sysfs(tzdev);
+	if (ret)
+		dev_warn(&pdev->dev, "error in thermal_add_hwmon_sysfs");
+
 	return 0;
 
 err_disable_clk_peri_therm:
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* Re: [PATCH v4] thermal: mediatek: add sensors-support
  2021-06-08 15:45 ` Frank Wunderlich
  (?)
@ 2021-06-09  8:09   ` Matthias Brugger
  -1 siblings, 0 replies; 14+ messages in thread
From: Matthias Brugger @ 2021-06-09  8:09 UTC (permalink / raw)
  To: Frank Wunderlich, linux-mediatek
  Cc: Frank Wunderlich, Daniel Lezcano, Amit Kucheria, linux-pm,
	linux-arm-kernel, linux-kernel



On 08/06/2021 17:45, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@public-files.de>
> 
> add HWMON-support to mediateks thermal driver to allow lm-sensors
> userspace tools read soc temperature
> 
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>

Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>

> ---
> v4: change message to dev_warn as suggested by matthias
> v3: drop no_hwmon
> v2: drop ifdef and used devm_thermal_add_hwmon_sysfs
> ---
>  drivers/thermal/mtk_thermal.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mtk_thermal.c
> index 97e8678ccf0e..ede94eadddda 100644
> --- a/drivers/thermal/mtk_thermal.c
> +++ b/drivers/thermal/mtk_thermal.c
> @@ -23,6 +23,8 @@
>  #include <linux/reset.h>
>  #include <linux/types.h>
>  
> +#include "thermal_hwmon.h"
> +
>  /* AUXADC Registers */
>  #define AUXADC_CON1_SET_V	0x008
>  #define AUXADC_CON1_CLR_V	0x00c
> @@ -1087,6 +1089,10 @@ static int mtk_thermal_probe(struct platform_device *pdev)
>  		goto err_disable_clk_peri_therm;
>  	}
>  
> +	ret = devm_thermal_add_hwmon_sysfs(tzdev);
> +	if (ret)
> +		dev_warn(&pdev->dev, "error in thermal_add_hwmon_sysfs");
> +
>  	return 0;
>  
>  err_disable_clk_peri_therm:
> 

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH v4] thermal: mediatek: add sensors-support
@ 2021-06-09  8:09   ` Matthias Brugger
  0 siblings, 0 replies; 14+ messages in thread
From: Matthias Brugger @ 2021-06-09  8:09 UTC (permalink / raw)
  To: Frank Wunderlich, linux-mediatek
  Cc: Frank Wunderlich, Daniel Lezcano, Amit Kucheria, linux-pm,
	linux-arm-kernel, linux-kernel



On 08/06/2021 17:45, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@public-files.de>
> 
> add HWMON-support to mediateks thermal driver to allow lm-sensors
> userspace tools read soc temperature
> 
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>

Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>

> ---
> v4: change message to dev_warn as suggested by matthias
> v3: drop no_hwmon
> v2: drop ifdef and used devm_thermal_add_hwmon_sysfs
> ---
>  drivers/thermal/mtk_thermal.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mtk_thermal.c
> index 97e8678ccf0e..ede94eadddda 100644
> --- a/drivers/thermal/mtk_thermal.c
> +++ b/drivers/thermal/mtk_thermal.c
> @@ -23,6 +23,8 @@
>  #include <linux/reset.h>
>  #include <linux/types.h>
>  
> +#include "thermal_hwmon.h"
> +
>  /* AUXADC Registers */
>  #define AUXADC_CON1_SET_V	0x008
>  #define AUXADC_CON1_CLR_V	0x00c
> @@ -1087,6 +1089,10 @@ static int mtk_thermal_probe(struct platform_device *pdev)
>  		goto err_disable_clk_peri_therm;
>  	}
>  
> +	ret = devm_thermal_add_hwmon_sysfs(tzdev);
> +	if (ret)
> +		dev_warn(&pdev->dev, "error in thermal_add_hwmon_sysfs");
> +
>  	return 0;
>  
>  err_disable_clk_peri_therm:
> 

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH v4] thermal: mediatek: add sensors-support
@ 2021-06-09  8:09   ` Matthias Brugger
  0 siblings, 0 replies; 14+ messages in thread
From: Matthias Brugger @ 2021-06-09  8:09 UTC (permalink / raw)
  To: Frank Wunderlich, linux-mediatek
  Cc: Frank Wunderlich, Daniel Lezcano, Amit Kucheria, linux-pm,
	linux-arm-kernel, linux-kernel



On 08/06/2021 17:45, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@public-files.de>
> 
> add HWMON-support to mediateks thermal driver to allow lm-sensors
> userspace tools read soc temperature
> 
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>

Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>

> ---
> v4: change message to dev_warn as suggested by matthias
> v3: drop no_hwmon
> v2: drop ifdef and used devm_thermal_add_hwmon_sysfs
> ---
>  drivers/thermal/mtk_thermal.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mtk_thermal.c
> index 97e8678ccf0e..ede94eadddda 100644
> --- a/drivers/thermal/mtk_thermal.c
> +++ b/drivers/thermal/mtk_thermal.c
> @@ -23,6 +23,8 @@
>  #include <linux/reset.h>
>  #include <linux/types.h>
>  
> +#include "thermal_hwmon.h"
> +
>  /* AUXADC Registers */
>  #define AUXADC_CON1_SET_V	0x008
>  #define AUXADC_CON1_CLR_V	0x00c
> @@ -1087,6 +1089,10 @@ static int mtk_thermal_probe(struct platform_device *pdev)
>  		goto err_disable_clk_peri_therm;
>  	}
>  
> +	ret = devm_thermal_add_hwmon_sysfs(tzdev);
> +	if (ret)
> +		dev_warn(&pdev->dev, "error in thermal_add_hwmon_sysfs");
> +
>  	return 0;
>  
>  err_disable_clk_peri_therm:
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Aw: Re: [PATCH v4] thermal: mediatek: add sensors-support
  2021-06-09  8:09   ` Matthias Brugger
  (?)
@ 2021-06-28 10:05     ` Frank Wunderlich
  -1 siblings, 0 replies; 14+ messages in thread
From: Frank Wunderlich @ 2021-06-28 10:05 UTC (permalink / raw)
  To: Daniel Lezcano
  Cc: Matthias Brugger, Frank Wunderlich, linux-mediatek,
	Amit Kucheria, linux-pm, linux-arm-kernel, linux-kernel

Hi,

A gentle ping as it is reviewed but not yet visible in thermal tree [1] i guess it should do,right?

regards Frank

[1] https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git/log/?h=thermal/next

> Gesendet: Mittwoch, 09. Juni 2021 um 10:09 Uhr
> Von: "Matthias Brugger" <matthias.bgg@gmail.com>
> An: "Frank Wunderlich" <linux@fw-web.de>, linux-mediatek@lists.infradead.org
> Cc: "Frank Wunderlich" <frank-w@public-files.de>, "Daniel Lezcano" <daniel.lezcano@linaro.org>, "Amit Kucheria" <amitk@kernel.org>, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
> Betreff: Re: [PATCH v4] thermal: mediatek: add sensors-support
>
>
>
> On 08/06/2021 17:45, Frank Wunderlich wrote:
> > From: Frank Wunderlich <frank-w@public-files.de>
> >
> > add HWMON-support to mediateks thermal driver to allow lm-sensors
> > userspace tools read soc temperature
> >
> > Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
>
> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
>
> > ---
> > v4: change message to dev_warn as suggested by matthias
> > v3: drop no_hwmon
> > v2: drop ifdef and used devm_thermal_add_hwmon_sysfs
> > ---
> >  drivers/thermal/mtk_thermal.c | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mtk_thermal.c
> > index 97e8678ccf0e..ede94eadddda 100644
> > --- a/drivers/thermal/mtk_thermal.c
> > +++ b/drivers/thermal/mtk_thermal.c
> > @@ -23,6 +23,8 @@
> >  #include <linux/reset.h>
> >  #include <linux/types.h>
> >
> > +#include "thermal_hwmon.h"
> > +
> >  /* AUXADC Registers */
> >  #define AUXADC_CON1_SET_V	0x008
> >  #define AUXADC_CON1_CLR_V	0x00c
> > @@ -1087,6 +1089,10 @@ static int mtk_thermal_probe(struct platform_device *pdev)
> >  		goto err_disable_clk_peri_therm;
> >  	}
> >
> > +	ret = devm_thermal_add_hwmon_sysfs(tzdev);
> > +	if (ret)
> > +		dev_warn(&pdev->dev, "error in thermal_add_hwmon_sysfs");
> > +
> >  	return 0;
> >
> >  err_disable_clk_peri_therm:
> >
>

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Aw: Re: [PATCH v4] thermal: mediatek: add sensors-support
@ 2021-06-28 10:05     ` Frank Wunderlich
  0 siblings, 0 replies; 14+ messages in thread
From: Frank Wunderlich @ 2021-06-28 10:05 UTC (permalink / raw)
  To: Daniel Lezcano
  Cc: Matthias Brugger, Frank Wunderlich, linux-mediatek,
	Amit Kucheria, linux-pm, linux-arm-kernel, linux-kernel

Hi,

A gentle ping as it is reviewed but not yet visible in thermal tree [1] i guess it should do,right?

regards Frank

[1] https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git/log/?h=thermal/next

> Gesendet: Mittwoch, 09. Juni 2021 um 10:09 Uhr
> Von: "Matthias Brugger" <matthias.bgg@gmail.com>
> An: "Frank Wunderlich" <linux@fw-web.de>, linux-mediatek@lists.infradead.org
> Cc: "Frank Wunderlich" <frank-w@public-files.de>, "Daniel Lezcano" <daniel.lezcano@linaro.org>, "Amit Kucheria" <amitk@kernel.org>, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
> Betreff: Re: [PATCH v4] thermal: mediatek: add sensors-support
>
>
>
> On 08/06/2021 17:45, Frank Wunderlich wrote:
> > From: Frank Wunderlich <frank-w@public-files.de>
> >
> > add HWMON-support to mediateks thermal driver to allow lm-sensors
> > userspace tools read soc temperature
> >
> > Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
>
> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
>
> > ---
> > v4: change message to dev_warn as suggested by matthias
> > v3: drop no_hwmon
> > v2: drop ifdef and used devm_thermal_add_hwmon_sysfs
> > ---
> >  drivers/thermal/mtk_thermal.c | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mtk_thermal.c
> > index 97e8678ccf0e..ede94eadddda 100644
> > --- a/drivers/thermal/mtk_thermal.c
> > +++ b/drivers/thermal/mtk_thermal.c
> > @@ -23,6 +23,8 @@
> >  #include <linux/reset.h>
> >  #include <linux/types.h>
> >
> > +#include "thermal_hwmon.h"
> > +
> >  /* AUXADC Registers */
> >  #define AUXADC_CON1_SET_V	0x008
> >  #define AUXADC_CON1_CLR_V	0x00c
> > @@ -1087,6 +1089,10 @@ static int mtk_thermal_probe(struct platform_device *pdev)
> >  		goto err_disable_clk_peri_therm;
> >  	}
> >
> > +	ret = devm_thermal_add_hwmon_sysfs(tzdev);
> > +	if (ret)
> > +		dev_warn(&pdev->dev, "error in thermal_add_hwmon_sysfs");
> > +
> >  	return 0;
> >
> >  err_disable_clk_peri_therm:
> >
>

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Aw: Re: [PATCH v4] thermal: mediatek: add sensors-support
@ 2021-06-28 10:05     ` Frank Wunderlich
  0 siblings, 0 replies; 14+ messages in thread
From: Frank Wunderlich @ 2021-06-28 10:05 UTC (permalink / raw)
  To: Daniel Lezcano
  Cc: Matthias Brugger, Frank Wunderlich, linux-mediatek,
	Amit Kucheria, linux-pm, linux-arm-kernel, linux-kernel

Hi,

A gentle ping as it is reviewed but not yet visible in thermal tree [1] i guess it should do,right?

regards Frank

[1] https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git/log/?h=thermal/next

> Gesendet: Mittwoch, 09. Juni 2021 um 10:09 Uhr
> Von: "Matthias Brugger" <matthias.bgg@gmail.com>
> An: "Frank Wunderlich" <linux@fw-web.de>, linux-mediatek@lists.infradead.org
> Cc: "Frank Wunderlich" <frank-w@public-files.de>, "Daniel Lezcano" <daniel.lezcano@linaro.org>, "Amit Kucheria" <amitk@kernel.org>, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
> Betreff: Re: [PATCH v4] thermal: mediatek: add sensors-support
>
>
>
> On 08/06/2021 17:45, Frank Wunderlich wrote:
> > From: Frank Wunderlich <frank-w@public-files.de>
> >
> > add HWMON-support to mediateks thermal driver to allow lm-sensors
> > userspace tools read soc temperature
> >
> > Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
>
> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
>
> > ---
> > v4: change message to dev_warn as suggested by matthias
> > v3: drop no_hwmon
> > v2: drop ifdef and used devm_thermal_add_hwmon_sysfs
> > ---
> >  drivers/thermal/mtk_thermal.c | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mtk_thermal.c
> > index 97e8678ccf0e..ede94eadddda 100644
> > --- a/drivers/thermal/mtk_thermal.c
> > +++ b/drivers/thermal/mtk_thermal.c
> > @@ -23,6 +23,8 @@
> >  #include <linux/reset.h>
> >  #include <linux/types.h>
> >
> > +#include "thermal_hwmon.h"
> > +
> >  /* AUXADC Registers */
> >  #define AUXADC_CON1_SET_V	0x008
> >  #define AUXADC_CON1_CLR_V	0x00c
> > @@ -1087,6 +1089,10 @@ static int mtk_thermal_probe(struct platform_device *pdev)
> >  		goto err_disable_clk_peri_therm;
> >  	}
> >
> > +	ret = devm_thermal_add_hwmon_sysfs(tzdev);
> > +	if (ret)
> > +		dev_warn(&pdev->dev, "error in thermal_add_hwmon_sysfs");
> > +
> >  	return 0;
> >
> >  err_disable_clk_peri_therm:
> >
>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: Aw: Re: [PATCH v4] thermal: mediatek: add sensors-support
  2021-06-28 10:05     ` Frank Wunderlich
  (?)
@ 2021-06-28 15:38       ` Daniel Lezcano
  -1 siblings, 0 replies; 14+ messages in thread
From: Daniel Lezcano @ 2021-06-28 15:38 UTC (permalink / raw)
  To: Frank Wunderlich
  Cc: Matthias Brugger, Frank Wunderlich, linux-mediatek,
	Amit Kucheria, linux-pm, linux-arm-kernel, linux-kernel

On 28/06/2021 12:05, Frank Wunderlich wrote:
> Hi,
> 
> A gentle ping as it is reviewed but not yet visible in thermal tree [1] i guess it should do,right?
> 

Right, I thought I took it.

Fixed, thanks for the heads up.


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: Aw: Re: [PATCH v4] thermal: mediatek: add sensors-support
@ 2021-06-28 15:38       ` Daniel Lezcano
  0 siblings, 0 replies; 14+ messages in thread
From: Daniel Lezcano @ 2021-06-28 15:38 UTC (permalink / raw)
  To: Frank Wunderlich
  Cc: Matthias Brugger, Frank Wunderlich, linux-mediatek,
	Amit Kucheria, linux-pm, linux-arm-kernel, linux-kernel

On 28/06/2021 12:05, Frank Wunderlich wrote:
> Hi,
> 
> A gentle ping as it is reviewed but not yet visible in thermal tree [1] i guess it should do,right?
> 

Right, I thought I took it.

Fixed, thanks for the heads up.


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: Aw: Re: [PATCH v4] thermal: mediatek: add sensors-support
@ 2021-06-28 15:38       ` Daniel Lezcano
  0 siblings, 0 replies; 14+ messages in thread
From: Daniel Lezcano @ 2021-06-28 15:38 UTC (permalink / raw)
  To: Frank Wunderlich
  Cc: Matthias Brugger, Frank Wunderlich, linux-mediatek,
	Amit Kucheria, linux-pm, linux-arm-kernel, linux-kernel

On 28/06/2021 12:05, Frank Wunderlich wrote:
> Hi,
> 
> A gentle ping as it is reviewed but not yet visible in thermal tree [1] i guess it should do,right?
> 

Right, I thought I took it.

Fixed, thanks for the heads up.


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [thermal: thermal/next] thermal/drivers/mediatek: Add sensors-support
  2021-06-08 15:45 ` Frank Wunderlich
                   ` (2 preceding siblings ...)
  (?)
@ 2021-06-30  9:31 ` thermal-bot for Frank Wunderlich
  -1 siblings, 0 replies; 14+ messages in thread
From: thermal-bot for Frank Wunderlich @ 2021-06-30  9:31 UTC (permalink / raw)
  To: linux-pm
  Cc: Frank Wunderlich, Matthias Brugger, Daniel Lezcano, rui.zhang, amitk

The following commit has been merged into the thermal/next branch of thermal:

Commit-ID:     77b6c4044d8f7062b2c1c2a99f4bb076acc7f04f
Gitweb:        https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git//77b6c4044d8f7062b2c1c2a99f4bb076acc7f04f
Author:        Frank Wunderlich <frank-w@public-files.de>
AuthorDate:    Tue, 08 Jun 2021 17:45:30 +02:00
Committer:     Daniel Lezcano <daniel.lezcano@linaro.org>
CommitterDate: Mon, 28 Jun 2021 20:57:36 +02:00

thermal/drivers/mediatek: Add sensors-support

Add HWMON-support to mediateks thermal driver to allow lm-sensors
userspace tools read soc temperature

Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20210608154530.70074-1-linux@fw-web.de
---
 drivers/thermal/mtk_thermal.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mtk_thermal.c
index 97e8678..ede94ea 100644
--- a/drivers/thermal/mtk_thermal.c
+++ b/drivers/thermal/mtk_thermal.c
@@ -23,6 +23,8 @@
 #include <linux/reset.h>
 #include <linux/types.h>
 
+#include "thermal_hwmon.h"
+
 /* AUXADC Registers */
 #define AUXADC_CON1_SET_V	0x008
 #define AUXADC_CON1_CLR_V	0x00c
@@ -1087,6 +1089,10 @@ static int mtk_thermal_probe(struct platform_device *pdev)
 		goto err_disable_clk_peri_therm;
 	}
 
+	ret = devm_thermal_add_hwmon_sysfs(tzdev);
+	if (ret)
+		dev_warn(&pdev->dev, "error in thermal_add_hwmon_sysfs");
+
 	return 0;
 
 err_disable_clk_peri_therm:

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [thermal: thermal/next] thermal/drivers/mediatek: Add sensors-support
  2021-06-08 15:45 ` Frank Wunderlich
                   ` (3 preceding siblings ...)
  (?)
@ 2021-07-04 18:02 ` thermal-bot for Frank Wunderlich
  -1 siblings, 0 replies; 14+ messages in thread
From: thermal-bot for Frank Wunderlich @ 2021-07-04 18:02 UTC (permalink / raw)
  To: linux-pm
  Cc: Frank Wunderlich, Matthias Brugger, Daniel Lezcano, rui.zhang, amitk

The following commit has been merged into the thermal/next branch of thermal:

Commit-ID:     24e21d9f40ec3fb4228e3427454b733316a2a6c6
Gitweb:        https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git//24e21d9f40ec3fb4228e3427454b733316a2a6c6
Author:        Frank Wunderlich <frank-w@public-files.de>
AuthorDate:    Tue, 08 Jun 2021 17:45:30 +02:00
Committer:     Daniel Lezcano <daniel.lezcano@linaro.org>
CommitterDate: Sun, 04 Jul 2021 18:28:04 +02:00

thermal/drivers/mediatek: Add sensors-support

Add HWMON-support to mediateks thermal driver to allow lm-sensors
userspace tools read soc temperature

Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20210608154530.70074-1-linux@fw-web.de
---
 drivers/thermal/mtk_thermal.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mtk_thermal.c
index 97e8678..ede94ea 100644
--- a/drivers/thermal/mtk_thermal.c
+++ b/drivers/thermal/mtk_thermal.c
@@ -23,6 +23,8 @@
 #include <linux/reset.h>
 #include <linux/types.h>
 
+#include "thermal_hwmon.h"
+
 /* AUXADC Registers */
 #define AUXADC_CON1_SET_V	0x008
 #define AUXADC_CON1_CLR_V	0x00c
@@ -1087,6 +1089,10 @@ static int mtk_thermal_probe(struct platform_device *pdev)
 		goto err_disable_clk_peri_therm;
 	}
 
+	ret = devm_thermal_add_hwmon_sysfs(tzdev);
+	if (ret)
+		dev_warn(&pdev->dev, "error in thermal_add_hwmon_sysfs");
+
 	return 0;
 
 err_disable_clk_peri_therm:

^ permalink raw reply related	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2021-07-04 18:02 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-08 15:45 [PATCH v4] thermal: mediatek: add sensors-support Frank Wunderlich
2021-06-08 15:45 ` Frank Wunderlich
2021-06-08 15:45 ` Frank Wunderlich
2021-06-09  8:09 ` Matthias Brugger
2021-06-09  8:09   ` Matthias Brugger
2021-06-09  8:09   ` Matthias Brugger
2021-06-28 10:05   ` Aw: " Frank Wunderlich
2021-06-28 10:05     ` Frank Wunderlich
2021-06-28 10:05     ` Frank Wunderlich
2021-06-28 15:38     ` Daniel Lezcano
2021-06-28 15:38       ` Daniel Lezcano
2021-06-28 15:38       ` Daniel Lezcano
2021-06-30  9:31 ` [thermal: thermal/next] thermal/drivers/mediatek: Add sensors-support thermal-bot for Frank Wunderlich
2021-07-04 18:02 ` thermal-bot for Frank Wunderlich

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.