* [PATCH] drivers/media/usb/gspca: fix typo issues
@ 2021-06-09 3:32 Herman
2021-06-09 3:50 ` Joe Perches
0 siblings, 1 reply; 4+ messages in thread
From: Herman @ 2021-06-09 3:32 UTC (permalink / raw)
To: mchehab; +Cc: linux-media, linux-kernel, Herman
spca501.c : remove redundant 'is'
zc3xx.c : change 'outdoore' into 'outdoor'
Signed-off-by: Herman <yanshuaijun@yulong.com>
---
drivers/media/usb/gspca/spca501.c | 2 +-
drivers/media/usb/gspca/zc3xx.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/usb/gspca/spca501.c b/drivers/media/usb/gspca/spca501.c
index ecc97f807cfa..f7c75d7535c4 100644
--- a/drivers/media/usb/gspca/spca501.c
+++ b/drivers/media/usb/gspca/spca501.c
@@ -488,7 +488,7 @@ static const __u16 spca501_init_data[][3] = {
/* Data for video camera init before capture.
* Capture and decoding by Colin Peart.
- * This is is for the 3com HomeConnect Lite which is spca501a based.
+ * This is for the 3com HomeConnect Lite which is spca501a based.
*/
static const __u16 spca501_3com_open_data[][3] = {
/* bmRequest,value,index */
diff --git a/drivers/media/usb/gspca/zc3xx.c b/drivers/media/usb/gspca/zc3xx.c
index aa285d5d6c0d..1bbf8071dde0 100644
--- a/drivers/media/usb/gspca/zc3xx.c
+++ b/drivers/media/usb/gspca/zc3xx.c
@@ -5806,7 +5806,7 @@ static void setquality(struct gspca_dev *gspca_dev)
* Valid frequencies are:
* 50Hz, for European and Asian lighting (default)
* 60Hz, for American lighting
- * 0 = No Fliker (for outdoore usage)
+ * 0 = No Fliker (for outdoor usage)
*/
static void setlightfreq(struct gspca_dev *gspca_dev, s32 val)
{
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drivers/media/usb/gspca: fix typo issues
2021-06-09 3:32 [PATCH] drivers/media/usb/gspca: fix typo issues Herman
@ 2021-06-09 3:50 ` Joe Perches
[not found] ` <60c05921.1c69fb81.dbb59.4019SMTPIN_ADDED_BROKEN@mx.google.com>
0 siblings, 1 reply; 4+ messages in thread
From: Joe Perches @ 2021-06-09 3:50 UTC (permalink / raw)
To: Herman, mchehab; +Cc: linux-media, linux-kernel, Herman
On Wed, 2021-06-09 at 11:32 +0800, Herman wrote:
> spca501.c : remove redundant 'is'
> zc3xx.c : change 'outdoore' into 'outdoor'
[]
> diff --git a/drivers/media/usb/gspca/zc3xx.c b/drivers/media/usb/gspca/zc3xx.c
[]
> @@ -5806,7 +5806,7 @@ static void setquality(struct gspca_dev *gspca_dev)
> * Valid frequencies are:
> * 50Hz, for European and Asian lighting (default)
> * 60Hz, for American lighting
> - * 0 = No Fliker (for outdoore usage)
> + * 0 = No Fliker (for outdoor usage)
Fliker/Flicker?
but there are a lot of those in this file...
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Re: [PATCH] drivers/media/usb/gspca: fix typo issues
[not found] ` <CAP6HEvL-wCAfBJLBoJ2gaUBN0G-CWFb95e2nd6nwPNdwF7VaJQ@mail.gmail.com>
@ 2021-06-09 6:39 ` Joe Perches
2021-06-09 7:00 ` Hans Verkuil
0 siblings, 1 reply; 4+ messages in thread
From: Joe Perches @ 2021-06-09 6:39 UTC (permalink / raw)
To: herman yim, yanshuaijun; +Cc: mchehab, linux-media, linux-kernel
On Wed, 2021-06-09 at 14:29 +0800, herman yim wrote:
> hi Joe,
> many flicker written into fliker in this file, relate to variable name and
> function name.
> change them together ? what is your suggestion ?
Leave it alone. It's old and probably obsolete.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drivers/media/usb/gspca: fix typo issues
2021-06-09 6:39 ` Joe Perches
@ 2021-06-09 7:00 ` Hans Verkuil
0 siblings, 0 replies; 4+ messages in thread
From: Hans Verkuil @ 2021-06-09 7:00 UTC (permalink / raw)
To: Joe Perches, herman yim, yanshuaijun; +Cc: mchehab, linux-media, linux-kernel
On 09/06/2021 08:39, Joe Perches wrote:
> On Wed, 2021-06-09 at 14:29 +0800, herman yim wrote:
>> hi Joe,
>> many flicker written into fliker in this file, relate to variable name and
>> function name.
>> change them together ? what is your suggestion ?
>
> Leave it alone. It's old and probably obsolete.
>
>
Actually, this driver is still in use and maintained. Apparently these old
webcams refuse to die :-)
So I'll accept a patch changing the fliker typo in this driver (just make a
single patch changing this in the gscpa driver).
Regards,
Hans
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-06-09 7:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-09 3:32 [PATCH] drivers/media/usb/gspca: fix typo issues Herman
2021-06-09 3:50 ` Joe Perches
[not found] ` <60c05921.1c69fb81.dbb59.4019SMTPIN_ADDED_BROKEN@mx.google.com>
[not found] ` <CAP6HEvL-wCAfBJLBoJ2gaUBN0G-CWFb95e2nd6nwPNdwF7VaJQ@mail.gmail.com>
2021-06-09 6:39 ` Joe Perches
2021-06-09 7:00 ` Hans Verkuil
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.