From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Colin King <colin.king@canonical.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
linux-kernel@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH] memory: tegra: make the array list static const, makes object smaller
Date: Fri, 20 Aug 2021 12:52:12 +0200 [thread overview]
Message-ID: <9ecb8f1b-7e2a-7d5a-c176-07459d0c148f@canonical.com> (raw)
In-Reply-To: <20210819133155.10441-1-colin.king@canonical.com>
On 19/08/2021 15:31, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate the array list on the stack but instead it
> static const. Makes the object code smaller by 110 bytes:
>
> Before:
> text data bss dec hex filename
> 37713 21992 64 59769 e979 .../tegra/tegra210-emc-cc-r21021.o
>
> After:
> text data bss dec hex filename
> 37539 22056 64 59659 e90b .../tegra/tegra210-emc-cc-r21021.o
>
> (gcc version 10.3.0)
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/memory/tegra/tegra210-emc-cc-r21021.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Looks good, it's too late for this cycle, so I'll take it after merge
window.
Best regards,
Krzysztof
next prev parent reply other threads:[~2021-08-20 11:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-19 13:31 [PATCH] memory: tegra: make the array list static const, makes object smaller Colin King
2021-08-19 17:26 ` Thierry Reding
2021-08-20 10:52 ` Krzysztof Kozlowski [this message]
2021-09-15 7:37 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ecb8f1b-7e2a-7d5a-c176-07459d0c148f@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=colin.king@canonical.com \
--cc=jonathanh@nvidia.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.