All of lore.kernel.org
 help / color / mirror / Atom feed
From: "zhudi (E)" <zhudi2@huawei.com>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
	Yonghong Song <yhs@fb.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Andrii Nakryiko <andrii@kernel.org>,
	Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
	John Fastabend <john.fastabend@gmail.com>,
	KP Singh <kpsingh@kernel.org>,
	Jakub Sitnicki <jakub@cloudflare.com>, bpf <bpf@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH bpf-next v4 1/2] bpf: support BPF_PROG_QUERY for progs attached to sockmap
Date: Wed, 3 Nov 2021 02:25:15 +0000	[thread overview]
Message-ID: <9ed289892e1448c69f58f0268c395167@huawei.com> (raw)

> On Tue, Nov 2, 2021 at 1:11 PM Yonghong Song <yhs@fb.com> wrote:
> > >
> > > -static int sock_map_prog_update(struct bpf_map *map, struct bpf_prog
> *prog,
> > > -                             struct bpf_prog *old, u32 which)
> > > +static int sock_map_prog_lookup(struct bpf_map *map, struct bpf_prog
> **pprog[],
> >
> > Can we just change "**pprog[]" to "***pprog"? In the code, you really
> > just pass the address of the decl "struct bpf_prog **pprog;" to the
> > function.
> 
> Di,
> 
> this feedback was given twice already.
> You also didn't address several other points from the earlier reviews.
> Please do not resubmit until you address all points.

Maybe i miss something...
I will recheck the review comments.

             reply	other threads:[~2021-11-03  2:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-03  2:25 zhudi (E) [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-11-03  2:23 [PATCH bpf-next v4 1/2] bpf: support BPF_PROG_QUERY for progs attached to sockmap zhudi (E)
2021-11-03  2:37 ` Yonghong Song
2021-11-02  8:48 Di Zhu
2021-11-02 20:11 ` Yonghong Song
2021-11-02 21:16   ` Alexei Starovoitov
2021-11-02  5:59 Di Zhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9ed289892e1448c69f58f0268c395167@huawei.com \
    --to=zhudi2@huawei.com \
    --cc=alexei.starovoitov@gmail.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=jakub@cloudflare.com \
    --cc=john.fastabend@gmail.com \
    --cc=kafai@fb.com \
    --cc=kpsingh@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=songliubraving@fb.com \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.