From: Pavel Tatashin <pasha.tatashin@oracle.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
davem@davemloft.net
Cc: netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com,
jogreene@redhat.com
Subject: Re: [net-next 3/6] ixgbe: release lock for the duration of ixgbe_suspend_close()
Date: Fri, 18 May 2018 07:37:32 -0400 [thread overview]
Message-ID: <9ee4abce-0841-374d-5395-0c5170880eb1@oracle.com> (raw)
In-Reply-To: <c9fbb37d-9213-ff72-aa8c-b998f0b19490@cogentembedded.com>
* parallelized this function, so drop lock for the
>
> Parallelizing? Else the sentence doesn't parse for me. :-)
Hi Sergei,
In a separate series I parallelized device_shutdown(), see:
http://lkml.kernel.org/r/20180516024004.28977-1-pasha.tatashin@oracle.com
But, this particular patch should be dropped, as discussed in this thread:
http://lkml.kernel.org/r/20180503035931.22439-2-pasha.tatashin@oracle.com
Alexander Duyck, made a point that a generic RTNL scalability fix should be done. This particular patch might introduce a race, since it relies on assumption that RTNL is not needed in this place because ixgbe_close() does not have it, but Alexander Duyck, says that the callers of ixgbe_close() are assumed to own this lock.
Thank you,
Pavel
next prev parent reply other threads:[~2018-05-18 11:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-17 16:37 [net-next 0/6][pull request] 10GbE Intel Wired LAN Driver Updates 2018-05-17 Jeff Kirsher
2018-05-17 16:37 ` [net-next 1/6] ixgbe: cleanup sparse warnings Jeff Kirsher
2018-05-17 16:37 ` [net-next 2/6] ixgbe/ixgbevf: Free IRQ when PCI error recovery removes the device Jeff Kirsher
2018-05-17 16:37 ` [net-next 3/6] ixgbe: release lock for the duration of ixgbe_suspend_close() Jeff Kirsher
2018-05-18 8:59 ` Sergei Shtylyov
2018-05-18 11:37 ` Pavel Tatashin [this message]
2018-05-18 17:28 ` Sergei Shtylyov
2018-05-18 17:35 ` Pavel Tatashin
2018-05-17 16:37 ` [net-next 4/6] ixgbe: force VF to grab new MAC on driver reload Jeff Kirsher
2018-05-17 16:37 ` [net-next 5/6] ixgbevf: fix MAC address changes through ixgbevf_set_mac() Jeff Kirsher
2018-05-17 16:37 ` [net-next 6/6] ice: Update NVM AQ command functions Jeff Kirsher
2018-05-17 21:03 ` [net-next 0/6][pull request] 10GbE Intel Wired LAN Driver Updates 2018-05-17 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ee4abce-0841-374d-5395-0c5170880eb1@oracle.com \
--to=pasha.tatashin@oracle.com \
--cc=davem@davemloft.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jogreene@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=sassmann@redhat.com \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.