From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Wei Liu <wl@xen.org>, Anthony Perard <anthony.perard@citrix.com>
Subject: Re: [PATCH v2] libxc: avoid clobbering errno in xc_domain_pod_target()
Date: Fri, 10 Dec 2021 14:26:04 +0100 [thread overview]
Message-ID: <9ee8e038-9842-b0cf-f8ce-7922373c3b19@suse.com> (raw)
In-Reply-To: <ac9ffddc-b102-9876-7a46-345078c3423c@suse.com>
[-- Attachment #1.1.1: Type: text/plain, Size: 340 bytes --]
On 10.12.21 14:11, Jan Beulich wrote:
> do_memory_op() supplies return value and has "errno" set the usual way.
> Don't overwrite "errno" with 1 (aka EPERM on at least Linux). There's
> also no reason to overwrite "err".
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3135 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
next prev parent reply other threads:[~2021-12-10 13:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-10 13:11 [PATCH v2] libxc: avoid clobbering errno in xc_domain_pod_target() Jan Beulich
2021-12-10 13:26 ` Juergen Gross [this message]
2021-12-10 13:50 ` Bertrand Marquis
2021-12-10 13:54 ` Jan Beulich
2021-12-10 14:00 ` Bertrand Marquis
2021-12-10 16:41 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ee8e038-9842-b0cf-f8ce-7922373c3b19@suse.com \
--to=jgross@suse.com \
--cc=anthony.perard@citrix.com \
--cc=jbeulich@suse.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.