From: David Ahern <dsahern@gmail.com>
To: Parav Pandit <parav@nvidia.com>, Jakub Kicinski <kuba@kernel.org>,
Saeed Mahameed <saeed@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Jason Gunthorpe <jgg@nvidia.com>,
Leon Romanovsky <leonro@nvidia.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
David Ahern <dsahern@kernel.org>,
Jacob Keller <jacob.e.keller@intel.com>,
Sridhar Samudrala <sridhar.samudrala@intel.com>,
"david.m.ertman@intel.com" <david.m.ertman@intel.com>,
"dan.j.williams@intel.com" <dan.j.williams@intel.com>,
"kiran.patil@intel.com" <kiran.patil@intel.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
Jiri Pirko <jiri@nvidia.com>, Vu Pham <vuhuong@nvidia.com>,
Saeed Mahameed <saeedm@nvidia.com>
Subject: Re: [net-next v5 05/15] devlink: Support get and set state of port function
Date: Wed, 16 Dec 2020 09:15:06 -0700 [thread overview]
Message-ID: <9eeff74c-fb7f-a24d-de1e-34e32428d83c@gmail.com> (raw)
In-Reply-To: <BY5PR12MB43225346806029AA31D63918DCC50@BY5PR12MB4322.namprd12.prod.outlook.com>
On 12/15/20 10:15 PM, Parav Pandit wrote:
>>> + * enum devlink_port_function_opstate - indicates operational state
>>> + of port function
>>> + * @DEVLINK_PORT_FUNCTION_OPSTATE_ATTACHED: Driver is attached
>> to the
>>> + function of port,
>> This name definitely needs to be shortened.
>>
> DEVLINK_PORT_FUNCTION_OPS_ATTACHED
> Or
> DEVLINK_PF_OPS_ATTACHED
>
> PF - port function
>
The devlink attribute names need to start using established short names
to find that balance between readability and ridiculously long names.
In this case PF for networking has an established link to SRIOV
'physical function'.
FUNCTION can be written as FCN.
ATTACHED can be shortened to ATTCH.
So in this case DEVLINK_PORT_FUNCTION_OPSTATE_ATTACHED (38 chars) drops
to DEVLINK_PORT_FCN_OPSTATE_ATTCH (30 chars). That is a step in the
right direction.
next prev parent reply other threads:[~2020-12-16 16:15 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-15 9:03 [net-next v5 00/15] Add mlx5 subfunction support Saeed Mahameed
2020-12-15 9:03 ` [net-next v5 01/15] net/mlx5: Fix compilation warning for 32-bit platform Saeed Mahameed
2020-12-15 9:03 ` [net-next v5 02/15] devlink: Prepare code to fill multiple port function attributes Saeed Mahameed
2020-12-15 9:03 ` [net-next v5 03/15] devlink: Introduce PCI SF port flavour and port attribute Saeed Mahameed
2020-12-15 23:27 ` Jakub Kicinski
2020-12-16 3:42 ` Parav Pandit
2020-12-16 23:59 ` Jakub Kicinski
2020-12-17 4:44 ` Saeed Mahameed
2020-12-18 19:48 ` Jakub Kicinski
2020-12-19 4:43 ` Parav Pandit
2020-12-15 9:03 ` [net-next v5 04/15] devlink: Support add and delete devlink port Saeed Mahameed
2020-12-16 0:29 ` Jakub Kicinski
2020-12-16 5:06 ` Parav Pandit
2020-12-15 9:03 ` [net-next v5 05/15] devlink: Support get and set state of port function Saeed Mahameed
2020-12-16 0:37 ` Jakub Kicinski
2020-12-16 5:15 ` Parav Pandit
2020-12-16 16:15 ` David Ahern [this message]
2020-12-17 0:08 ` Jakub Kicinski
2020-12-17 5:46 ` Parav Pandit
2020-12-18 19:51 ` Jakub Kicinski
2020-12-19 5:06 ` Parav Pandit
2020-12-15 9:03 ` [net-next v5 06/15] net/mlx5: Introduce vhca state event notifier Saeed Mahameed
2020-12-15 9:03 ` [net-next v5 07/15] net/mlx5: SF, Add auxiliary device support Saeed Mahameed
2020-12-16 0:43 ` Jakub Kicinski
2020-12-16 5:19 ` Parav Pandit
2020-12-17 0:11 ` Jakub Kicinski
2020-12-17 5:23 ` Parav Pandit
2020-12-18 19:58 ` Jakub Kicinski
2020-12-19 4:53 ` Parav Pandit
2020-12-19 17:43 ` Jakub Kicinski
2020-12-15 9:03 ` [net-next v5 08/15] net/mlx5: SF, Add auxiliary device driver Saeed Mahameed
2020-12-15 9:03 ` [net-next v5 09/15] net/mlx5: E-switch, Prepare eswitch to handle SF vport Saeed Mahameed
2020-12-16 0:47 ` Jakub Kicinski
2020-12-16 5:28 ` Parav Pandit
2020-12-15 9:03 ` [net-next v5 10/15] net/mlx5: E-switch, Add eswitch helpers for " Saeed Mahameed
2020-12-15 9:03 ` [net-next v5 11/15] net/mlx5: SF, Add port add delete functionality Saeed Mahameed
2020-12-16 0:51 ` Jakub Kicinski
2020-12-16 5:31 ` Parav Pandit
2020-12-15 9:03 ` [net-next v5 12/15] net/mlx5: SF, Port function state change support Saeed Mahameed
2020-12-15 9:03 ` [net-next v5 13/15] devlink: Add devlink port documentation Saeed Mahameed
2020-12-16 0:57 ` Jakub Kicinski
2020-12-16 5:40 ` Parav Pandit
2020-12-15 9:03 ` [net-next v5 14/15] devlink: Extend devlink port documentation for subfunctions Saeed Mahameed
2020-12-16 1:00 ` Jakub Kicinski
2020-12-16 3:55 ` Parav Pandit
2020-12-15 9:03 ` [net-next v5 15/15] net/mlx5: Add devlink subfunction port documentation Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9eeff74c-fb7f-a24d-de1e-34e32428d83c@gmail.com \
--to=dsahern@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=davem@davemloft.net \
--cc=david.m.ertman@intel.com \
--cc=dsahern@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jacob.e.keller@intel.com \
--cc=jgg@nvidia.com \
--cc=jiri@nvidia.com \
--cc=kiran.patil@intel.com \
--cc=kuba@kernel.org \
--cc=leonro@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=parav@nvidia.com \
--cc=saeed@kernel.org \
--cc=saeedm@nvidia.com \
--cc=sridhar.samudrala@intel.com \
--cc=vuhuong@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.