All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH 2/2] meson: split the summary in multiple sections
Date: Wed, 20 Jan 2021 18:40:24 +0100	[thread overview]
Message-ID: <9f00f21b-3988-0362-8c2a-f6143be74ea1@redhat.com> (raw)
In-Reply-To: <20210120172320.26742-3-pbonzini@redhat.com>

On 1/20/21 6:23 PM, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  meson.build | 16 +++++++++++++---
>  1 file changed, 13 insertions(+), 3 deletions(-)
> 
> diff --git a/meson.build b/meson.build
> index 75ce835d48..3d2ac1a399 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -2238,9 +2238,8 @@ endif
>  # Configuration summary #
>  #########################
>  
> -summary_info = {}
> -
>  # Generic information
> +summary_info = {}
>  summary_info += {'Install prefix':    get_option('prefix')}
>  summary_info += {'BIOS directory':    qemu_datadir}
>  summary_info += {'firmware path':     get_option('qemu_firmwarepath')}
> @@ -2263,8 +2262,10 @@ summary_info += {'GIT binary':        config_host['GIT']}
>  summary_info += {'GIT submodules':    config_host['GIT_SUBMODULES']}
>  summary_info += {'Documentation':     build_docs}
>  summary_info += {'Install blobs':     get_option('install_blobs')}
> +summary(summary_info, bool_yn: true)
>  
>  # Compilation information
> +summary_info = {}

I tried that, ...

>  summary_info += {'host CPU':          cpu}
>  summary_info += {'host endianness':   build_machine.endian()}
>  summary_info += {'C compiler':        meson.get_compiler('c').cmd_array()[0]}
> @@ -2322,8 +2323,10 @@ if targetos == 'windows'
>      summary_info += {'Windows SDK':       config_host['WIN_SDK']}
>    endif
>  endif
> +summary(summary_info, bool_yn: true, section: 'Compilation')

... but not that :)

I am still adding some sections in my branch. Only one is
useful so far: "Crypto".

Thanks for improving the summary!



  reply	other threads:[~2021-01-20 17:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-20 17:23 [PATCH 0/2] meson: Further cleanup of summary Paolo Bonzini
2021-01-20 17:23 ` [PATCH 1/2] meson: Summarize configurable features together Paolo Bonzini
2021-01-20 17:23 ` [PATCH 2/2] meson: split the summary in multiple sections Paolo Bonzini
2021-01-20 17:40   ` Philippe Mathieu-Daudé [this message]
2021-01-21  8:50 ` [PATCH 0/2] meson: Further cleanup of summary Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9f00f21b-3988-0362-8c2a-f6143be74ea1@redhat.com \
    --to=philmd@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.