From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIM_ADSP_DISCARD, DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DED1EC11F64 for ; Thu, 1 Jul 2021 14:16:24 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id E25A0613F2 for ; Thu, 1 Jul 2021 14:16:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E25A0613F2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=oktetlabs.ru Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0FB6040141; Thu, 1 Jul 2021 16:16:23 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 7618C4003E for ; Thu, 1 Jul 2021 16:16:22 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id EBA657F504; Thu, 1 Jul 2021 17:16:21 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru EBA657F504 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1625148982; bh=yIW3MftoDXqmV3zxiiD0s4So3KKDaejhMn6onTadOrg=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=Uvqnty3cQe5kRx4joHCwTHRreY+biwRCQU7gjWvwo2NrackBZg4lTQ0lxPTdHgOPt +XdZwjYTVFIx07bRT3nNROD+oYQc5kpbI99N6Lkavhlcc7u16jGeE0VMUDKrI+k/sp Hho5vVIoCDScH9cdEITf1irrKe2/N/D1vHpXPCdc= To: Stephen Hemminger , Keith Wiles Cc: dev@dpdk.org References: <20210616041528.4229-1-stephen@networkplumber.org> <20210616041528.4229-2-stephen@networkplumber.org> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: <9f02b218-62e4-f40e-f8ce-c77395164a89@oktetlabs.ru> Date: Thu, 1 Jul 2021 17:16:21 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210616041528.4229-2-stephen@networkplumber.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/2] net/tap: remove useless offload capa functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 6/16/21 7:15 AM, Stephen Hemminger wrote: > Since these always return 0, they were doing nothing useful. > > Signed-off-by: Stephen Hemminger I have no strong opinion on the patch, but sometimes even empty functions with comments add value. So, I see no point to touch it. So, I'll wait for maintainer reply.