From mboxrd@z Thu Jan 1 00:00:00 1970 From: Subject: RE: [PATCH] ACPI: Parse entire table as a term_list for Dell XPS 9570 and Precision M5530 Date: Tue, 30 Jan 2018 19:03:09 +0000 Message-ID: <9f0eaaf403014137a123f6676ddac5b9@ausx13mpc120.AMER.DELL.COM> References: <20180130060744.19049-1-kai.heng.feng@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: erik.schmauss@intel.com, andy.shevchenko@gmail.com, kai.heng.feng@canonical.com Cc: rjw@rjwysocki.net, lenb@kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, robert.moore@intel.com List-Id: linux-acpi@vger.kernel.org DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogU2NobWF1c3MsIEVyaWsg W21haWx0bzplcmlrLnNjaG1hdXNzQGludGVsLmNvbV0NCj4gU2VudDogVHVlc2RheSwgSmFudWFy eSAzMCwgMjAxOCAxMjozOCBQTQ0KPiBUbzogQW5keSBTaGV2Y2hlbmtvIDxhbmR5LnNoZXZjaGVu a29AZ21haWwuY29tPjsgS2FpLUhlbmcgRmVuZw0KPiA8a2FpLmhlbmcuZmVuZ0BjYW5vbmljYWwu Y29tPg0KPiBDYzogUmFmYWVsIEouIFd5c29ja2kgPHJqd0Byand5c29ja2kubmV0PjsgTGVuIEJy b3duIDxsZW5iQGtlcm5lbC5vcmc+OyBBQ1BJDQo+IERldmVsIE1hbGluZyBMaXN0IDxsaW51eC1h Y3BpQHZnZXIua2VybmVsLm9yZz47IExpbnV4IEtlcm5lbCBNYWlsaW5nIExpc3QgPGxpbnV4LQ0K PiBrZXJuZWxAdmdlci5rZXJuZWwub3JnPjsgTGltb25jaWVsbG8sIE1hcmlvIDxNYXJpb19MaW1v bmNpZWxsb0BEZWxsLmNvbT47DQo+IE1vb3JlLCBSb2JlcnQgPHJvYmVydC5tb29yZUBpbnRlbC5j b20+DQo+IFN1YmplY3Q6IFJFOiBbUEFUQ0hdIEFDUEk6IFBhcnNlIGVudGlyZSB0YWJsZSBhcyBh IHRlcm1fbGlzdCBmb3IgRGVsbCBYUFMgOTU3MCBhbmQNCj4gUHJlY2lzaW9uIE01NTMwDQo+IA0K PiBIaSwNCj4gPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiA+IEZyb206IGxpbnV4LWFj cGktb3duZXJAdmdlci5rZXJuZWwub3JnIFttYWlsdG86bGludXgtYWNwaS0NCj4gPiBvd25lckB2 Z2VyLmtlcm5lbC5vcmddIE9uIEJlaGFsZiBPZiBBbmR5IFNoZXZjaGVua28NCj4gPiBTZW50OiBU dWVzZGF5LCBKYW51YXJ5IDMwLCAyMDE4IDEwOjE4IEFNDQo+ID4gVG86IEthaS1IZW5nIEZlbmcg PGthaS5oZW5nLmZlbmdAY2Fub25pY2FsLmNvbT4NCj4gPiBDYzogUmFmYWVsIEouIFd5c29ja2kg PHJqd0Byand5c29ja2kubmV0PjsgTGVuIEJyb3duIDxsZW5iQGtlcm5lbC5vcmc+OyBBQ1BJDQo+ ID4gRGV2ZWwgTWFsaW5nIExpc3QgPGxpbnV4LWFjcGlAdmdlci5rZXJuZWwub3JnPjsgTGludXgg S2VybmVsIE1haWxpbmcgTGlzdCA8bGludXgtDQo+ID4ga2VybmVsQHZnZXIua2VybmVsLm9yZz47 IE1hcmlvIExpbW9uY2llbGxvIDxtYXJpby5saW1vbmNpZWxsb0BkZWxsLmNvbT4NCj4gPiBTdWJq ZWN0OiBSZTogW1BBVENIXSBBQ1BJOiBQYXJzZSBlbnRpcmUgdGFibGUgYXMgYSB0ZXJtX2xpc3Qg Zm9yIERlbGwgWFBTIDk1NzAgYW5kDQo+ID4gUHJlY2lzaW9uIE01NTMwDQo+ID4NCj4gPiBPbiBU dWUsIEphbiAzMCwgMjAxOCBhdCA4OjA3IEFNLCBLYWktSGVuZyBGZW5nDQo+ID4gPGthaS5oZW5n LmZlbmdAY2Fub25pY2FsLmNvbT4gd3JvdGU6DQo+ID4gPiBUaGUgaTJjIHRvdWNocGFkIG9uIERl bGwgWFBTIDk1NzAgYW5kIFByZWNpc2lvbiBNNTUzMCBkb2Vzbid0IHdvcmsgb3V0DQo+ID4gPiBv ZiBib3guDQo+ID4gPg0KPiA+ID4gVGhlIHRvdWNocGFkIHJlbGllcyBvbiBpdHMgX0lOSSBtZXRo b2QgdG8gdXBkYXRlIGl0cyBfSElEIHZhbHVlIGZyb20NCj4gPiA+IFhYWFgwMDAwIHRvIFNZTkEy MzkzLg0KPiA+ID4gQWxzbywgdGhlIF9TVEEgcmVsaWVzIG9uIHZhbHVlIG9mIEkyQ04gdG8gcmVw b3J0IGNvcnJlY3Qgc3RhdHVzLg0KPiA+ID4NCj4gPiA+IFNldCBhY3BpX2dibF9wYXJzZV90YWJs ZV9hc190ZXJtX2xpc3Qgc28gdGhlIHZhbHVlIG9mIEkyQ04gY2FuIGJlDQo+ID4gPiBjb3JyZWN0 bHkgc2V0IHVwLCBhbmQgX0lOSSBjYW4gZ2V0IHJ1bi4gVGhlIEFDUEkgdGFibGUgaW4gdGhpcyBt YWNoaW5lDQo+ID4gPiBpcyBkZXNpZ25lZCB0byBnZXQgcGFyc2VkIHRoaXMgd2F5Lg0KPiANCj4g SSB0aG91Z2h0IEkgd291bGQgZ2l2ZSBldmVyeW9uZSBhbiB1cGRhdGU6IHdlIGFyZSBnZXR0aW5n IGNsb3NlIHRvIGZpbmlzaGluZyBwYXRjaGVzDQo+IHRvIGVuYWJsZSB0aGlzIHRlcm0gbGlzdCBw YXJzaW5nIGJ5IGRlZmF1bHQgYXMgd2VsbCBhcyBhIGZldyBvdGhlciBmaXhlcyB3aXRoIGZvcndh cmQNCj4gcmVmZXJlbmNpbmcgb2YgcGFja2FnZSBlbGVtZW50cy4gT25jZSB3ZSBoYXZlIGVzdGFi bGlzaGVkIHRoYXQgdGhlc2UgcGF0Y2hlcyBhcmUNCj4gc3RhYmxlLCB3ZSB3aWxsIGdldCByaWQg b2YgYWNwaV9nYmxfcGFyc2VfdGFibGVfYXNfdGVybV9saXN0LiBTbyB0aGlzIHF1aXJrIG1heSBu b3QNCj4gYmUgbmVlZGVkIGluIHRoZSBuZWFyIGZ1dHVyZS4uLg0KDQpSYWZhZWwsDQoNCldvdWxk IHlvdSBiZSBvcHBvc2VkIHRvIGNhcnJ5aW5nIGEgcGF0Y2ggc2ltaWxhciB0byB0aGlzIChwcm9w b3NlZCkgcXVpcmsgcGF0Y2ggaW4gDQprZXJuZWwgYW5kIHJldmVydGluZyB3aGVuIEVyaWsgc3Vi bWl0cyBwYXRjaGVzIHRoYXQgZ2V0IHJpZCBvZg0KYWNwaV9nYmxfcGFyc2VfdGFibGVfYXNfdGVy bV9saXN0Pw0KDQpUaGUgcmVhc29uIGJlaW5nLCBJIHRoaW5rIHRoaXMgY291bGQgYWxzbyBiZSBh IGNhbmRpZGF0ZSB0byBicmluZyBiYWNrIHRvIEBzdGFibGUNCmFuZCBmaXggdGhpcyBwcm9ibGVt IG9uIGVhcmxpZXIga2VybmVscyB0b28uDQoNCkkgZG9u4oCZdCBiZWxpZXZlIHRoZSBwYXRjaGVz IHRoYXQgZ2V0IHJpZCBvZiBhY3BpX2dibF9wYXJzZV90YWJsZV9hc190ZXJtX2xpc3QgbGlrZWx5 DQp3aWxsIGJlIGdvb2QgY2FuZGlkYXRlcyBmb3IgQHN0YWJsZS4NCg0KDQo+IA0KPiBFcmlrDQo+ ID4gPg0KPiA+ID4gQWxzbywgY2hhbmdlIHRoZSBxdWlyayB0YWJsZSB0byBhIG1vcmUgZ2VuZXJp YyBuYW1lLg0KPiA+DQo+ID4gPiArc3RhdGljIGludCBzZXRfZ2JsX3Rlcm1fbGlzdChjb25zdCBz dHJ1Y3QgZG1pX3N5c3RlbV9pZCAqaWQpIHsNCj4gPiA+ICsgICAgICAgcHJfbm90aWNlKCIlcyBk ZXRlY3RlZCAtIHBhcnNlIHRoZSBlbnRpcmUgdGFibGUgYXMgYSB0ZXJtX2xpc3RcbiIsDQo+ID4g PiArICAgICAgICAgICAgICAgICBpZC0+aWRlbnQpOw0KPiA+ID4gKyAgICAgICBhY3BpX2dibF9w YXJzZV90YWJsZV9hc190ZXJtX2xpc3QgPSAxOw0KPiA+ID4gKyAgICAgICByZXR1cm4gMDsNCj4g PiA+ICt9DQo+ID4gPiAgI2VuZGlmDQo+ID4NCj4gPiBUaGUgYWJvdmUgc2hvdWxkIGJlIG91dHNp ZGUgb2YgYW5vdGhlciAjaWZkZWYuIEJhc2ljYWxseSBhZnRlciB0aGUgYWJvdmUgI2VuZGlmLg0K PiA+DQo+ID4gPiAgI2Vsc2UNCj4gPg0KPiA+ID4gICNlbmRpZg0KPiA+DQo+ID4gPiBAQCAtMTAw NSw3ICsxMDM0LDcgQEAgdm9pZCBfX2luaXQgYWNwaV9lYXJseV9pbml0KHZvaWQpDQo+ID4NCj4g PiA+ICAgICAgICAgICogSWYgdGhlIG1hY2hpbmUgZmFsbHMgaW50byB0aGUgRE1JIGNoZWNrIHRh YmxlLA0KPiA+ID4gICAgICAgICAgKiBEU0RUIHdpbGwgYmUgY29waWVkIHRvIG1lbW9yeQ0KPiA+ ID4gICAgICAgICAgKi8NCj4gPg0KPiA+IEl0IG1pZ2h0IG1ha2Ugc2Vuc2UgdG8gYWRqdXN0IGNv bW1lbnQgYWJvdmUgdGhhdCBpdCdzIGFib3V0IHF1aXJrcyBpbiBnZW5lcmFsLg0KPiA+IEFuZCwg aWYgbmVlZGVkLCBtb3ZlIGN1cnJlbnQgY29udGVudCB0byBhY3R1YWwgRE1JIGdyb3VwIG9mIHJl Y29yZHMuDQo+ID4NCj4gPiA+IC0gICAgICAgZG1pX2NoZWNrX3N5c3RlbShkc2R0X2RtaV90YWJs ZSk7DQo+ID4gPiArICAgICAgIGRtaV9jaGVja19zeXN0ZW0oYWNwaV9xdWlya3NfZG1pX3RhYmxl KTsNCj4gPg0KPiA+IC0tDQo+ID4gV2l0aCBCZXN0IFJlZ2FyZHMsDQo+ID4gQW5keSBTaGV2Y2hl bmtvDQo+ID4gLS0NCj4gPiBUbyB1bnN1YnNjcmliZSBmcm9tIHRoaXMgbGlzdDogc2VuZCB0aGUg bGluZSAidW5zdWJzY3JpYmUgbGludXgtYWNwaSIgaW4gdGhlIGJvZHkgb2YNCj4gPiBhIG1lc3Nh Z2UgdG8gbWFqb3Jkb21vQHZnZXIua2VybmVsLm9yZyBNb3JlIG1ham9yZG9tbyBpbmZvIGF0DQo+ ID4gaHR0cDovL3ZnZXIua2VybmVsLm9yZy9tYWpvcmRvbW8taW5mby5odG1sDQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752770AbeA3TDO (ORCPT ); Tue, 30 Jan 2018 14:03:14 -0500 Received: from esa3.dell-outbound.iphmx.com ([68.232.153.94]:62967 "EHLO esa3.dell-outbound.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751836AbeA3TDM (ORCPT ); Tue, 30 Jan 2018 14:03:12 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2EvAQA5wHBah8uZ6ERdGQEBAQEBAQEBA?= =?us-ascii?q?QEBAQcBAQEBAYQYEHUoCoNWmRGCAokSkEoKGAuFGAIagi5YFAEBAQEBAQEBAgE?= =?us-ascii?q?CEAEBAQgNCQgoL4I4BQIDGAgJS1kBAQEBAQEjAg1dAQEBAwEjBA0aIAsMBAIBC?= =?us-ascii?q?BEEAQEBAgIjAwICAh8QFQEICAIEAQcGBQgVBIl8Aw0IEKY5gW06hzkNgx0BAQE?= =?us-ascii?q?BAQEBAQEBAQEBAQEBAQEBH4EPg0iCFYM/gy6BSYEiRAMBgXYQI4JdgmUFkj+RG?= =?us-ascii?q?z2IGIhKhH2CJGeRJ0iKPYJhR4k6gTw2gXNwUoIqCYJMEAwZgW14AYx5XIEXAQE?= =?us-ascii?q?B?= X-IPAS-Result: =?us-ascii?q?A2EvAQA5wHBah8uZ6ERdGQEBAQEBAQEBAQEBAQcBAQEBAYQ?= =?us-ascii?q?YEHUoCoNWmRGCAokSkEoKGAuFGAIagi5YFAEBAQEBAQEBAgECEAEBAQgNCQgoL?= =?us-ascii?q?4I4BQIDGAgJS1kBAQEBAQEjAg1dAQEBAwEjBA0aIAsMBAIBCBEEAQEBAgIjAwI?= =?us-ascii?q?CAh8QFQEICAIEAQcGBQgVBIl8Aw0IEKY5gW06hzkNgx0BAQEBAQEBAQEBAQEBA?= =?us-ascii?q?QEBAQEBH4EPg0iCFYM/gy6BSYEiRAMBgXYQI4JdgmUFkj+RGz2IGIhKhH2CJGe?= =?us-ascii?q?RJ0iKPYJhR4k6gTw2gXNwUoIqCYJMEAwZgW14AYx5XIEXAQEB?= From: X-LoopCount0: from 10.166.132.189 X-IronPort-AV: E=Sophos;i="5.46,435,1511848800"; d="scan'208";a="207098661" X-DLP: DLP_GlobalPCIDSS To: , , CC: , , , , Subject: RE: [PATCH] ACPI: Parse entire table as a term_list for Dell XPS 9570 and Precision M5530 Thread-Topic: [PATCH] ACPI: Parse entire table as a term_list for Dell XPS 9570 and Precision M5530 Thread-Index: AQHTmZCyEyIZvdDx7UCOeDbsPWaUj6ONHr+AgAAFmAD//6EloA== Date: Tue, 30 Jan 2018 19:03:09 +0000 Message-ID: <9f0eaaf403014137a123f6676ddac5b9@ausx13mpc120.AMER.DELL.COM> References: <20180130060744.19049-1-kai.heng.feng@canonical.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.143.18.86] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id w0UJ3I4B001837 > -----Original Message----- > From: Schmauss, Erik [mailto:erik.schmauss@intel.com] > Sent: Tuesday, January 30, 2018 12:38 PM > To: Andy Shevchenko ; Kai-Heng Feng > > Cc: Rafael J. Wysocki ; Len Brown ; ACPI > Devel Maling List ; Linux Kernel Mailing List kernel@vger.kernel.org>; Limonciello, Mario ; > Moore, Robert > Subject: RE: [PATCH] ACPI: Parse entire table as a term_list for Dell XPS 9570 and > Precision M5530 > > Hi, > > -----Original Message----- > > From: linux-acpi-owner@vger.kernel.org [mailto:linux-acpi- > > owner@vger.kernel.org] On Behalf Of Andy Shevchenko > > Sent: Tuesday, January 30, 2018 10:18 AM > > To: Kai-Heng Feng > > Cc: Rafael J. Wysocki ; Len Brown ; ACPI > > Devel Maling List ; Linux Kernel Mailing List > kernel@vger.kernel.org>; Mario Limonciello > > Subject: Re: [PATCH] ACPI: Parse entire table as a term_list for Dell XPS 9570 and > > Precision M5530 > > > > On Tue, Jan 30, 2018 at 8:07 AM, Kai-Heng Feng > > wrote: > > > The i2c touchpad on Dell XPS 9570 and Precision M5530 doesn't work out > > > of box. > > > > > > The touchpad relies on its _INI method to update its _HID value from > > > XXXX0000 to SYNA2393. > > > Also, the _STA relies on value of I2CN to report correct status. > > > > > > Set acpi_gbl_parse_table_as_term_list so the value of I2CN can be > > > correctly set up, and _INI can get run. The ACPI table in this machine > > > is designed to get parsed this way. > > I thought I would give everyone an update: we are getting close to finishing patches > to enable this term list parsing by default as well as a few other fixes with forward > referencing of package elements. Once we have established that these patches are > stable, we will get rid of acpi_gbl_parse_table_as_term_list. So this quirk may not > be needed in the near future... Rafael, Would you be opposed to carrying a patch similar to this (proposed) quirk patch in kernel and reverting when Erik submits patches that get rid of acpi_gbl_parse_table_as_term_list? The reason being, I think this could also be a candidate to bring back to @stable and fix this problem on earlier kernels too. I don’t believe the patches that get rid of acpi_gbl_parse_table_as_term_list likely will be good candidates for @stable. > > Erik > > > > > > Also, change the quirk table to a more generic name. > > > > > +static int set_gbl_term_list(const struct dmi_system_id *id) { > > > + pr_notice("%s detected - parse the entire table as a term_list\n", > > > + id->ident); > > > + acpi_gbl_parse_table_as_term_list = 1; > > > + return 0; > > > +} > > > #endif > > > > The above should be outside of another #ifdef. Basically after the above #endif. > > > > > #else > > > > > #endif > > > > > @@ -1005,7 +1034,7 @@ void __init acpi_early_init(void) > > > > > * If the machine falls into the DMI check table, > > > * DSDT will be copied to memory > > > */ > > > > It might make sense to adjust comment above that it's about quirks in general. > > And, if needed, move current content to actual DMI group of records. > > > > > - dmi_check_system(dsdt_dmi_table); > > > + dmi_check_system(acpi_quirks_dmi_table); > > > > -- > > With Best Regards, > > Andy Shevchenko > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of > > a message to majordomo@vger.kernel.org More majordomo info at > > http://vger.kernel.org/majordomo-info.html