From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 05DABC433EF for ; Mon, 28 Mar 2022 09:35:02 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2909F10E625; Mon, 28 Mar 2022 09:35:01 +0000 (UTC) Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) by gabe.freedesktop.org (Postfix) with ESMTPS id ACE4710E625 for ; Mon, 28 Mar 2022 09:34:59 +0000 (UTC) X-UUID: f09d385295b640569cddb54d46bf6243-20220328 X-UUID: f09d385295b640569cddb54d46bf6243-20220328 Received: from mtkexhb01.mediatek.inc [(172.21.101.102)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 360122826; Mon, 28 Mar 2022 17:34:53 +0800 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkmbs07n1.mediatek.inc (172.21.101.16) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 28 Mar 2022 17:34:51 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 28 Mar 2022 17:34:51 +0800 Message-ID: <9f14d6a0aa782a8f6c3e7044fe90d74b80d17ed0.camel@mediatek.com> Subject: Re: [PATCH v1, 1/1] drm/mediatek: fixup crtc event null pointer issue From: CK Hu To: Yongqiang Niu , Chun-Kuang Hu Date: Mon, 28 Mar 2022 17:34:51 +0800 In-Reply-To: <20220314074239.28507-2-yongqiang.niu@mediatek.com> References: <20220314074239.28507-1-yongqiang.niu@mediatek.com> <20220314074239.28507-2-yongqiang.niu@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, David Airlie , Dennis YC Hsieh , Jassi Brar , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Project_Global_Chrome_Upstream_Group@mediatek.com, Fabien Parent , Rob Herring , linux-mediatek@lists.infradead.org, Hsin-Yi Wang , Matthias Brugger , linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, Yongqiang: On Mon, 2022-03-14 at 15:42 +0800, Yongqiang Niu wrote: > if crtc event is null pointer, do not send vblank event This is a bug-fix, so add a Fixes tag here. > > Signed-off-by: Yongqiang Niu > --- > drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > index d661edf7e0fe..265fed446628 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > @@ -92,6 +92,9 @@ static void mtk_drm_crtc_finish_page_flip(struct > mtk_drm_crtc *mtk_crtc) > struct drm_crtc *crtc = &mtk_crtc->base; > unsigned long flags; > > + if (!mtk_crtc->event) > + return; > + > spin_lock_irqsave(&crtc->dev->event_lock, flags); > drm_crtc_send_vblank_event(crtc, mtk_crtc->event); I think pending_needs_vblank is used to protect this situation. It seems that pending_needs_vblank should be protected by critical section. Regards, CK > drm_crtc_vblank_put(crtc); From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3348C433EF for ; Mon, 28 Mar 2022 09:35:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239862AbiC1Jgq (ORCPT ); Mon, 28 Mar 2022 05:36:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38238 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232922AbiC1Jgo (ORCPT ); Mon, 28 Mar 2022 05:36:44 -0400 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1BA2ABE36; Mon, 28 Mar 2022 02:34:59 -0700 (PDT) X-UUID: f09d385295b640569cddb54d46bf6243-20220328 X-UUID: f09d385295b640569cddb54d46bf6243-20220328 Received: from mtkexhb01.mediatek.inc [(172.21.101.102)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 360122826; Mon, 28 Mar 2022 17:34:53 +0800 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkmbs07n1.mediatek.inc (172.21.101.16) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 28 Mar 2022 17:34:51 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 28 Mar 2022 17:34:51 +0800 Message-ID: <9f14d6a0aa782a8f6c3e7044fe90d74b80d17ed0.camel@mediatek.com> Subject: Re: [PATCH v1, 1/1] drm/mediatek: fixup crtc event null pointer issue From: CK Hu To: Yongqiang Niu , Chun-Kuang Hu CC: , , David Airlie , Jassi Brar , , , "Dennis YC Hsieh" , Fabien Parent , Rob Herring , , Hsin-Yi Wang , Matthias Brugger , Date: Mon, 28 Mar 2022 17:34:51 +0800 In-Reply-To: <20220314074239.28507-2-yongqiang.niu@mediatek.com> References: <20220314074239.28507-1-yongqiang.niu@mediatek.com> <20220314074239.28507-2-yongqiang.niu@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Yongqiang: On Mon, 2022-03-14 at 15:42 +0800, Yongqiang Niu wrote: > if crtc event is null pointer, do not send vblank event This is a bug-fix, so add a Fixes tag here. > > Signed-off-by: Yongqiang Niu > --- > drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > index d661edf7e0fe..265fed446628 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > @@ -92,6 +92,9 @@ static void mtk_drm_crtc_finish_page_flip(struct > mtk_drm_crtc *mtk_crtc) > struct drm_crtc *crtc = &mtk_crtc->base; > unsigned long flags; > > + if (!mtk_crtc->event) > + return; > + > spin_lock_irqsave(&crtc->dev->event_lock, flags); > drm_crtc_send_vblank_event(crtc, mtk_crtc->event); I think pending_needs_vblank is used to protect this situation. It seems that pending_needs_vblank should be protected by critical section. Regards, CK > drm_crtc_vblank_put(crtc); From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 07359C433F5 for ; Mon, 28 Mar 2022 09:35:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VFL63+4R7IduZ245iKiMdOTod7N1cljEhpB1104JQCw=; b=VrMpSJi/wO/ejA GtFAzhpuLPOR60wEVWBKmmKXhpxmOgtANe6VZCCO7OHxC3Q3djSpI9bO2eF+qV+nJAPoKFTZW0fL4 RYgO+MlDUfee2/PTk1twQz9M+wefeghLBsemMgx+bOr6qcSFu4mTFisWFzsprq6zDezP2I9oEtxkk weqM4OhsiVIJHi91rsAlZEBi/s4sjdxDD553mp7FlWsNSvQRMq31/rWTa7pCrLeNJyoUaeouH5nEM yup5sJHCusJ9z2rhRPt0Se60hV1FJyzUtZ/z1ZXbmMOslINo29JLFZwKNeTUCnxk1dkqtUCD+Xd+x y+ghMBJwccf864D036xA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nYlmC-0083Ij-L3; Mon, 28 Mar 2022 09:35:04 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nYlm9-0083Hq-T7; Mon, 28 Mar 2022 09:35:03 +0000 X-UUID: fcd5b51544544a09aed7e9972347038a-20220328 X-UUID: fcd5b51544544a09aed7e9972347038a-20220328 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 550129380; Mon, 28 Mar 2022 02:34:55 -0700 Received: from mtkmbs07n1.mediatek.inc (172.21.101.16) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 28 Mar 2022 02:34:53 -0700 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkmbs07n1.mediatek.inc (172.21.101.16) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 28 Mar 2022 17:34:51 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 28 Mar 2022 17:34:51 +0800 Message-ID: <9f14d6a0aa782a8f6c3e7044fe90d74b80d17ed0.camel@mediatek.com> Subject: Re: [PATCH v1, 1/1] drm/mediatek: fixup crtc event null pointer issue From: CK Hu To: Yongqiang Niu , Chun-Kuang Hu CC: , , David Airlie , Jassi Brar , , , "Dennis YC Hsieh" , Fabien Parent , Rob Herring , , Hsin-Yi Wang , Matthias Brugger , Date: Mon, 28 Mar 2022 17:34:51 +0800 In-Reply-To: <20220314074239.28507-2-yongqiang.niu@mediatek.com> References: <20220314074239.28507-1-yongqiang.niu@mediatek.com> <20220314074239.28507-2-yongqiang.niu@mediatek.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220328_023501_998568_F7D3D574 X-CRM114-Status: GOOD ( 15.56 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi, Yongqiang: On Mon, 2022-03-14 at 15:42 +0800, Yongqiang Niu wrote: > if crtc event is null pointer, do not send vblank event This is a bug-fix, so add a Fixes tag here. > > Signed-off-by: Yongqiang Niu > --- > drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > index d661edf7e0fe..265fed446628 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > @@ -92,6 +92,9 @@ static void mtk_drm_crtc_finish_page_flip(struct > mtk_drm_crtc *mtk_crtc) > struct drm_crtc *crtc = &mtk_crtc->base; > unsigned long flags; > > + if (!mtk_crtc->event) > + return; > + > spin_lock_irqsave(&crtc->dev->event_lock, flags); > drm_crtc_send_vblank_event(crtc, mtk_crtc->event); I think pending_needs_vblank is used to protect this situation. It seems that pending_needs_vblank should be protected by critical section. Regards, CK > drm_crtc_vblank_put(crtc); _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 929A2C433EF for ; Mon, 28 Mar 2022 09:36:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zwtUj5sxe//cBiin0pn+x4fV56HoLQjXBkEev7ncFAI=; b=RTfWSDtXHOO0aj eNrjIzrKkkawEKCFCWgMx3aHnkk4ZIcmGmP65U9ce36dWjzDchsOyHjfxikcPTPNO+GM2eAVgfES6 KPGmBCY+7S3sbBuZY88othXiujahI3tClp3qZy9AvPgwa583Zo+NJFPYMuN1BSwCPML67XlibrwcX 6x3QO2AKQ1EWir+2XM55Zh7+R/no6YPMdAv8asnb1AHJRClI+2s1M4iazcJTjUGj44hGEO4N2HiTb 8Q7dlGLwvnd7dNv1BA1yRUSQKdV1E7VKvfa/lbqt3FaETCQb730ViCQlEgnRlkV2Juq2IGvt7OmTE xwtKFLWEQbfxFB2RcXWA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nYlmD-0083In-Ug; Mon, 28 Mar 2022 09:35:06 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nYlm9-0083Hq-T7; Mon, 28 Mar 2022 09:35:03 +0000 X-UUID: fcd5b51544544a09aed7e9972347038a-20220328 X-UUID: fcd5b51544544a09aed7e9972347038a-20220328 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 550129380; Mon, 28 Mar 2022 02:34:55 -0700 Received: from mtkmbs07n1.mediatek.inc (172.21.101.16) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 28 Mar 2022 02:34:53 -0700 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkmbs07n1.mediatek.inc (172.21.101.16) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 28 Mar 2022 17:34:51 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 28 Mar 2022 17:34:51 +0800 Message-ID: <9f14d6a0aa782a8f6c3e7044fe90d74b80d17ed0.camel@mediatek.com> Subject: Re: [PATCH v1, 1/1] drm/mediatek: fixup crtc event null pointer issue From: CK Hu To: Yongqiang Niu , Chun-Kuang Hu CC: , , David Airlie , Jassi Brar , , , "Dennis YC Hsieh" , Fabien Parent , Rob Herring , , Hsin-Yi Wang , Matthias Brugger , Date: Mon, 28 Mar 2022 17:34:51 +0800 In-Reply-To: <20220314074239.28507-2-yongqiang.niu@mediatek.com> References: <20220314074239.28507-1-yongqiang.niu@mediatek.com> <20220314074239.28507-2-yongqiang.niu@mediatek.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220328_023501_998568_F7D3D574 X-CRM114-Status: GOOD ( 15.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Yongqiang: On Mon, 2022-03-14 at 15:42 +0800, Yongqiang Niu wrote: > if crtc event is null pointer, do not send vblank event This is a bug-fix, so add a Fixes tag here. > > Signed-off-by: Yongqiang Niu > --- > drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > index d661edf7e0fe..265fed446628 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > @@ -92,6 +92,9 @@ static void mtk_drm_crtc_finish_page_flip(struct > mtk_drm_crtc *mtk_crtc) > struct drm_crtc *crtc = &mtk_crtc->base; > unsigned long flags; > > + if (!mtk_crtc->event) > + return; > + > spin_lock_irqsave(&crtc->dev->event_lock, flags); > drm_crtc_send_vblank_event(crtc, mtk_crtc->event); I think pending_needs_vblank is used to protect this situation. It seems that pending_needs_vblank should be protected by critical section. Regards, CK > drm_crtc_vblank_put(crtc); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel