All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sibi Sankar <sibis@codeaurora.org>
To: Evan Green <evgreen@google.com>
Cc: David Dai <daidavid1@codeaurora.org>,
	Georgi Djakov <georgi.djakov@linaro.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	sboyd@kernel.org, Lina Iyer <ilina@codeaurora.org>,
	Sean Sweeney <seansw@qti.qualcomm.com>,
	Alex Elder <elder@linaro.org>,
	LKML <linux-kernel@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
	linux-arm-msm <linux-arm-msm@vger.kernel.org>,
	linux-pm@vger.kernel.org, linux-arm-msm-owner@vger.kernel.org
Subject: Re: [PATCH v2 5/6] interconnect: qcom: sdm845: Split qnodes into their respective NoCs
Date: Sun, 09 Feb 2020 23:34:29 +0530	[thread overview]
Message-ID: <9f1675f15fdf6b627f0ce12b1a6cea9a@codeaurora.org> (raw)
In-Reply-To: <CAE=gft6--=zhxfR9G=S0g-5c9YdpvaFWz9dcgV7zJQAzcreZjg@mail.gmail.com>

On 2020-02-04 23:51, Evan Green wrote:
> On Thu, Jan 9, 2020 at 8:33 PM David Dai <daidavid1@codeaurora.org> 
> wrote:
>> 
>> In order to better represent the hardware and its different 
>> Network-On-Chip
>> devices, split the sdm845 provider driver into NoC specific providers.
>> Remove duplicate functionality already provided by the icc rpmh and
>> bcm voter drivers to calculate and commit bandwidth requests to 
>> hardware.
>> 
>> Signed-off-by: David Dai <daidavid1@codeaurora.org>
>> ---
>>  drivers/interconnect/qcom/sdm845.c             | 1132 
>> ++++++++++--------------
>>  include/dt-bindings/interconnect/qcom,sdm845.h |  263 +++---
>>  2 files changed, 609 insertions(+), 786 deletions(-)
>> 
>> diff --git a/drivers/interconnect/qcom/sdm845.c 
>> b/drivers/interconnect/qcom/sdm845.c
>> index f078cf0..8145612 100644
>> --- a/drivers/interconnect/qcom/sdm845.c
>> +++ b/drivers/interconnect/qcom/sdm845.c
>> @@ -5,283 +5,285 @@
>>   */
>> 
>>  #include <asm/div64.h>
> 
> You don't need this header anymore, right?
> 
>> -#include <dt-bindings/interconnect/qcom,sdm845.h>
>>  #include <linux/device.h>
>>  #include <linux/interconnect.h>
>>  #include <linux/interconnect-provider.h>
>>  #include <linux/io.h>

^^ can also be dropped

>>  #include <linux/module.h>
>>  #include <linux/of_device.h>
>> -#include <linux/of_platform.h>

^^ can also be dropped

>> -#include <linux/platform_device.h>
>>  #include <linux/sort.h>
> 
> ..or this one.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.

  reply	other threads:[~2020-02-09 18:04 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-10  4:32 [PATCH v2 0/6] Split SDM845 interconnect nodes and consolidate RPMh support David Dai
2020-01-10  4:32 ` [PATCH v2 1/6] dt-bindings: interconnect: Convert qcom,sdm845 to DT schema David Dai
2020-01-15 14:39   ` Rob Herring
2020-01-10  4:33 ` [PATCH v2 2/6] dt-bindings: interconnect: Add YAML schemas for QCOM bcm-voter David Dai
2020-01-15 14:44   ` Rob Herring
2020-01-10  4:33 ` [PATCH v2 3/6] dt-bindings: interconnect: Update Qualcomm SDM845 DT bindings David Dai
2020-01-15 14:49   ` Rob Herring
2020-01-17  0:07     ` David Dai
2020-01-31 21:35   ` Evan Green
2020-01-10  4:33 ` [PATCH v2 4/6] interconnect: qcom: Consolidate interconnect RPMh support David Dai
2020-02-04 18:22   ` Evan Green
2020-02-09 17:58     ` Sibi Sankar
2020-01-10  4:33 ` [PATCH v2 5/6] interconnect: qcom: sdm845: Split qnodes into their respective NoCs David Dai
2020-02-04 18:21   ` Evan Green
2020-02-09 18:04     ` Sibi Sankar [this message]
2020-01-10  4:33 ` [PATCH v2 6/6] arm64: dts: sdm845: Redefine interconnect provider DT nodes David Dai
2020-02-04 18:18   ` Evan Green
2020-02-09 18:03     ` Sibi Sankar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9f1675f15fdf6b627f0ce12b1a6cea9a@codeaurora.org \
    --to=sibis@codeaurora.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=daidavid1@codeaurora.org \
    --cc=devicetree@vger.kernel.org \
    --cc=elder@linaro.org \
    --cc=evgreen@google.com \
    --cc=georgi.djakov@linaro.org \
    --cc=ilina@codeaurora.org \
    --cc=linux-arm-msm-owner@vger.kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=seansw@qti.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.