From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74058EB64DA for ; Fri, 7 Jul 2023 08:27:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232377AbjGGI1z (ORCPT ); Fri, 7 Jul 2023 04:27:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57792 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232282AbjGGI1x (ORCPT ); Fri, 7 Jul 2023 04:27:53 -0400 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B44FDFF for ; Fri, 7 Jul 2023 01:27:51 -0700 (PDT) Received: by mail-ed1-x52d.google.com with SMTP id 4fb4d7f45d1cf-51d9695ec29so2001726a12.1 for ; Fri, 07 Jul 2023 01:27:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688718470; x=1691310470; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=FQJ5c3N6EKTWGPMRMDtrk/P3r+gReaLj0jfwbxhxXlo=; b=cGkm1kJmQKgYnpJp7pO9LwLaX4yJaKJlW8/1ct3ulwTnpxggvaxqIiNtBAvm1pTs1T 6StKvLoVYnUb0XLqOSt1qY9Vq9btgK1a+y0eCoa07aKhCo1GcUDCub9itkkesa0VDD6G 6HOqRr0ma4SS2HlnH9PE0txT23zfCmOrGn6rO/yFn6q/RxwdMNYfU56Vr3ToyNOAfHB4 iBGhvi8cHfuWKlJan2vNnzhjDhGeM5Eo2inUsUu8oFPf8fFIb6x2wBtL4SLq9twpOMyn v6sl9ePg7+AwVtVXuLRGLnR2MjChiHIHKFVV8yZXC4wcr5GUZCYDFWApqiyDi+RP0FMu 10jQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688718470; x=1691310470; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FQJ5c3N6EKTWGPMRMDtrk/P3r+gReaLj0jfwbxhxXlo=; b=V4HCWTxIju1djQO1vQmedWuGrT3r/wF6/DdhB2XqDQw7JN9nXNavcArIqSbS0d5/t/ x9QU1QUYJSrQ1td+khJLgGLEEWzgC+k5MWj5ApbZD0BYItwXuWYqSVEberzISVL+7n+a vx8Bw4I2ElU1c9p79kIJVd4Gw+DSwsvYVPUs5vhlPYsC4+YZSZRCLIzXu3aQpddW55Je 0aZ0yXXkAYA5xgvIfq9L3nhJwg81OwsHIcSFxNCRb1cMkBacLtyjFQ/ExlFinHQE6Tjg 1EHnpBT8XJFiSR5RWHtrJYqBBBjlqkUAubBoKgHyfyfWAQhZ9qUr+fsPCBd7xo39JQ1X DGlA== X-Gm-Message-State: ABy/qLaLqtJ9THP0xy8+oOxWrOJSpyY3nijMcbGcfFbReXu0TMZn02iZ TQ0jmfyuSkgIXgL3aReRNx0SUxK/hR2nuSy6bZSb/g== X-Google-Smtp-Source: APBJJlG6YgCW6SEYlY65g4J/X5KQFAGjtpNOYA3+55v0jjRgAbsrPyMiFhRTbEelwi//SZW4Csk2TA== X-Received: by 2002:a17:906:51cd:b0:993:d6e8:2386 with SMTP id v13-20020a17090651cd00b00993d6e82386mr382940ejk.16.1688718470204; Fri, 07 Jul 2023 01:27:50 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id u2-20020a1709063b8200b0098e42bef732sm1833038ejf.183.2023.07.07.01.27.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Jul 2023 01:27:49 -0700 (PDT) Message-ID: <9f1bd0f1-d93e-243a-4622-721319fd1235@linaro.org> Date: Fri, 7 Jul 2023 10:27:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v1 1/3] dt-bindings: usb: Add HPE GXP UDCG Controller Content-Language: en-US To: richard.yu@hpe.com, verdun@hpe.com, nick.hawkins@hpe.com, gregkh@linuxfoundation.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230706215910.78772-1-richard.yu@hpe.com> <20230706215910.78772-2-richard.yu@hpe.com> From: Krzysztof Kozlowski In-Reply-To: <20230706215910.78772-2-richard.yu@hpe.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/07/2023 23:59, richard.yu@hpe.com wrote: > From: Richard Yu > > Provide access to the two register regions for GXP Virtual EHCI > controller through the hpe,gxp-udcg binding. Thank you for your patch. There is something to discuss/improve. > > Signed-off-by: Richard Yu > --- > .../devicetree/bindings/usb/hpe,gxp-udcg.yaml | 70 +++++++++++++++++++ > 1 file changed, 70 insertions(+) > create mode 100644 Documentation/devicetree/bindings/usb/hpe,gxp-udcg.yaml > > diff --git a/Documentation/devicetree/bindings/usb/hpe,gxp-udcg.yaml b/Documentation/devicetree/bindings/usb/hpe,gxp-udcg.yaml > new file mode 100644 > index 000000000000..e6746374f97d > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/hpe,gxp-udcg.yaml > @@ -0,0 +1,70 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/usb/hpe,gxp-udcg.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: HPE GXP USB Virtual EHCI controller The word "virtual" in bindings pretty often raises questions, because we describe usually real hardware, not virtual. Some explanation in description would be useful. > + > +maintainers: > + - Nick Hawkins > + - Richard Yu > + > +description: |+ Drop |+ > + The HPE GXP USB Virtual EHCI Controller implements 1 set of USB EHCI > + register and several sets of device and endpoint registers to support > + the virtual EHCI's downstream USB devices. > + If this is EHCI controller, then I would expect here reference to usb-hcd. > +properties: > + compatible: > + enum: > + - hpe,gxp-udcg > + > + reg: > + items: > + - description: UDC Global (UDCG) config controller > + - description: UDC Invidual config/interrupt controllers > + > + reg-names: > + items: > + - const: udcg > + - const: udc > + > + interrupts: > + maxItems: 1 > + > + hpe,vehci-downstream-ports: > + description: Number of downstream ports supported by the GXP Why do you need this property in DT and what exactly does it represent? You have one device - EHCI controller - and on some boards it is further customized? Even though it is the same device? > + $ref: /schemas/types.yaml#/definitions/uint32 > + default: 4 > + minimum: 1 > + maximum: 8 > + > + hpe,vehci-generic-endpoints: > + description: Number of generic endpoints supported by the GXP > + $ref: /schemas/types.yaml#/definitions/uint32 Same concerns. > + default: 16 > + minimum: 1 > + maximum: 16 > + > +required: > + - compatible > + - reg > + - reg-names > + - interrupts > + - hpe,vehci-downstream-ports > + - hpe,vehci-generic-endpoints > + > +additionalProperties: false > + > +examples: > + - | > + udcg@80400800 { Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation Best regards, Krzysztof