From: Saeed Mahameed <saeedm@nvidia.com>
To: "kuba@kernel.org" <kuba@kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>
Cc: "mkubecek@suse.cz" <mkubecek@suse.cz>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"andrew@lunn.ch" <andrew@lunn.ch>
Subject: Re: [PATCH net v2] ethtool: fix ethtool msg len calculation for pause stats
Date: Wed, 3 Nov 2021 03:34:11 +0000 [thread overview]
Message-ID: <9f256591793eed8df78fe0f610a5d6aeb4322173.camel@nvidia.com> (raw)
In-Reply-To: <20211102220236.3803742-1-kuba@kernel.org>
On Tue, 2021-11-02 at 15:02 -0700, Jakub Kicinski wrote:
> ETHTOOL_A_PAUSE_STAT_MAX is the MAX attribute id,
> so we need to subtract non-stats and add one to
> get a count (IOW -2+1 == -1).
>
> Otherwise we'll see:
>
> ethnl cmd 21: calculated reply length 40, but consumed 52
>
> Fixes: 9a27a33027f2 ("ethtool: add standard pause stats")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Saeed Mahameed <saeedm@nvidia.com>
next prev parent reply other threads:[~2021-11-03 3:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-02 22:02 [PATCH net v2] ethtool: fix ethtool msg len calculation for pause stats Jakub Kicinski
2021-11-03 3:34 ` Saeed Mahameed [this message]
2021-11-03 14:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f256591793eed8df78fe0f610a5d6aeb4322173.camel@nvidia.com \
--to=saeedm@nvidia.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.