From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9845C4332F for ; Sat, 2 Oct 2021 15:22:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C067961A6E for ; Sat, 2 Oct 2021 15:22:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233505AbhJBPXv (ORCPT ); Sat, 2 Oct 2021 11:23:51 -0400 Received: from smtprelay0040.hostedemail.com ([216.40.44.40]:37060 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S233425AbhJBPXt (ORCPT ); Sat, 2 Oct 2021 11:23:49 -0400 Received: from omf10.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay01.hostedemail.com (Postfix) with ESMTP id 49791100E7B55; Sat, 2 Oct 2021 15:22:02 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf10.hostedemail.com (Postfix) with ESMTPA id 077632351F3; Sat, 2 Oct 2021 15:21:59 +0000 (UTC) Message-ID: <9f262a81acffffb6e267d5832b29d8596d8046e2.camel@perches.com> Subject: Re: [PATCH v4] docs: Explain the desired position of function attributes From: Joe Perches To: Greg KH , Nick Desaulniers Cc: Kees Cook , Linus Torvalds , Miguel Ojeda , Jonathan Corbet , Randy Dunlap , Alexey Dobriyan , Rasmus Villemoes , Andrew Morton , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-hardening@vger.kernel.org Date: Sat, 02 Oct 2021 08:21:58 -0700 In-Reply-To: References: <20210930235754.2635912-1-keescook@chromium.org> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.40.0-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspamout01 X-Rspamd-Queue-Id: 077632351F3 X-Stat-Signature: soyiqo7o57w1r49asd8u46n98r7p3mry X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX18XHyC4W8Hgtuauvy9FtyuPzQMwcIbmQI8= X-HE-Tag: 1633188119-488567 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2021-10-02 at 08:31 +0200, Greg KH wrote: > I would think that now we have a format that the tools can > actually follow, while before it was semi-random as to what to pick as > the "one true way". There will never be 'one true (and universal) way'. Most existing code doesn't follow the suggested formatting and you can't require or expect the existing code to change. If automated scripts exist to change all the code to that new 'one true way', it wouldn't be applied. > What am I missing here? Try writing a regex for the proposal and make sure to separate out all the various __ attributes into their proper locations... yuck and g'luck.