All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Beulich <jbeulich@suse.com>
To: Wei Liu <wl@xen.org>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"Roger Pau Monné" <roger.pau@citrix.com>,
	"Andrew Cooper" <andrew.cooper3@citrix.com>
Subject: Re: [Xen-devel] [PATCH] x86/MCFG: fix off-by-one in E820 check
Date: Fri, 7 Feb 2020 15:39:37 +0100	[thread overview]
Message-ID: <9f405dbb-799c-1acf-1521-bf1d14a4d968@suse.com> (raw)
In-Reply-To: <20200207142559.rsgsq56utzlcx4eb@debian>

On 07.02.2020 15:25, Wei Liu wrote:
> On Fri, Feb 07, 2020 at 02:25:17PM +0100, Jan Beulich wrote:
>> Also adjust the comment ahead of e820_all_mapped() to clarify that the
>> range is not inclusive at its end.
>>
>> Reported-by: Roger Pau Monné <roger.pau@citrix.com>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
> Reviewed-by: Wei Liu <wl@xen.org>

Thanks.

>> --- a/xen/arch/x86/e820.c
>> +++ b/xen/arch/x86/e820.c
>> @@ -38,7 +38,7 @@ struct e820map e820;
>>  struct e820map __initdata e820_raw;
>>  
>>  /*
>> - * This function checks if the entire range <start,end> is mapped with type.
>> + * This function checks if the entire range [start,end) is mapped with type.
> 
> There is another instance of <> inside e820_all_mapped. It would be good
> if that's fixed too.

That one isn't misleading (talking about just the start of the
region), so I left it alone. But since you've asked for it -
fixed.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2020-02-07 14:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-07 13:25 [Xen-devel] [PATCH] x86/MCFG: fix off-by-one in E820 check Jan Beulich
2020-02-07 14:25 ` Wei Liu
2020-02-07 14:39   ` Jan Beulich [this message]
2020-02-07 14:41 ` Roger Pau Monné

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9f405dbb-799c-1acf-1521-bf1d14a4d968@suse.com \
    --to=jbeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=roger.pau@citrix.com \
    --cc=wl@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.